Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 2ba07ba

Browse files
committed
Finesse some margin glyph stuff
1 parent fd862e8 commit 2ba07ba

File tree

2 files changed

+4
-41
lines changed

2 files changed

+4
-41
lines changed

src/GitHub.InlineReviews/Tags/AddInlineCommentGlyph.xaml

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,9 @@
66
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
77
mc:Ignorable="d">
88

9-
<!-- Resources are defined in \GitHub.VisualStudio.UI\Styles\Theme*.xaml (and Properties\DesignTimeResources.xaml) -->
10-
<UserControl.Style>
11-
<Style TargetType="UserControl">
12-
<Style.Triggers>
13-
<DataTrigger Binding="{Binding DiffChangeType}" Value="Add">
14-
<Setter Property="Background" Value="{DynamicResource GitHubDiffChangeBackground.Add}" />
15-
</DataTrigger>
16-
17-
<DataTrigger Binding="{Binding DiffChangeType}" Value="Delete">
18-
<Setter Property="Background" Value="{DynamicResource GitHubDiffChangeBackground.Delete}" />
19-
</DataTrigger>
20-
21-
<DataTrigger Binding="{Binding DiffChangeType}" Value="None">
22-
<Setter Property="Background" Value="{DynamicResource GitHubDiffChangeBackground.None}" />
23-
</DataTrigger>
24-
</Style.Triggers>
25-
</Style>
26-
</UserControl.Style>
27-
289
<Grid>
2910
<Border Background="{DynamicResource GitHubGlyphMarginCommentableBackground}" BorderThickness="0,0,1,0" />
30-
<Viewbox x:Name="AddViewbox" Margin="1,1,0,0">
11+
<Viewbox x:Name="AddViewbox" Margin="0,1,0,0">
3112
<Canvas Width="14" Height="14">
3213
<Rectangle Width="13" Height="13" Fill="{DynamicResource GitHubDiffGlyphFill.None}"/>
3314
<Rectangle Stroke="#313131" Fill="Transparent" Opacity="0.163" Width="13" Height="13" />

src/GitHub.InlineReviews/Tags/ShowInlineCommentGlyph.xaml

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,9 @@
66
xmlns:cache="clr-namespace:GitHub.UI.Helpers;assembly=GitHub.UI"
77
mc:Ignorable="d">
88

9-
<!-- Resources are defined in \GitHub.VisualStudio.UI\Styles\Theme*.xaml (and Properties\DesignTimeResources.xaml) -->
10-
<UserControl.Style>
11-
<Style TargetType="UserControl">
12-
<Style.Triggers>
13-
<DataTrigger Binding="{Binding DiffChangeType}" Value="Add">
14-
<Setter Property="Background" Value="{DynamicResource GitHubDiffChangeBackground.Add}" />
15-
</DataTrigger>
16-
17-
<DataTrigger Binding="{Binding DiffChangeType}" Value="Delete">
18-
<Setter Property="Background" Value="{DynamicResource GitHubDiffChangeBackground.Delete}" />
19-
</DataTrigger>
20-
21-
<DataTrigger Binding="{Binding DiffChangeType}" Value="None">
22-
<Setter Property="Background" Value="{DynamicResource GitHubDiffChangeBackground.None}" />
23-
</DataTrigger>
24-
</Style.Triggers>
25-
</Style>
26-
</UserControl.Style>
27-
28-
<Grid Background="{DynamicResource GitHubGlyphMarginCommentableBackground}">
29-
<Viewbox HorizontalAlignment="Center" VerticalAlignment="Center">
9+
<Grid>
10+
<Border Background="{DynamicResource GitHubGlyphMarginCommentableBackground}" BorderThickness="0,0,1,0" />
11+
<Viewbox HorizontalAlignment="Center" VerticalAlignment="Center" Margin="0,1,0,0">
3012
<Canvas Width="16" Height="15">
3113
<Path Canvas.Top="1" Canvas.Left="0.85"
3214
Data="M1,0 C0.45,0 0,0.45 0,1 L0,9 C0,9.55 0.45,10 1,10 L3,10 L3,13.5 L6.5,10 L13,10 C13.55,10 14,9.55 14,9 L14,1 C14,0.45 13.55,0 13,0 L1,0 Z" />

0 commit comments

Comments
 (0)