Fix failing tests.

Author: grokys

src/GitHub.InlineReviews/ViewModels/PullRequestReviewCommentViewModel.cs

@@ -96,7 +96,7 @@ public PullRequestReviewCommentViewModel(
                   new ActorViewModel(model.Author), 
                   model.CreatedAt, 
                   review.State == PullRequestReviewState.Pending,
-                  new Uri(model.Url))
+                  model.Url != null ? new Uri(model.Url) : null)
         {
         }
 

test/GitHub.InlineReviews.UnitTests/Services/PullRequestSessionManagerTests.cs

@@ -690,8 +690,7 @@ IPullRequestSessionService CreateRealSessionService(
                     diff,
                     Substitute.For<IApiClientFactory>(),
                     Substitute.For<IGraphQLClientFactory>(),
-                    Substitute.For<IUsageTracker>(),
-                    Substitute.For<IAvatarProvider>());
+                    Substitute.For<IUsageTracker>());
                 result.CreateRebuildSignal().Returns(new Subject<ITextSnapshot>());
                 result.GetPullRequestMergeBase(
                     Arg.Any<ILocalRepositoryModel>(),

test/GitHub.InlineReviews.UnitTests/Services/PullRequestSessionTests.cs

@@ -763,8 +763,7 @@ static IPullRequestSessionService CreateRealSessionService(IDiffService diffServ
                 diffService ?? Substitute.For<IDiffService>(),
                 Substitute.For<IApiClientFactory>(),
                 Substitute.For<IGraphQLClientFactory>(),
-                Substitute.For<IUsageTracker>(),
-                Substitute.For<IAvatarProvider>());
+                Substitute.For<IUsageTracker>());
 
             result.GetTipSha(Arg.Any<ILocalRepositoryModel>()).Returns("BRANCH_TIP");
             result.GetPullRequestMergeBase(Arg.Any<ILocalRepositoryModel>(), Arg.Any<PullRequestDetailModel>())

test/GitHub.InlineReviews.UnitTests/ViewModels/InlineCommentPeekViewModelTests.cs

@@ -302,7 +302,8 @@ InlineCommentModel CreateComment(string body)
                 Comment = new PullRequestReviewCommentModel
                 {
                     Body = body,
-                }
+                },
+                Review = new PullRequestReviewModel(),
             };
         }
 

test/GitHub.InlineReviews.UnitTests/ViewModels/InlineCommentThreadViewModelTests.cs

@@ -72,9 +72,9 @@ InlineCommentModel CreateComment(string id, string body)
                 Comment = new PullRequestReviewCommentModel
                 {
                     Id = id,
-                    //Author = new ActorModel { Login = "CurrentUser" },
                     Body = body,
                 },
+                Review = new PullRequestReviewModel(),
             };
         }
 

test/GitHub.InlineReviews.UnitTests/ViewModels/NewInlineCommentThreadViewModelTests.cs

@@ -20,8 +20,8 @@ public void CreatesReplyPlaceholder()
                 false);
 
             Assert.That(target.Comments, Has.One.Items);
-            Assert.That(string.Empty, Is.EqualTo(target.Comments[0].Body));
-            Assert.That(CommentEditState.Placeholder, Is.EqualTo(target.Comments[0].EditState));
+            Assert.That(target.Comments[0].Body, Is.EqualTo(string.Empty));
+            Assert.That(target.Comments[0].EditState, Is.EqualTo(CommentEditState.Placeholder));
         }
 
         [Test]

test/GitHub.InlineReviews.UnitTests/ViewModels/PullRequestReviewCommentViewModelTests.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Reactive.Linq;
+using System.Threading.Tasks;
 using GitHub.InlineReviews.ViewModels;
 using GitHub.Models;
 using GitHub.Services;
@@ -156,6 +157,11 @@ public void IsUpdateCommentWhenEditingExistingComment()
 
         public class TheStartReviewCommand
         {
+            public TheStartReviewCommand()
+            {
+                Splat.ModeDetector.Current.SetInUnitTestRunner(true);
+            }
+
             [Test]
             public void IsDisabledWhenSessionHasPendingReview()
             {
@@ -240,6 +246,7 @@ static ICommentThreadViewModel CreateThread(
             bool canPost = true)
         {
             var result = Substitute.For<ICommentThreadViewModel>();
+            result.PostComment.Returns(ReactiveCommand.CreateAsyncTask(_ => Task.CompletedTask));
             return result;
         }
     }