Fix failing FetchUsingHttps test

jcansdale · jcansdale · commit fdd2b48cd43c · 2018-06-19T18:17:06.000+01:00
diff --git a/src/GitHub.App/Services/GitClient.cs b/src/GitHub.App/Services/GitClient.cs
@@ -109,16 +109,17 @@ public Task Fetch(IRepository repo, UriString cloneUrl, params string[] refspecs
                 try
                 {
                     var remoteName = cloneUrl.Owner;
-                    var removeRemote = false;
+                    var remoteUri = cloneUrl.ToRepositoryUrl();
 
+                    var removeRemote = false;
                     if (repo.Network.Remotes[remoteName] != null)
                     {
                         // If a remote with this neme already exists, use a unique name and remove remote afterwards
                         remoteName = cloneUrl.Owner + "-" + Guid.NewGuid();
                         removeRemote = true;
                     }
 
-                    var remote = repo.Network.Remotes.Add(remoteName, cloneUrl);
+                    var remote = repo.Network.Remotes.Add(remoteName, remoteUri.ToString());
                     try
                     {
 #pragma warning disable 0618 // TODO: Replace `Network.Fetch` with `Commands.Fetch`.

Original file line number	Diff line number	Diff line change
`@@ -109,16 +109,17 @@ public Task Fetch(IRepository repo, UriString cloneUrl, params string[] refspecs`
`109`	`109`	`try`
`110`	`110`	`{`
`111`	`111`	`var remoteName = cloneUrl.Owner;`
`112`		`- var removeRemote = false;`
	`112`	`+ var remoteUri = cloneUrl.ToRepositoryUrl();`
`113`	`113`
	`114`	`+ var removeRemote = false;`
`114`	`115`	`if (repo.Network.Remotes[remoteName] != null)`
`115`	`116`	`{`
`116`	`117`	`// If a remote with this neme already exists, use a unique name and remove remote afterwards`
`117`	`118`	`remoteName = cloneUrl.Owner + "-" + Guid.NewGuid();`
`118`	`119`	`removeRemote = true;`
`119`	`120`	`}`
`120`	`121`
`121`		`- var remote = repo.Network.Remotes.Add(remoteName, cloneUrl);`
	`122`	`+ var remote = repo.Network.Remotes.Add(remoteName, remoteUri.ToString());`
`122`	`123`	`try`
`123`	`124`	`{`
`124`	`125`	#pragma warning disable 0618 // TODO: Replace `Network.Fetch` with `Commands.Fetch`.