From 5a7775ca132b993a8f8dbd23b740597386fbb8b4 Mon Sep 17 00:00:00 2001
From: Don Okuda <don.okuda@gmail.com>
Date: Thu, 26 Jul 2018 13:35:35 -0700
Subject: [PATCH 1/9] Adjust some row/column definitions

---
 .../Views/GitHubPane/PullRequestCheckView.xaml                | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
index 172be2435c..fba40e8109 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
@@ -35,11 +35,11 @@
             <ColumnDefinition Width="Auto"/>
             <ColumnDefinition Width="Auto"/>
             <ColumnDefinition Width="*"/>
-            <ColumnDefinition Width="Auto"/>
+            <ColumnDefinition MinWidth="50" Width="Auto"/>
         </Grid.ColumnDefinitions>
 
         <Grid.RowDefinitions>
-            <RowDefinition Height="32"/>
+            <RowDefinition MaxHeight="32"/>
         </Grid.RowDefinitions>
 
         <ghfvs:OcticonImage Grid.Column="0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>

From 9c6c5da22f340150fa65e43b4c91ad1650ccfa24 Mon Sep 17 00:00:00 2001
From: Don Okuda <don.okuda@gmail.com>
Date: Thu, 26 Jul 2018 13:35:47 -0700
Subject: [PATCH 2/9] make the avatar smaller

---
 .../Views/GitHubPane/PullRequestCheckView.xaml                  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
index fba40e8109..af07066f8d 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
@@ -45,7 +45,7 @@
         <ghfvs:OcticonImage Grid.Column="0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
         <ghfvs:OcticonImage Grid.Column="0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
         <ghfvs:OcticonImage Grid.Column="0" Icon="clock" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
-        <Image Grid.Column="1" Source="{Binding Avatar}"/>
+        <Image Grid.Column="1" Source="{Binding Avatar}" Height="16" Width="16" />
         <Label Grid.Column="2" Content="{Binding Title}"/>
         <Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
         <Label Grid.Column="4" HorizontalAlignment="Right">

From 276549b2955cd15245356a85658448d880930c2b Mon Sep 17 00:00:00 2001
From: Don Okuda <don.okuda@gmail.com>
Date: Thu, 26 Jul 2018 13:36:06 -0700
Subject: [PATCH 3/9] Hide this description

---
 .../Views/GitHubPane/PullRequestCheckView.xaml                | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
index af07066f8d..dcd0d3a7bc 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
@@ -47,7 +47,9 @@
         <ghfvs:OcticonImage Grid.Column="0" Icon="clock" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
         <Image Grid.Column="1" Source="{Binding Avatar}" Height="16" Width="16" />
         <Label Grid.Column="2" Content="{Binding Title}"/>
-        <Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
+        <!--
+            <Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
+        -->
         <Label Grid.Column="4" HorizontalAlignment="Right">
             <Hyperlink ToolTip="{Binding DetailsUrl}"  Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
         </Label>

From 5c2c0f7a13752529bdfb4e931d05ebeb936d938c Mon Sep 17 00:00:00 2001
From: Don Okuda <don.okuda@gmail.com>
Date: Thu, 26 Jul 2018 13:44:33 -0700
Subject: [PATCH 4/9] Use the primitive dot octicon for pending checks

Just like dotcom
---
 .../Views/GitHubPane/PullRequestCheckView.xaml                  | 2 +-
 .../Views/GitHubPane/PullRequestListItemView.xaml               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
index dcd0d3a7bc..c0ee36c764 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
@@ -44,7 +44,7 @@
 
         <ghfvs:OcticonImage Grid.Column="0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
         <ghfvs:OcticonImage Grid.Column="0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
-        <ghfvs:OcticonImage Grid.Column="0" Icon="clock" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
+        <ghfvs:OcticonImage Grid.Column="0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
         <Image Grid.Column="1" Source="{Binding Avatar}" Height="16" Width="16" />
         <Label Grid.Column="2" Content="{Binding Title}"/>
         <!--
diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListItemView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListItemView.xaml
index cd4a80021f..4d7e261552 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListItemView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestListItemView.xaml
@@ -100,7 +100,7 @@
                 </TextBlock>
                 <ghfvs:OcticonImage Icon="check" Foreground="#2cbe4e" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
                 <ghfvs:OcticonImage Icon="x" Foreground="#cb2431" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
-                <ghfvs:OcticonImage Icon="clock" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
+                <ghfvs:OcticonImage Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Checks, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
             </StackPanel>
         </Grid>
     </Grid>

From 5edce943330e6dbcd59c17d5c7511ed0b5d5eadb Mon Sep 17 00:00:00 2001
From: Don Okuda <don.okuda@gmail.com>
Date: Thu, 26 Jul 2018 13:47:15 -0700
Subject: [PATCH 5/9] Add a lil' bit of right margin

---
 .../Views/GitHubPane/PullRequestCheckView.xaml              | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
index c0ee36c764..5cfe8ec377 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
@@ -42,9 +42,9 @@
             <RowDefinition MaxHeight="32"/>
         </Grid.RowDefinitions>
 
-        <ghfvs:OcticonImage Grid.Column="0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
-        <ghfvs:OcticonImage Grid.Column="0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
-        <ghfvs:OcticonImage Grid.Column="0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
+        <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
+        <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
+        <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
         <Image Grid.Column="1" Source="{Binding Avatar}" Height="16" Width="16" />
         <Label Grid.Column="2" Content="{Binding Title}"/>
         <!--

From 9db38a9c490dde53e3ec1e8813e002f11e30f65c Mon Sep 17 00:00:00 2001
From: Don Okuda <don.okuda@gmail.com>
Date: Mon, 30 Jul 2018 09:11:39 -0700
Subject: [PATCH 6/9] Try out a GridView

---
 .../GitHubPane/PullRequestDetailView.xaml     | 45 ++++++++++++++++++-
 1 file changed, 43 insertions(+), 2 deletions(-)

diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml
index b3926ad886..96a64b8544 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml
@@ -250,13 +250,54 @@
                                       IsExpanded="True"
                                       Margin="0 8 0 0"
                                       ghfvs:ScrollingVerticalStackPanel.IsFixed="true">
-                    <ItemsControl ItemsSource="{Binding Checks}" Margin="0 4 12 4">
+                    <ListView ItemsSource="{Binding Checks}" Margin="0 4 12 4">
+                        <ListView.View>
+                            <GridView>
+                                <!-- Column for check status octicon -->
+                                <GridViewColumn>
+                                    <GridViewColumn.CellTemplate>
+                                        <DataTemplate>
+                                            <StackPanel>
+                                                <ghfvs:OcticonImage Margin="0 0 4 0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
+                                                <ghfvs:OcticonImage Margin="0 0 4 0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
+                                                <ghfvs:OcticonImage Margin="0 0 4 0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
+                                            </StackPanel>
+                                        </DataTemplate>
+                                    </GridViewColumn.CellTemplate>
+                                </GridViewColumn>
+
+                                <!-- Checks Logo -->
+                                <GridViewColumn>
+                                    <GridViewColumn.CellTemplate>
+                                        <DataTemplate>
+                                            <Image Source="{Binding Avatar}" Height="16" Width="16" />
+                                        </DataTemplate>
+                                    </GridViewColumn.CellTemplate>
+                                </GridViewColumn>
+
+                                <!-- Title -->
+                                <GridViewColumn DisplayMemberBinding="{Binding Title}" />
+
+                                <!-- Details -->
+                                <GridViewColumn>
+                                    <GridViewColumn.CellTemplate>
+                                        <DataTemplate>
+                                            <Label Grid.Column="4" HorizontalAlignment="Right">
+                                                <Hyperlink ToolTip="{Binding DetailsUrl}"  Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
+                                            </Label>
+                                        </DataTemplate>
+                                    </GridViewColumn.CellTemplate>
+                                </GridViewColumn>
+                            </GridView>
+                        </ListView.View>
+                        <!--
                         <ItemsControl.ItemTemplate>
                             <DataTemplate>
                                 <local:PullRequestCheckView/>
                             </DataTemplate>
                         </ItemsControl.ItemTemplate>
-                    </ItemsControl>
+                        -->
+                    </ListView>
                 </ghfvs:SectionControl>
 
                 <!-- Files changed -->

From d279d06d4b37b2a5b6201b1805c75409d237a03b Mon Sep 17 00:00:00 2001
From: Don Okuda <don.okuda@gmail.com>
Date: Mon, 30 Jul 2018 13:16:15 -0700
Subject: [PATCH 7/9] Use IsSharedSizeScope so that Grid Rendering works

Shout out to https://stackoverflow.com/questions/16596579/how-to-setup-a-grid-as-template-for-an-items-control#16609497
---
 .../GitHubPane/PullRequestCheckView.xaml      |  9 ++--
 .../GitHubPane/PullRequestDetailView.xaml     | 50 +++----------------
 2 files changed, 12 insertions(+), 47 deletions(-)

diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
index 5cfe8ec377..5e1786f679 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
@@ -29,13 +29,14 @@
         </ResourceDictionary>
     </Control.Resources>
 
+
     <Grid>
         <Grid.ColumnDefinitions>
-            <ColumnDefinition Width="Auto"/>
-            <ColumnDefinition Width="Auto"/>
-            <ColumnDefinition Width="Auto"/>
+            <ColumnDefinition Width="Auto" SharedSizeGroup="ColumnZero" />
+            <ColumnDefinition Width="Auto" SharedSizeGroup="ColumnOne" />
+            <ColumnDefinition Width="Auto" SharedSizeGroup="ColumnTwo" />
             <ColumnDefinition Width="*"/>
-            <ColumnDefinition MinWidth="50" Width="Auto"/>
+            <ColumnDefinition MinWidth="50" Width="Auto" SharedSizeGroup="ColumnFour" />
         </Grid.ColumnDefinitions>
 
         <Grid.RowDefinitions>
diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml
index 96a64b8544..d2c221ad99 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml
@@ -250,54 +250,18 @@
                                       IsExpanded="True"
                                       Margin="0 8 0 0"
                                       ghfvs:ScrollingVerticalStackPanel.IsFixed="true">
-                    <ListView ItemsSource="{Binding Checks}" Margin="0 4 12 4">
-                        <ListView.View>
-                            <GridView>
-                                <!-- Column for check status octicon -->
-                                <GridViewColumn>
-                                    <GridViewColumn.CellTemplate>
-                                        <DataTemplate>
-                                            <StackPanel>
-                                                <ghfvs:OcticonImage Margin="0 0 4 0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
-                                                <ghfvs:OcticonImage Margin="0 0 4 0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
-                                                <ghfvs:OcticonImage Margin="0 0 4 0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
-                                            </StackPanel>
-                                        </DataTemplate>
-                                    </GridViewColumn.CellTemplate>
-                                </GridViewColumn>
-
-                                <!-- Checks Logo -->
-                                <GridViewColumn>
-                                    <GridViewColumn.CellTemplate>
-                                        <DataTemplate>
-                                            <Image Source="{Binding Avatar}" Height="16" Width="16" />
-                                        </DataTemplate>
-                                    </GridViewColumn.CellTemplate>
-                                </GridViewColumn>
-
-                                <!-- Title -->
-                                <GridViewColumn DisplayMemberBinding="{Binding Title}" />
-
-                                <!-- Details -->
-                                <GridViewColumn>
-                                    <GridViewColumn.CellTemplate>
-                                        <DataTemplate>
-                                            <Label Grid.Column="4" HorizontalAlignment="Right">
-                                                <Hyperlink ToolTip="{Binding DetailsUrl}"  Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
-                                            </Label>
-                                        </DataTemplate>
-                                    </GridViewColumn.CellTemplate>
-                                </GridViewColumn>
-                            </GridView>
-                        </ListView.View>
-                        <!--
+                    <ItemsControl ItemsSource="{Binding Checks}" Margin="0 4 12 4">
+                        <ItemsControl.ItemsPanel>
+                            <ItemsPanelTemplate>
+                                <StackPanel Grid.IsSharedSizeScope="True" />
+                            </ItemsPanelTemplate>
+                        </ItemsControl.ItemsPanel>
                         <ItemsControl.ItemTemplate>
                             <DataTemplate>
                                 <local:PullRequestCheckView/>
                             </DataTemplate>
                         </ItemsControl.ItemTemplate>
-                        -->
-                    </ListView>
+                    </ItemsControl>
                 </ghfvs:SectionControl>
 
                 <!-- Files changed -->

From 86b3942eecc5a1710e54cdb56eb2b1716d685405 Mon Sep 17 00:00:00 2001
From: Don Okuda <don.okuda@gmail.com>
Date: Mon, 30 Jul 2018 13:20:14 -0700
Subject: [PATCH 8/9] Remove extra line

oops.
---
 .../Views/GitHubPane/PullRequestCheckView.xaml                   | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
index 5e1786f679..c37c60c323 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
@@ -29,7 +29,6 @@
         </ResourceDictionary>
     </Control.Resources>
 
-
     <Grid>
         <Grid.ColumnDefinitions>
             <ColumnDefinition Width="Auto" SharedSizeGroup="ColumnZero" />

From b0cdcf0948058cd2360341eafea8acde5997a892 Mon Sep 17 00:00:00 2001
From: Don Okuda <don.okuda@gmail.com>
Date: Mon, 30 Jul 2018 13:29:58 -0700
Subject: [PATCH 9/9] Fix text color for dark theme

---
 .../Views/GitHubPane/PullRequestCheckView.xaml                  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
index c37c60c323..f821d61a02 100644
--- a/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
+++ b/src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml
@@ -46,7 +46,7 @@
         <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
         <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
         <Image Grid.Column="1" Source="{Binding Avatar}" Height="16" Width="16" />
-        <Label Grid.Column="2" Content="{Binding Title}"/>
+        <Label Grid.Column="2" Foreground="{DynamicResource VsBrush.WindowText}" Content="{Binding Title}"/>
         <!--
             <Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
         -->