From 646fad4550ec103ca780b76f897093cb8106d6fe Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Thu, 23 Aug 2018 09:56:34 +0100 Subject: [PATCH 1/3] No TargetVersion for GitHub.TeamFoundation.15 Don't specify a target Visual Studio version for the GitHub.TeamFoundation.15 MEF assembly. Specifying a TargetVersion was causing it to sometimes incorrectly be excluded when installed on some Visual Studio 2017 versions. We can leave TargetVersion on the GitHub.TeamFoundation.14 MEF assembly because this attribute isn't supported on Visual Studio 2015 and we do want it excluded on Visual Studio 2017. This is a workaround for #1859. --- src/GitHub.VisualStudio/source.extension.vsixmanifest | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/GitHub.VisualStudio/source.extension.vsixmanifest b/src/GitHub.VisualStudio/source.extension.vsixmanifest index 0d6f193d9d..d9520a3e40 100644 --- a/src/GitHub.VisualStudio/source.extension.vsixmanifest +++ b/src/GitHub.VisualStudio/source.extension.vsixmanifest @@ -30,7 +30,7 @@ - + From d1717902aa3a42370b9ae03b1acfa0393f09d188 Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Thu, 23 Aug 2018 11:02:30 +0100 Subject: [PATCH 2/3] Install for VS 2017 when version reported as 1.x Sometimes servicehub's version is used (currently ~1.3) when installing for Visual Studio 2017. If the VS version is reported as 1.x, assume we're installing for Visual Studio 2017. --- src/GitHub.VisualStudio/source.extension.vsixmanifest | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/GitHub.VisualStudio/source.extension.vsixmanifest b/src/GitHub.VisualStudio/source.extension.vsixmanifest index d9520a3e40..316047a5f4 100644 --- a/src/GitHub.VisualStudio/source.extension.vsixmanifest +++ b/src/GitHub.VisualStudio/source.extension.vsixmanifest @@ -30,7 +30,9 @@ - + + + From d5a9bc31824bd8ae90f16f1a3a5e9c4d36f9a1ec Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Fri, 24 Aug 2018 11:03:41 +0100 Subject: [PATCH 3/3] Update comment and add link to PR --- src/GitHub.VisualStudio/source.extension.vsixmanifest | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/GitHub.VisualStudio/source.extension.vsixmanifest b/src/GitHub.VisualStudio/source.extension.vsixmanifest index 316047a5f4..8c2ce70019 100644 --- a/src/GitHub.VisualStudio/source.extension.vsixmanifest +++ b/src/GitHub.VisualStudio/source.extension.vsixmanifest @@ -31,7 +31,7 @@ - +