From 71ed4554a6ec54a7522e353df23993ffc3ac9528 Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Wed, 19 Sep 2018 10:29:11 +0100 Subject: [PATCH 1/7] Remove BuildTasks.14/BuildTools.15 switching Remove the conditional logic that would switch between BuildTasks.14/BuildTools.15 based on the target Visual Studio version in StartProgram. Only use the Microsoft.VSSDK.BuildTools.15.0 package. --- src/GitHub.VisualStudio/GitHub.VisualStudio.csproj | 11 ++--------- src/GitHub.VisualStudio/packages.config | 1 - 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj b/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj index f459410743..e9f12d4a82 100644 --- a/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj +++ b/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj @@ -3,11 +3,7 @@ - - 14.0 - - - + $(MSBuildToolsVersion) @@ -864,11 +860,8 @@ - - - - + \ No newline at end of file diff --git a/src/GitHub.VisualStudio/packages.config b/src/GitHub.VisualStudio/packages.config index 25b3a34c75..6263f2035d 100644 --- a/src/GitHub.VisualStudio/packages.config +++ b/src/GitHub.VisualStudio/packages.config @@ -13,7 +13,6 @@ - From 45fd097bb578a55cfcfd1a57b5888beae29707b8 Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Wed, 19 Sep 2018 11:11:18 +0100 Subject: [PATCH 2/7] Use same Microsoft.VSSDK.BuildTools in all .csproj Use Microsoft.VSSDK.BuildTools.15.0.26201 in all projects. --- src/GitHub.InlineReviews/GitHub.InlineReviews.csproj | 8 ++++---- src/GitHub.InlineReviews/packages.config | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj b/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj index 1e0c3a3f7c..7f0b017643 100644 --- a/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj +++ b/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj @@ -1,7 +1,7 @@  - + $(VisualStudioVersion) @@ -488,11 +488,11 @@ This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - - + + - + @@ -198,11 +197,8 @@ - - - - From 1f8d143e57480986faa1dc59348033afef483f7c Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Wed, 19 Sep 2018 11:49:05 +0100 Subject: [PATCH 5/7] Update to Microsoft.VSSDK.BuildTools.15.8.3252 --- .../GitHub.InlineReviews.csproj | 14 ++++++++++---- src/GitHub.InlineReviews/packages.config | 4 +++- src/GitHub.StartPage/GitHub.StartPage.csproj | 16 ++++++++++++---- src/GitHub.StartPage/packages.config | 4 +++- .../GitHub.VisualStudio.csproj | 14 ++++++++++---- src/GitHub.VisualStudio/packages.config | 4 +++- 6 files changed, 41 insertions(+), 15 deletions(-) diff --git a/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj b/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj index 7f0b017643..e5ba94ebfe 100644 --- a/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj +++ b/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj @@ -1,7 +1,7 @@  + - $(VisualStudioVersion) @@ -474,6 +474,8 @@ + + @@ -488,11 +490,15 @@ This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - - + + + + - + + + $(VisualStudioVersion) $(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion) true + + @@ -187,18 +189,24 @@ + + + This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - - + + + + - + + $(MSBuildToolsVersion) @@ -840,6 +840,8 @@ + + @@ -856,10 +858,14 @@ This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - - + + + + - + + + \ No newline at end of file diff --git a/src/GitHub.VisualStudio/packages.config b/src/GitHub.VisualStudio/packages.config index 6263f2035d..0cd0fc1afd 100644 --- a/src/GitHub.VisualStudio/packages.config +++ b/src/GitHub.VisualStudio/packages.config @@ -13,6 +13,7 @@ + @@ -31,9 +32,10 @@ + - + From 714488b146070f0b3dfbcdc39de10a4d52f7f749 Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Wed, 19 Sep 2018 12:03:00 +0100 Subject: [PATCH 6/7] Remove SDK and Threading Analyzers for the moment Should restore and fix errors in another PR. --- src/GitHub.InlineReviews/GitHub.InlineReviews.csproj | 2 -- src/GitHub.StartPage/GitHub.StartPage.csproj | 2 -- src/GitHub.VisualStudio/GitHub.VisualStudio.csproj | 2 -- 3 files changed, 6 deletions(-) diff --git a/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj b/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj index e5ba94ebfe..65e7fb0387 100644 --- a/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj +++ b/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj @@ -474,8 +474,6 @@ - - diff --git a/src/GitHub.StartPage/GitHub.StartPage.csproj b/src/GitHub.StartPage/GitHub.StartPage.csproj index 1e07d39a50..8e3823e465 100644 --- a/src/GitHub.StartPage/GitHub.StartPage.csproj +++ b/src/GitHub.StartPage/GitHub.StartPage.csproj @@ -189,8 +189,6 @@ - - diff --git a/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj b/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj index 415063678f..7e5dc74000 100644 --- a/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj +++ b/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj @@ -840,8 +840,6 @@ - - From 40aa999b3386b40909a005fe9b1b750bf617a3e6 Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Wed, 19 Sep 2018 13:41:38 +0100 Subject: [PATCH 7/7] Remove packages.config file for Sdk style projects We're now using for these projects. --- .../GitHub.Extensions.csproj | 1 - src/GitHub.UI.Reactive/packages.config | 10 ----- src/GitHub.UI/packages.config | 7 --- src/GitHub.VisualStudio.UI/packages.config | 7 --- test/GitHub.Api.UnitTests/packages.config | 28 ------------ test/GitHub.App.UnitTests/packages.config | 45 ------------------- .../packages.config | 35 --------------- test/GitHub.Exports.UnitTests/packages.config | 31 ------------- .../packages.config | 13 ------ .../packages.config | 24 ---------- .../packages.config | 37 --------------- test/GitHub.UI.UnitTests/packages.config | 5 --- .../packages.config | 40 ----------------- test/TrackingCollectionTests/packages.config | 10 ----- 14 files changed, 293 deletions(-) delete mode 100644 src/GitHub.UI.Reactive/packages.config delete mode 100644 src/GitHub.UI/packages.config delete mode 100644 src/GitHub.VisualStudio.UI/packages.config delete mode 100644 test/GitHub.Api.UnitTests/packages.config delete mode 100644 test/GitHub.App.UnitTests/packages.config delete mode 100644 test/GitHub.Exports.Reactive.UnitTests/packages.config delete mode 100644 test/GitHub.Exports.UnitTests/packages.config delete mode 100644 test/GitHub.Extensions.UnitTests/packages.config delete mode 100644 test/GitHub.InlineReviews.UnitTests/packages.config delete mode 100644 test/GitHub.TeamFoundation.UnitTests/packages.config delete mode 100644 test/GitHub.UI.UnitTests/packages.config delete mode 100644 test/GitHub.VisualStudio.UnitTests/packages.config delete mode 100644 test/TrackingCollectionTests/packages.config diff --git a/src/GitHub.Extensions/GitHub.Extensions.csproj b/src/GitHub.Extensions/GitHub.Extensions.csproj index 15f475fd17..8f61d95b9b 100644 --- a/src/GitHub.Extensions/GitHub.Extensions.csproj +++ b/src/GitHub.Extensions/GitHub.Extensions.csproj @@ -25,7 +25,6 @@ - diff --git a/src/GitHub.UI.Reactive/packages.config b/src/GitHub.UI.Reactive/packages.config deleted file mode 100644 index 3a6b3c833a..0000000000 --- a/src/GitHub.UI.Reactive/packages.config +++ /dev/null @@ -1,10 +0,0 @@ - - - - - - - - - - \ No newline at end of file diff --git a/src/GitHub.UI/packages.config b/src/GitHub.UI/packages.config deleted file mode 100644 index ea78bb8317..0000000000 --- a/src/GitHub.UI/packages.config +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/src/GitHub.VisualStudio.UI/packages.config b/src/GitHub.VisualStudio.UI/packages.config deleted file mode 100644 index eff341d4fa..0000000000 --- a/src/GitHub.VisualStudio.UI/packages.config +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/test/GitHub.Api.UnitTests/packages.config b/test/GitHub.Api.UnitTests/packages.config deleted file mode 100644 index b2455522fe..0000000000 --- a/test/GitHub.Api.UnitTests/packages.config +++ /dev/null @@ -1,28 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/GitHub.App.UnitTests/packages.config b/test/GitHub.App.UnitTests/packages.config deleted file mode 100644 index 84d11fa23a..0000000000 --- a/test/GitHub.App.UnitTests/packages.config +++ /dev/null @@ -1,45 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/GitHub.Exports.Reactive.UnitTests/packages.config b/test/GitHub.Exports.Reactive.UnitTests/packages.config deleted file mode 100644 index 58eae675b6..0000000000 --- a/test/GitHub.Exports.Reactive.UnitTests/packages.config +++ /dev/null @@ -1,35 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/GitHub.Exports.UnitTests/packages.config b/test/GitHub.Exports.UnitTests/packages.config deleted file mode 100644 index 6845f9e0c7..0000000000 --- a/test/GitHub.Exports.UnitTests/packages.config +++ /dev/null @@ -1,31 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/GitHub.Extensions.UnitTests/packages.config b/test/GitHub.Extensions.UnitTests/packages.config deleted file mode 100644 index ab0809708f..0000000000 --- a/test/GitHub.Extensions.UnitTests/packages.config +++ /dev/null @@ -1,13 +0,0 @@ - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/GitHub.InlineReviews.UnitTests/packages.config b/test/GitHub.InlineReviews.UnitTests/packages.config deleted file mode 100644 index d294d83d7e..0000000000 --- a/test/GitHub.InlineReviews.UnitTests/packages.config +++ /dev/null @@ -1,24 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/GitHub.TeamFoundation.UnitTests/packages.config b/test/GitHub.TeamFoundation.UnitTests/packages.config deleted file mode 100644 index 997587c79f..0000000000 --- a/test/GitHub.TeamFoundation.UnitTests/packages.config +++ /dev/null @@ -1,37 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/GitHub.UI.UnitTests/packages.config b/test/GitHub.UI.UnitTests/packages.config deleted file mode 100644 index d6681c84e9..0000000000 --- a/test/GitHub.UI.UnitTests/packages.config +++ /dev/null @@ -1,5 +0,0 @@ - - - - - \ No newline at end of file diff --git a/test/GitHub.VisualStudio.UnitTests/packages.config b/test/GitHub.VisualStudio.UnitTests/packages.config deleted file mode 100644 index fac77cd62c..0000000000 --- a/test/GitHub.VisualStudio.UnitTests/packages.config +++ /dev/null @@ -1,40 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/TrackingCollectionTests/packages.config b/test/TrackingCollectionTests/packages.config deleted file mode 100644 index e212deab8f..0000000000 --- a/test/TrackingCollectionTests/packages.config +++ /dev/null @@ -1,10 +0,0 @@ - - - - - - - - - - \ No newline at end of file