From 07eba4e3b14b30bbcbbbac405a7ff257729eefcd Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Fri, 3 Nov 2023 17:03:02 +0000 Subject: [PATCH] Swift: Fix some failing tests, looks like this could be the result of some recently merged PRs interacting (positively!) --- .../ql/test/library-tests/dataflow/taint/libraries/string.swift | 2 +- swift/ql/test/library-tests/dataflow/taint/libraries/url.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/swift/ql/test/library-tests/dataflow/taint/libraries/string.swift b/swift/ql/test/library-tests/dataflow/taint/libraries/string.swift index 266f80a22084..de13c17c3bb0 100644 --- a/swift/ql/test/library-tests/dataflow/taint/libraries/string.swift +++ b/swift/ql/test/library-tests/dataflow/taint/libraries/string.swift @@ -462,7 +462,7 @@ func taintFromUInt8Array() { let r2 = String(unsafeUninitializedCapacity: 256, initializingUTF8With: { (buffer: UnsafeMutableBufferPointer) -> Int in sink(arg: buffer[0]) - sink(arg: taintedUInt8Values[0]) // $ MISSING: tainted=450 + sink(arg: taintedUInt8Values[0]) // $ tainted=450 let _ = buffer.initialize(from: taintedUInt8Values) sink(arg: buffer[0]) // $ MISSING: tainted=450 return 256 diff --git a/swift/ql/test/library-tests/dataflow/taint/libraries/url.swift b/swift/ql/test/library-tests/dataflow/taint/libraries/url.swift index 694e98c81324..799eaa85807f 100644 --- a/swift/ql/test/library-tests/dataflow/taint/libraries/url.swift +++ b/swift/ql/test/library-tests/dataflow/taint/libraries/url.swift @@ -287,7 +287,7 @@ func taintThroughURL() { let _ = clean.withCString({ ptrClean in sink(arg: URL(fileURLWithFileSystemRepresentation: ptrClean, isDirectory: false, relativeTo: nil)) - sink(arg: URL(fileURLWithFileSystemRepresentation: ptrClean, isDirectory: false, relativeTo: urlTainted)) // $ MISSING: tainted=210 + sink(arg: URL(fileURLWithFileSystemRepresentation: ptrClean, isDirectory: false, relativeTo: urlTainted)) // $ tainted=210 }); sink(arg: URL(fileURLWithFileSystemRepresentation: 0 as! UnsafePointer, isDirectory: false, relativeTo: urlTainted)) // $ tainted=210 let _ = tainted.withCString({