From 839fd8f848e4336c8301b2a082d220d908b66a99 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Fri, 17 Jan 2020 16:01:11 +0000 Subject: [PATCH 1/3] CPP: Fix typo. --- .../code/cpp/ir/implementation/aliased_ssa/Instruction.qll | 2 +- .../src/semmle/code/cpp/ir/implementation/raw/Instruction.qll | 2 +- .../code/cpp/ir/implementation/unaliased_ssa/Instruction.qll | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll index a4a9718ab95f..3aa5d80359eb 100644 --- a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll +++ b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll @@ -974,7 +974,7 @@ class InheritanceConversionInstruction extends UnaryInstruction { /** * Represents an instruction that converts from the address of a derived class - * to the address of a direct non-virtual base class. + * to the address of a direct base class. */ class ConvertToBaseInstruction extends InheritanceConversionInstruction { ConvertToBaseInstruction() { getOpcode() instanceof ConvertToBaseOpcode } diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll index a4a9718ab95f..3aa5d80359eb 100644 --- a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll +++ b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll @@ -974,7 +974,7 @@ class InheritanceConversionInstruction extends UnaryInstruction { /** * Represents an instruction that converts from the address of a derived class - * to the address of a direct non-virtual base class. + * to the address of a direct base class. */ class ConvertToBaseInstruction extends InheritanceConversionInstruction { ConvertToBaseInstruction() { getOpcode() instanceof ConvertToBaseOpcode } diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll index a4a9718ab95f..3aa5d80359eb 100644 --- a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll +++ b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll @@ -974,7 +974,7 @@ class InheritanceConversionInstruction extends UnaryInstruction { /** * Represents an instruction that converts from the address of a derived class - * to the address of a direct non-virtual base class. + * to the address of a direct base class. */ class ConvertToBaseInstruction extends InheritanceConversionInstruction { ConvertToBaseInstruction() { getOpcode() instanceof ConvertToBaseOpcode } From e4139fe42770d636a6eb0f6a7b51a4c66c7663b8 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Fri, 17 Jan 2020 17:20:37 +0000 Subject: [PATCH 2/3] Apply suggestions from code review Additional corrections. Co-Authored-By: Dave Bartolomeo --- .../code/cpp/ir/implementation/aliased_ssa/Instruction.qll | 2 +- .../src/semmle/code/cpp/ir/implementation/raw/Instruction.qll | 2 +- .../code/cpp/ir/implementation/unaliased_ssa/Instruction.qll | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll index 3aa5d80359eb..1ac811c7eb00 100644 --- a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll +++ b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll @@ -974,7 +974,7 @@ class InheritanceConversionInstruction extends UnaryInstruction { /** * Represents an instruction that converts from the address of a derived class - * to the address of a direct base class. + * to the address of a base class. */ class ConvertToBaseInstruction extends InheritanceConversionInstruction { ConvertToBaseInstruction() { getOpcode() instanceof ConvertToBaseOpcode } diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll index 3aa5d80359eb..1ac811c7eb00 100644 --- a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll +++ b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll @@ -974,7 +974,7 @@ class InheritanceConversionInstruction extends UnaryInstruction { /** * Represents an instruction that converts from the address of a derived class - * to the address of a direct base class. + * to the address of a base class. */ class ConvertToBaseInstruction extends InheritanceConversionInstruction { ConvertToBaseInstruction() { getOpcode() instanceof ConvertToBaseOpcode } diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll index 3aa5d80359eb..1ac811c7eb00 100644 --- a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll +++ b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll @@ -974,7 +974,7 @@ class InheritanceConversionInstruction extends UnaryInstruction { /** * Represents an instruction that converts from the address of a derived class - * to the address of a direct base class. + * to the address of a base class. */ class ConvertToBaseInstruction extends InheritanceConversionInstruction { ConvertToBaseInstruction() { getOpcode() instanceof ConvertToBaseOpcode } From 6743d6d6e5530b1b85a3ceb6567e5af1e4e4a1a5 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Thu, 23 Jan 2020 10:22:36 +0000 Subject: [PATCH 3/3] C#: sync-indentical-files. --- .../semmle/code/csharp/ir/implementation/raw/Instruction.qll | 2 +- .../code/csharp/ir/implementation/unaliased_ssa/Instruction.qll | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll b/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll index a4a9718ab95f..1ac811c7eb00 100644 --- a/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll +++ b/csharp/ql/src/semmle/code/csharp/ir/implementation/raw/Instruction.qll @@ -974,7 +974,7 @@ class InheritanceConversionInstruction extends UnaryInstruction { /** * Represents an instruction that converts from the address of a derived class - * to the address of a direct non-virtual base class. + * to the address of a base class. */ class ConvertToBaseInstruction extends InheritanceConversionInstruction { ConvertToBaseInstruction() { getOpcode() instanceof ConvertToBaseOpcode } diff --git a/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll b/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll index a4a9718ab95f..1ac811c7eb00 100644 --- a/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll +++ b/csharp/ql/src/semmle/code/csharp/ir/implementation/unaliased_ssa/Instruction.qll @@ -974,7 +974,7 @@ class InheritanceConversionInstruction extends UnaryInstruction { /** * Represents an instruction that converts from the address of a derived class - * to the address of a direct non-virtual base class. + * to the address of a base class. */ class ConvertToBaseInstruction extends InheritanceConversionInstruction { ConvertToBaseInstruction() { getOpcode() instanceof ConvertToBaseOpcode }