From 9c0ba5187301991d06c8debb1f9df49160c94ebe Mon Sep 17 00:00:00 2001 From: Jonas Jensen Date: Wed, 3 Oct 2018 15:02:15 +0200 Subject: [PATCH] C++: Make cpp/missing-return visible on LGTM again --- change-notes/1.19/analysis-cpp.md | 1 + cpp/ql/src/jsf/4.13 Functions/AV Rule 114.ql | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/change-notes/1.19/analysis-cpp.md b/change-notes/1.19/analysis-cpp.md index 17cce1a5d529..9bc73fda28c4 100644 --- a/change-notes/1.19/analysis-cpp.md +++ b/change-notes/1.19/analysis-cpp.md @@ -14,6 +14,7 @@ |----------------------------|------------------------|------------------------------------------------------------------| | Resource not released in destructor | Fewer false positive results | Placement new is now excluded from the query. | | Wrong type of arguments to formatting function | Fewer false positive results | False positive results involving typedefs have been removed. | +| Missing return statement (`cpp/missing-return`) | Visible by default | The precision of this query has been increased from 'medium' to 'high', which makes it visible by default in LGTM. It was 'medium' in release 1.17 and 1.18 because it had false positives due to an extractor bug that was fixed in 1.18. | ## Changes to QL libraries diff --git a/cpp/ql/src/jsf/4.13 Functions/AV Rule 114.ql b/cpp/ql/src/jsf/4.13 Functions/AV Rule 114.ql index 71bab6e01be7..61c3413d35d9 100644 --- a/cpp/ql/src/jsf/4.13 Functions/AV Rule 114.ql +++ b/cpp/ql/src/jsf/4.13 Functions/AV Rule 114.ql @@ -3,7 +3,7 @@ * @description All functions that are not void should return a value on every exit path. * @kind problem * @problem.severity error - * @precision medium + * @precision high * @id cpp/missing-return * @tags reliability * readability