From 67db1df00c5b9e2a473776c07015bb7191e00a7f Mon Sep 17 00:00:00 2001
From: Anders Schack-Mulligen <aschackmull@github.com>
Date: Tue, 7 Jul 2020 11:39:27 +0200
Subject: [PATCH] C++/C#/JavaScript/Python: Port Location qldoc update.

---
 cpp/ql/src/semmle/code/cpp/Location.qll           | 8 ++++----
 csharp/ql/src/semmle/code/csharp/Location.qll     | 8 ++++----
 javascript/ql/src/semmle/javascript/Locations.qll | 8 ++++----
 python/ql/src/semmle/python/Files.qll             | 8 ++++----
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/cpp/ql/src/semmle/code/cpp/Location.qll b/cpp/ql/src/semmle/code/cpp/Location.qll
index 8fff1808c87d..74bf0872be25 100644
--- a/cpp/ql/src/semmle/code/cpp/Location.qll
+++ b/cpp/ql/src/semmle/code/cpp/Location.qll
@@ -15,16 +15,16 @@ class Location extends @location {
   /** Gets the file corresponding to this location, if any. */
   File getFile() { result = this.getContainer() }
 
-  /** Gets the start line of this location. */
+  /** Gets the 1-based line number (inclusive) where this location starts. */
   int getStartLine() { this.fullLocationInfo(_, result, _, _, _) }
 
-  /** Gets the start column of this location. */
+  /** Gets the 1-based column number (inclusive) where this location starts. */
   int getStartColumn() { this.fullLocationInfo(_, _, result, _, _) }
 
-  /** Gets the end line of this location. */
+  /** Gets the 1-based line number (inclusive) where this location ends. */
   int getEndLine() { this.fullLocationInfo(_, _, _, result, _) }
 
-  /** Gets the end column of this location. */
+  /** Gets the 1-based column number (inclusive) where this location ends. */
   int getEndColumn() { this.fullLocationInfo(_, _, _, _, result) }
 
   /**
diff --git a/csharp/ql/src/semmle/code/csharp/Location.qll b/csharp/ql/src/semmle/code/csharp/Location.qll
index 178eddc1d4d7..99df294ae636 100644
--- a/csharp/ql/src/semmle/code/csharp/Location.qll
+++ b/csharp/ql/src/semmle/code/csharp/Location.qll
@@ -38,16 +38,16 @@ class Location extends @location {
   /** Gets a textual representation of this location. */
   string toString() { none() }
 
-  /** Gets the start line of this location. */
+  /** Gets the 1-based line number (inclusive) where this location starts. */
   final int getStartLine() { this.hasLocationInfo(_, result, _, _, _) }
 
-  /** Gets the end line of this location. */
+  /** Gets the 1-based line number (inclusive) where this location ends. */
   final int getEndLine() { this.hasLocationInfo(_, _, _, result, _) }
 
-  /** Gets the start column of this location. */
+  /** Gets the 1-based column number (inclusive) where this location starts. */
   final int getStartColumn() { this.hasLocationInfo(_, _, result, _, _) }
 
-  /** Gets the end column of this location. */
+  /** Gets the 1-based column number (inclusive) where this location ends. */
   final int getEndColumn() { this.hasLocationInfo(_, _, _, _, result) }
 }
 
diff --git a/javascript/ql/src/semmle/javascript/Locations.qll b/javascript/ql/src/semmle/javascript/Locations.qll
index 72939c8b4197..5f6a00503596 100644
--- a/javascript/ql/src/semmle/javascript/Locations.qll
+++ b/javascript/ql/src/semmle/javascript/Locations.qll
@@ -12,16 +12,16 @@ class Location extends @location {
   /** Gets the file for this location. */
   File getFile() { locations_default(this, result, _, _, _, _) }
 
-  /** Gets the start line of this location. */
+  /** Gets the 1-based line number (inclusive) where this location starts. */
   int getStartLine() { locations_default(this, _, result, _, _, _) }
 
-  /** Gets the start column of this location. */
+  /** Gets the 1-based column number (inclusive) where this location starts. */
   int getStartColumn() { locations_default(this, _, _, result, _, _) }
 
-  /** Gets the end line of this location. */
+  /** Gets the 1-based line number (inclusive) where this location ends. */
   int getEndLine() { locations_default(this, _, _, _, result, _) }
 
-  /** Gets the end column of this location. */
+  /** Gets the 1-based column number (inclusive) where this location ends. */
   int getEndColumn() { locations_default(this, _, _, _, _, result) }
 
   /** Gets the number of lines covered by this location. */
diff --git a/python/ql/src/semmle/python/Files.qll b/python/ql/src/semmle/python/Files.qll
index c4b713728580..f92297b6a9ba 100644
--- a/python/ql/src/semmle/python/Files.qll
+++ b/python/ql/src/semmle/python/Files.qll
@@ -369,25 +369,25 @@ class Location extends @location {
         exists(Module m | locations_ast(this, m, _, _, _, _) | result = m.getPath())
     }
 
-    /** Gets the start line of this location */
+    /** Gets the 1-based line number (inclusive) where this location starts. */
     int getStartLine() {
         locations_default(this, _, result, _, _, _) or
         locations_ast(this, _, result, _, _, _)
     }
 
-    /** Gets the start column of this location */
+    /** Gets the 1-based column number (inclusive) where this location starts. */
     int getStartColumn() {
         locations_default(this, _, _, result, _, _) or
         locations_ast(this, _, _, result, _, _)
     }
 
-    /** Gets the end line of this location */
+    /** Gets the 1-based line number (inclusive) where this location ends. */
     int getEndLine() {
         locations_default(this, _, _, _, result, _) or
         locations_ast(this, _, _, _, result, _)
     }
 
-    /** Gets the end column of this location */
+    /** Gets the 1-based column number (inclusive) where this location ends. */
     int getEndColumn() {
         locations_default(this, _, _, _, _, result) or
         locations_ast(this, _, _, _, _, result)