From 5fe99a9b3c80b2c298667a37fed0c0d027307003 Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Sat, 31 Oct 2020 12:17:57 +0100 Subject: [PATCH 1/3] Create re-request-review reusable and use it in appropriate places --- .../about-pull-request-reviews.md | 4 ++++ .../incorporating-feedback-in-your-pull-request.md | 4 ++++ data/reusables/pull_requests/re-request-review.md | 2 ++ 3 files changed, 10 insertions(+) create mode 100644 data/reusables/pull_requests/re-request-review.md diff --git a/content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md b/content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md index 426a98eba6cc..460598c39727 100644 --- a/content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md +++ b/content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md @@ -49,6 +49,10 @@ For more information, see "[About required reviews for pull requests](/articles/ {% endtip %} +### Re-requesting a review + +{% data reusables.pull_requests.re-request-review %} + ### Further reading - "[Reviewing proposed changes in a pull request](/articles/reviewing-proposed-changes-in-a-pull-request)" diff --git a/content/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request.md b/content/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request.md index 421cb8250643..0dea29a8dd99 100644 --- a/content/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request.md +++ b/content/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request.md @@ -28,6 +28,10 @@ Each person who suggested a change included in the commit will be a co-author of 5. Click **Commit changes.** ![Commit changes button](/assets/images/help/pull_requests/commit-changes-button.png) +### Re-requesting a review + +{% data reusables.pull_requests.re-request-review %} + ### Opening an issue for an out-of-scope suggestion If someone suggests changes to your pull request and the changes are out of the pull request's scope, you can open a new issue to track the feedback. For more information, see "[Opening an issue from a comment](/github/managing-your-work-on-github/opening-an-issue-from-a-comment)." diff --git a/data/reusables/pull_requests/re-request-review.md b/data/reusables/pull_requests/re-request-review.md new file mode 100644 index 000000000000..7acf6d382d07 --- /dev/null +++ b/data/reusables/pull_requests/re-request-review.md @@ -0,0 +1,2 @@ +You can re-request a review after you've made substantial changes to your pull request. +Navigate to your pull request, in the right sidebar click on the {% octicon "sync" aria-label="The sync icon" %} icon to re-request a review. From 4053a2cd0a19ee6ec68571595e63a2609de3896e Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Tue, 3 Nov 2020 21:09:51 +0100 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Felicity Chapman --- data/reusables/pull_requests/re-request-review.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/reusables/pull_requests/re-request-review.md b/data/reusables/pull_requests/re-request-review.md index 7acf6d382d07..5776451f772f 100644 --- a/data/reusables/pull_requests/re-request-review.md +++ b/data/reusables/pull_requests/re-request-review.md @@ -1,2 +1,2 @@ -You can re-request a review after you've made substantial changes to your pull request. -Navigate to your pull request, in the right sidebar click on the {% octicon "sync" aria-label="The sync icon" %} icon to re-request a review. +You can re-request a review, for example, after you've made substantial changes to your pull request. +To request a fresh review from a reviewer, in the sidebar of the **Conversation** tab, click the {% octicon "sync" aria-label="The sync icon" %} icon. From 5430cb51ad8ae01d4521aca664da0b0a419fa9fb Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Tue, 3 Nov 2020 21:14:59 +0100 Subject: [PATCH 3/3] move heading and reusable up to line 41 --- .../about-pull-request-reviews.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md b/content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md index 326cea9d0f98..fd7f06c5b619 100644 --- a/content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md +++ b/content/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md @@ -38,6 +38,10 @@ You can view all of the reviews a pull request has received in the Conversation {% data reusables.pull_requests.resolving-conversations %} +### Re-requesting a review + +{% data reusables.pull_requests.re-request-review %} + ### Required reviews {% data reusables.pull_requests.required-reviews-for-prs-summary %} @@ -50,10 +54,6 @@ For more information, see "[About required reviews for pull requests](/articles/ {% endtip %} -### Re-requesting a review - -{% data reusables.pull_requests.re-request-review %} - ### Further reading - "[Reviewing proposed changes in a pull request](/articles/reviewing-proposed-changes-in-a-pull-request)"