jsweep: clean add_reaction.cjs (#18041)

- Add block scopes {} to all switch cases for clarity and to prevent variable leakage
- Rename getDiscussionId to getDiscussionNodeId for consistency with add_workflow_run_comment.cjs
- Simplify getDiscussionNodeId to return string (node ID only) instead of object with unused url field
- All 27 existing tests pass

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>

Author: 4 people

actions/setup/js/add_reaction.cjs

@@ -31,25 +31,27 @@ async function main() {
 
   try {
     switch (eventName) {
-      case "issues":
+      case "issues": {
         const issueNumber = context.payload?.issue?.number;
         if (!issueNumber) {
           core.setFailed(`${ERR_NOT_FOUND}: Issue number not found in event payload`);
           return;
         }
         reactionEndpoint = `/repos/${owner}/${repo}/issues/${issueNumber}/reactions`;
         break;
+      }
 
-      case "issue_comment":
+      case "issue_comment": {
         const commentId = context.payload?.comment?.id;
         if (!commentId) {
           core.setFailed(`${ERR_VALIDATION}: Comment ID not found in event payload`);
           return;
         }
         reactionEndpoint = `/repos/${owner}/${repo}/issues/comments/${commentId}/reactions`;
         break;
+      }
 
-      case "pull_request":
+      case "pull_request": {
         const prNumber = context.payload?.pull_request?.number;
         if (!prNumber) {
           core.setFailed(`${ERR_NOT_FOUND}: Pull request number not found in event payload`);
@@ -58,35 +60,39 @@ async function main() {
         // PRs are "issues" for the reactions endpoint
         reactionEndpoint = `/repos/${owner}/${repo}/issues/${prNumber}/reactions`;
         break;
+      }
 
-      case "pull_request_review_comment":
+      case "pull_request_review_comment": {
         const reviewCommentId = context.payload?.comment?.id;
         if (!reviewCommentId) {
           core.setFailed(`${ERR_VALIDATION}: Review comment ID not found in event payload`);
           return;
         }
         reactionEndpoint = `/repos/${owner}/${repo}/pulls/comments/${reviewCommentId}/reactions`;
         break;
+      }
 
-      case "discussion":
+      case "discussion": {
         const discussionNumber = context.payload?.discussion?.number;
         if (!discussionNumber) {
           core.setFailed(`${ERR_NOT_FOUND}: Discussion number not found in event payload`);
           return;
         }
         // Discussions use GraphQL API - get the node ID
-        const discussion = await getDiscussionId(owner, repo, discussionNumber);
-        await addDiscussionReaction(discussion.id, reaction);
+        const discussionNodeId = await getDiscussionNodeId(owner, repo, discussionNumber);
+        await addDiscussionReaction(discussionNodeId, reaction);
         return; // Early return for discussion events
+      }
 
-      case "discussion_comment":
+      case "discussion_comment": {
         const commentNodeId = context.payload?.comment?.node_id;
         if (!commentNodeId) {
           core.setFailed(`${ERR_NOT_FOUND}: Discussion comment node ID not found in event payload`);
           return;
         }
         await addDiscussionReaction(commentNodeId, reaction);
         return; // Early return for discussion comment events
+      }
 
       default:
         core.setFailed(`${ERR_VALIDATION}: Unsupported event type: ${eventName}`);
@@ -181,16 +187,15 @@ async function addDiscussionReaction(subjectId, reaction) {
  * @param {string} owner - Repository owner
  * @param {string} repo - Repository name
  * @param {number} discussionNumber - Discussion number
- * @returns {Promise<{id: string, url: string}>} Discussion details
+ * @returns {Promise<string>} Discussion node ID
  */
-async function getDiscussionId(owner, repo, discussionNumber) {
+async function getDiscussionNodeId(owner, repo, discussionNumber) {
   const { repository } = await github.graphql(
     `
     query($owner: String!, $repo: String!, $num: Int!) {
       repository(owner: $owner, name: $repo) {
         discussion(number: $num) { 
           id 
-          url
         }
       }
     }`,
@@ -201,10 +206,7 @@ async function getDiscussionId(owner, repo, discussionNumber) {
     throw new Error(`${ERR_NOT_FOUND}: Discussion #${discussionNumber} not found in ${owner}/${repo}`);
   }
 
-  return {
-    id: repository.discussion.id,
-    url: repository.discussion.url,
-  };
+  return repository.discussion.id;
 }
 
 module.exports = { main };