Repository Quality Report: Gemini Engine Feature Parity (2026-03-19)

[github-actions[bot]]

🎯 Repository Quality Improvement Report — Gemini Engine Feature Parity

Analysis Date: 2026-03-19
Focus Area: Gemini Engine Feature Parity
Strategy Type: Custom
Custom Area: Yes — Gemini is a recently-added engine (pkg/workflow/gemini_engine.go) with dedicated infrastructure, but several engine-dispatch switch statements in the compiler were not updated to include it, causing silent fallback to wrong defaults.

---

Executive Summary

The Gemini engine has excellent dedicated infrastructure: its own engine type (GeminiEngine), log parser, tool configuration, and domain allowlists. However, three compiler-level switch statements that route per-engine behaviour still lack a case "gemini" branch, causing:

1. Default engine version returned as "" instead of "latest" — getDefaultEngineVersion() in compiler_yaml_helpers.go
2. Wrong model env-var selected — GH_AW_MODEL_AGENT_CUSTOM used instead of GH_AW_MODEL_AGENT_GEMINI when generating the agent job in compiler_yaml.go
3. Plugin install command falls to generic format — no explicit case "gemini" in plugin_installation.go

These are low-risk bugs today (the fallbacks are mostly harmless) but they will silently produce incorrect compiled workflow YAML for Gemini users. All fixes are small, surgical changes adding a single case line each.

Test/source ratio: 311 801 test LOC / 137 022 source LOC = 227 % — excellent overall coverage.
TODO count (non-test Go): only 9 items, two of which are in plugin_installation.go and are directly related to this analysis.

---

Full Analysis Report

Focus Area: Gemini Engine Feature Parity

Current State Assessment

Metric	Value	Status
Engines in AgenticEngines	copilot, claude, codex, gemini	✅
DefaultGeminiVersion defined	"latest" in constants.go	✅
EnvVarModelAgentGemini defined	GH_AW_MODEL_AGENT_GEMINI in constants.go	✅
GeminiEngine struct	pkg/workflow/gemini_engine.go	✅
domains.go Gemini case	✅ Handled	✅
compiler_yaml_helpers.go version dispatch	❌ Missing case "gemini"	❌
compiler_yaml.go model env-var dispatch	❌ Missing case "gemini"	❌
plugin_installation.go install command	❌ Missing case "gemini"	❌

Findings

Strengths

• Gemini has a full engine implementation: gemini_engine.go, gemini_logs.go, gemini_tools.go
• domains.go correctly handles case "gemini" for network allowlist generation
• All required constants are pre-defined (DefaultGeminiVersion, EnvVarModelAgentGemini, GeminiCLIModelEnvVar)
• Only 9 TODO comments across 600 non-test Go files — very clean codebase

Areas for Improvement

• [HIGH] compiler_yaml_helpers.go L161-172: getDefaultEngineVersion() returns "" for gemini instead of string(constants.DefaultGeminiVersion). This means compiled Gemini workflows pin no version (could use wrong or latest unpinned binary).
• [HIGH] compiler_yaml.go L556-567: Model env-var dispatch uses EnvVarModelAgentCustom (GH_AW_MODEL_AGENT_CUSTOM) for gemini instead of EnvVarModelAgentGemini (GH_AW_MODEL_AGENT_GEMINI). Users configuring GH_AW_MODEL_AGENT_GEMINI won't see it applied.
• [MEDIUM] plugin_installation.go L66-74: No explicit gemini case — currently falls to generic gemini plugin install (name) which may or may not be the correct CLI syntax. The TODO comments for claude and codex indicate all three non-copilot commands need verification.
• [LOW] No tests cover the engine-specific paths in these three functions for the gemini engine ID.

Detailed Analysis

getDefaultEngineVersion in compiler_yaml_helpers.go:

switch engineID {
case "copilot":
    return string(constants.DefaultCopilotVersion)
case "claude":
    return string(constants.DefaultClaudeCodeVersion)
case "codex":
    return string(constants.DefaultCodexVersion)
// gemini falls to default → returns ""
default:
    compilerYamlHelpersLog.Printf("No default version for custom engine: %s", engineID)
    return ""
}

Model env-var dispatch in compiler_yaml.go:

switch engineID {
case "copilot": modelEnvVar = constants.EnvVarModelAgentCopilot
case "claude":  modelEnvVar = constants.EnvVarModelAgentClaude
case "codex":   modelEnvVar = constants.EnvVarModelAgentCodex
case "custom":  modelEnvVar = constants.EnvVarModelAgentCustom
// gemini falls to default → uses EnvVarModelAgentCustom
default:        modelEnvVar = constants.EnvVarModelAgentCustom
}

Plugin install in plugin_installation.go:

case "copilot":
    command = "copilot plugin install " + plugin
case "claude":
    // TODO: validate the correct claude CLI plugin install command syntax
    command = "claude plugin install " + plugin
case "codex":
    // TODO: validate the correct codex CLI plugin install command syntax
    command = "codex plugin install " + plugin
// no gemini case → falls to generic: "gemini plugin install (name)"
default:
    command = fmt.Sprintf("%s plugin install %s", engineID, plugin)

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: The following tasks target three small, specific code regions. Each is independently actionable by the Copilot coding agent.

---

Task 1: Add Gemini case to getDefaultEngineVersion

Priority: High
Estimated Effort: Small
Focus Area: Gemini Engine Feature Parity

Description:
getDefaultEngineVersion() in pkg/workflow/compiler_yaml_helpers.go has a switch statement for copilot, claude, and codex but is missing gemini. It should return string(constants.DefaultGeminiVersion) for the gemini engine, just like the other engines return their respective default versions.

Acceptance Criteria:

• case "gemini": return string(constants.DefaultGeminiVersion) added to the switch in getDefaultEngineVersion
• make build passes
• make test-unit passes (or at minimum: go test -v -run "TestGetDefaultEngineVersion\|TestCompile.*[Gg]emini" ./pkg/workflow/)
• make fmt applied

Code Region: pkg/workflow/compiler_yaml_helpers.go lines ~161-172

In `pkg/workflow/compiler_yaml_helpers.go`, find the `getDefaultEngineVersion` function.
It has a switch statement that handles `"copilot"`, `"claude"`, and `"codex"` but is missing `"gemini"`.

Add a case for gemini immediately after the codex case:
```go
case "gemini":
    return string(constants.DefaultGeminiVersion)
```

This is a small, surgical change. After making it, run `make fmt` to format the file, then run `go test -v -run "TestGetDefaultEngineVersion" ./pkg/workflow/` to verify. If that test doesn't exist, run `make test-unit` to confirm nothing is broken.

---

Task 2: Add Gemini case to model env-var dispatch in compiler_yaml.go

Priority: High
Estimated Effort: Small
Focus Area: Gemini Engine Feature Parity

Description:
In pkg/workflow/compiler_yaml.go, the model environment variable switch (around line 556) routes each engine to its dedicated GH_AW_MODEL_AGENT_* env var. The "gemini" engine is missing and silently falls to EnvVarModelAgentCustom (GH_AW_MODEL_AGENT_CUSTOM). It should use constants.EnvVarModelAgentGemini (GH_AW_MODEL_AGENT_GEMINI).

Acceptance Criteria:

• case "gemini": modelEnvVar = constants.EnvVarModelAgentGemini added to the switch
• The compiled YAML for a Gemini workflow references GH_AW_MODEL_AGENT_GEMINI instead of GH_AW_MODEL_AGENT_CUSTOM
• make build and make fmt pass
• make test-unit passes

Code Region: pkg/workflow/compiler_yaml.go lines ~556-567

In `pkg/workflow/compiler_yaml.go`, find the switch statement that sets `modelEnvVar` based on `engineID` (look for `case "copilot": modelEnvVar = constants.EnvVarModelAgentCopilot`).

Add a case for gemini before the `case "custom"` line:
```go
case "gemini":
    modelEnvVar = constants.EnvVarModelAgentGemini
```

`constants.EnvVarModelAgentGemini` is already defined as `"GH_AW_MODEL_AGENT_GEMINI"` in `pkg/constants/constants.go` — no new constants needed.

After making the change, run `make fmt` then `make test-unit` to verify.

---

Task 3: Add explicit Gemini case to generatePluginInstallStep

Priority: Medium
Estimated Effort: Small
Focus Area: Gemini Engine Feature Parity

Description:
generatePluginInstallStep in pkg/workflow/plugin_installation.go handles copilot, claude, and codex, but Gemini falls to the generic default. Add an explicit case "gemini" with the best-known plugin install syntax for the Gemini CLI. Note that the file already has TODO comments for claude and codex indicating uncertainty about the exact syntax; the same should be documented for gemini until confirmed.

Acceptance Criteria:

• case "gemini" added with a TODO comment noting syntax needs verification
• The generic default is no longer used for the gemini engine
• make build and make fmt pass
• make test-unit passes

Code Region: pkg/workflow/plugin_installation.go lines ~66-74

In `pkg/workflow/plugin_installation.go`, in the `generatePluginInstallStep` function, find the switch on `engineID`.

Add a gemini case after the codex case:
```go
case "gemini":
    // TODO: validate the correct gemini CLI plugin install command syntax
    command = "gemini plugin install " + plugin
```

This mirrors the pattern already used for claude and codex which also have TODO verification notes. After making the change, run `make fmt` then `make test-unit`.

---

Task 4: Add unit tests for engine-specific paths (gemini)

Priority: Low
Estimated Effort: Medium
Focus Area: Gemini Engine Feature Parity

Description:
The three functions patched in Tasks 1-3 currently have no tests that exercise the "gemini" engine ID path. Add table-driven test cases covering getDefaultEngineVersion("gemini"), the model env-var dispatch for "gemini", and GeneratePluginInstallationSteps with engine "gemini".

Acceptance Criteria:

• Test cases for "gemini" added alongside existing engine test cases in the relevant *_test.go files
• All new test cases pass: go test -v -run ".*[Gg]emini.*\|.*[Ee]ngine.*" ./pkg/workflow/
• Build tags (//go:build !integration) present at top of any new/modified test file
• make lint passes (no unused helper functions)

Code Region: pkg/workflow/compiler_yaml_helpers_test.go, pkg/workflow/compiler_yaml_test.go, pkg/workflow/plugin_installation_test.go

In the workflow package test files, add table-driven test cases for the `"gemini"` engine ID to the existing engine-dispatch test functions. Specifically:

1. In the test for `getDefaultEngineVersion` (likely `compiler_yaml_helpers_test.go`): add `{engineID: "gemini", expected: "latest"}` to the test table.

2. In the test for the model env-var dispatch in `compiler_yaml.go`: add `{engineID: "gemini", expectedVar: "GH_AW_MODEL_AGENT_GEMINI"}`.

3. In `plugin_installation_test.go`: add a test case where `engineID = "gemini"` and verify the generated command contains `"gemini plugin install"`.

Follow the existing test patterns in those files. Ensure each test file has `//go:build !integration` at the very top. Run `make lint` after to catch any unused helpers.

---

📊 Historical Context

Previous Focus Areas

Date	Focus Area	Type	Custom	Key Outcomes
2026-03-19	Gemini Engine Feature Parity	Custom	Y	Found 3 switch/case gaps; 4 tasks generated

---

🎯 Recommendations

Immediate Actions (This Week)

1. Fix getDefaultEngineVersion for gemini (Task 1) — Priority: High, ~5 min
2. Fix model env-var dispatch for gemini (Task 2) — Priority: High, ~5 min

Short-term Actions (This Month)

1. Add explicit gemini plugin install case (Task 3) — Priority: Medium, ~10 min

Long-term Actions (This Quarter)

1. Add unit tests for gemini engine paths (Task 4) — Priority: Low, ~30 min
2. Establish a CI lint rule that ensures all AgenticEngines members have explicit cases in every engine switch — prevents future regressions as new engines are added

---

📈 Success Metrics

• Gemini compiled-workflow correctness: 0 engine-dispatch gaps → Target: 0 gaps
• Engine test coverage parity: gemini paths tested at same level as copilot/claude/codex
• TODO resolution rate: 2 existing plugin-install TODOs resolved with verified command syntax

---

Next Steps

1. Assign Tasks 1 & 2 to Copilot coding agent (high priority, small effort)
2. Assign Task 3 to Copilot coding agent (medium priority)
3. Schedule Task 4 for next quality sprint
4. Re-evaluate after fixes are merged — next focus area will be selected by diversity algorithm

---

References:

• §23297265883

Generated by Repository Quality Improvement Agent
Next analysis: 2026-03-20 — Focus area will be selected based on diversity algorithm (60% custom, 30% standard, 10% reuse)

AI generated by Repository Quality Improvement Agent · history

• expires on Mar 20, 2026, 1:36 PM UTC

[github-actions[bot]]

This discussion has been marked as outdated by Repository Quality Improvement Agent.

A newer discussion is available at Discussion #21966.