Safe Output Health Report - 2026-03-22 #22230
Closed
Replies: 2 comments 1 reply
-
|
/plan |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
This discussion has been marked as outdated by Safe Output Health Monitor. A newer discussion is available at Discussion #22376. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Executive Summary
All failures were isolated to smoke test workflows. No production or user-triggered workflow safe output jobs failed.
Safe Output Job Statistics
push_to_pull_request_branchadd_commentError Clusters
Cluster 1: push_to_pull_request_branch — Target Branch Missing (EP022 NEW)
safe_outputs→push_to_pull_request_branchhandleradd_commentwas automatically cancelled (1 additional message lost)Error message:
Root Cause: The agent produced
add_commentwithtarget=triggeringafter creating a PR, but the workflow was triggered byworkflow_dispatch(not from within an issue or PR). The handler correctly refuses to comment on a non-existent triggering context, but marks the message as failed rather than gracefully skipping it.Historical Pattern: This error recurs specifically for Smoke Multi PR and Agent Container Smoke Test workflows on
workflow_dispatch/scheduletriggers. Previous occurrences: 2026-02-25 (2x), 2026-03-16 (2x), 2026-03-20 (2x), 2026-03-21 (1x), 2026-03-22 (1x). The Smoke Multi PR itself succeeded — PRs #22219 and #22220 were created successfully.Root Cause Analysis
Code Push Failures
The
push_to_pull_request_branchhandler requires an existing remote branch to fetch before pushing. When the target branch is deleted (e.g., after a merged or closed PR), the git fetch fails immediately with exit code 128. The handler has no pre-flight check to verify branch existence before attempting the fetch.This is a smoke test infrastructure issue — the side-repo PR branch needs to be maintained/recreated between smoke test runs.
Context Mismatch for add_comment
The
add_commenthandler'starget=triggeringmode is valid only for issue/PR-triggered runs. The Smoke Multi PR workflow is designed to run both onpushevents and onworkflow_dispatch. When the agent producesadd_commentfor a dispatch-triggered run, there is no triggering entity. The agent prompt does not have enough context awareness to distinguish between these trigger types.Recommendations
Immediate Actions
Recreate
pr-branchingithubnext/gh-aw-side-repo(Critical)pr-branchin the side-repo, or update the smoke test to dynamically create/reset the branchInvestigate EP006 recurrence pattern (Medium)
add_commenton dispatch runs, or the agent prompt should explicitly state: "Do not useadd_commentwithtarget=triggeringwhen triggered byworkflow_dispatch"Bug Fixes Required
EP022: Add branch existence pre-flight to
push_to_pull_request_branchgit fetch, verify the branch exists via GitHub API (GET /repos/{owner}/{repo}/git/ref/heads/{branch})EP006: Improve context-awareness in agent prompts for schedule/dispatch workflows
add_commentafter creating a PR, reference the newly-created PR number (e.g.,item_number: created_pr_number) instead oftarget=triggeringWork Item Plans
Work Item 1: Fix Smoke Update Cross-Repo PR side-repo branch (Critical)
pr-branchbranch ingithubnext/gh-aw-side-repois missing, causing all Smoke Update Cross-Repo PR runs to fail with git exit code 128. This blocks validation of push-to-PR-branch functionality.pr-branchexists ingithubnext/gh-aw-side-repowith an open PR targeting mainWork Item 2: Fix EP006 — Smoke Multi PR add_comment context handling (Medium)
add_commentwithtarget=triggeringafter creating a PR, but the workflow is triggered viaworkflow_dispatchwhich has no triggering issue/PR context. This causes an error every time.item_number: created_pr_number(referencing the just-created PR) instead oftarget=triggering. Alternatively, add a handler-level grace foradd_commentfailures on dispatch runs.Historical Context
7-Day Trend
Trend: Safe output health is stable with 2-4 failures per day in smoke test workflows. Today's failures are both limited to smoke testing infrastructure — no production workflows affected. EP006 (add_comment context mismatch) is the most persistent recurring pattern (8+ occurrences across 6 days).
Metrics and KPIs
push_to_pull_request_branch(EP022),add_commentcontext mode (EP006)Next Steps
pr-branchingithubnext/gh-aw-side-repo(critical — blocks Smoke Update Cross-Repo PR)item_numberinstead oftarget=triggeringpush_to_pull_request_branchhandlerReferences:
Beta Was this translation helpful? Give feedback.
All reactions