[developer-docs] Developer Documentation Consolidation - 2026-04-04

[github-actions[bot]]

Summary

Analyzed the latest commit (e255fc7) — "Add compiler check disallowing secrets expressions in custom steps (#24450)" — and documented the new Go implementation in scratchpad/dev.md (v5.1 → v5.2). No tone issues or formatting problems were found. No new spec files were added; the update covers a new Go feature.

Changes: 1 new subsection added · 0 tone fixes · 0 diagrams added · 72 spec files covered (unchanged)

Full Consolidation Report

Files Analyzed

File	Type	Changes Made
pkg/workflow/strict_mode_steps_validation.go	New Go implementation	Documented in Compiler Validation section

New Feature Documented

Secrets in Custom Steps Validation (PR #24450)

• Implementation: pkg/workflow/strict_mode_steps_validation.go — Compiler.validateStepsSecrets()
• Called from: pkg/workflow/compiler_orchestrator_engine.go (line 90)
• Purpose: Prevent user-defined secrets from leaking into the agent job via steps and post-steps frontmatter sections
• Strict mode: compilation error — lists all found secrets.* expressions
• Non-strict mode: warning + warning count incremented
• Exempt: $\{\{ secrets.GITHUB_TOKEN }} (built-in runner token)

The subsection was added to the Compiler Validation section of scratchpad/dev.md and includes behavior description, implementation reference, error message, and migration guidance.

Tone and Formatting Scan

• Marketing language: 0 instances found
• Formatting issues: 0 instances found
• Missing diagrams: 0 instances found

Consolidation Statistics

• Files processed: 1 Go implementation file
• Spec files covered: 72 (unchanged)
• Tone adjustments: 0
• Diagrams added: 0
• Sections added: 1 (Secrets in Custom Steps Validation)

Validation Results

✅ Markdown is valid
✅ Code blocks have language tags
✅ Consistent technical tone throughout
✅ Logical structure maintained
✅ No broken links

Historical Comparison

• Previous run: 2026-04-03 (v5.1)
• Issues then: 0
• Issues now: 0

Recommendations

Review the new subsection in scratchpad/dev.md under Validation Architecture → Secrets in Custom Steps Validation for accuracy against the implementation in pkg/workflow/strict_mode_steps_validation.go.

References:

• Workflow Run §23977549181

Generated by Developer Documentation Consolidator · ● 536.7K · ◷

• expires on Apr 7, 2026, 11:11 AM UTC

[github-actions[bot]]

This discussion has been marked as outdated by Developer Documentation Consolidator.

A newer discussion is available at Discussion #24710.