[daily-compiler-quality] Code Quality Audit: compiler.go, compiler_jobs.go, compiler_yaml.go

[github-actions[bot]]

Overview

Automated quality analysis of the three primary workflow compiler files at commit f2bfc73. All scores are out of 100 across 5 dimensions.

---

Scores at a Glance

File	Lines	Functions	Structure	Readability	Error Handling	Testing	Patterns	Total
compiler.go	780	6	16/25	12/20	16/20	19/20	14/15	77
compiler_jobs.go	836	19	15/25	12/20	18/20	17/20	12/15	74
compiler_yaml.go	915	17	15/25	13/20	14/20	19/20	13/15	74

All three files rate Good (70–79 range).

---

Function Size Violations (50-line guideline)

Function	File	Lines	Severity
validateWorkflowData	compiler.go	L77–425, 348 lines	🔴 Critical
buildCustomJobs	compiler_jobs.go	L475–809, 334 lines	🔴 Critical
generatePrompt	compiler_yaml.go	L396–627, 231 lines	🔴 Critical
generateWorkflowHeader	compiler_yaml.go	L83–254, 171 lines	🟠 High
generateCreateAwInfo	compiler_yaml.go	L674–818, 144 lines	🟠 High
generateAndValidateYAML	compiler.go	L429–557, 128 lines	🟡 Medium
CompileWorkflowData	compiler.go	L638–751, 113 lines	🟡 Medium

---

Key Findings per File

compiler.go — Score: 77/100

Strengths:

• Both exported functions have comprehensive multi-paragraph doc blocks with compilation pipeline descriptions
• formatCompilerError() wrapper provides structured, IDE-navigable error messages
• Three-tier manifest priority (pre-cached → HEAD commit → filesystem) defends against agent-tampered lock files
• Modern Go idioms: any, slices.Contains, defer for timing

Issues:

1. validateWorkflowData (348 lines) is a God Method — 22 sequential validator calls in a single flat function
2. Stale orphaned stub comments at L753–780 reference functions moved to other files
3. Bare return err at L143, L303 bypasses formatCompilerError, surfaces unformatted errors
4. Duplicate .invalid.yml write logic in 3 separate error branches in generateAndValidateYAML

Top recommendation: Create a ValidationPipeline with []ValidationStep — each step under 50 lines, independently testable.

---

compiler_jobs.go — Score: 74/100

Strengths:

• Exemplary error wrapping: 30 fmt.Errorf calls, all using %w with rich context
• Clean hierarchical job construction order with structured debug logging
• ensureConclusionIsLastJob is a correct, well-designed topological safety net

Issues:

1. buildCustomJobs (334 lines) is a single loop extracting 12+ job properties with ~80 lines of near-identical marshal+indent code
2. isActivationJobNeeded always returns true — dead code that misleads callers
3. No file-level documentation comment
4. Bare return err at L759 provides no context about which job/secret triggered the error

Top recommendation: Extract extractCustomJobConfig(jobName, configMap) (*Job, error) and a marshalIndentedYAML(value, indent, prefix) helper to eliminate the repetitive marshal patterns.

---

compiler_yaml.go — Score: 74/100

Strengths:

• Extensive inline comments explaining non-obvious design decisions (runtime-import rationale, expression filtering strategy, path resolution)
• Performance-aware: pre-allocated 64KB strings.Builder, single-pass body-before-header to collect secrets
• ANSI escape stripping applied uniformly to prevent YAML corruption

Issues:

1. File exceeds 915 lines (project hard limit: 900)
2. generatePrompt (231 lines) handles 6 distinct concerns — import inlining, runtime-import macros, expression extraction, merging, known-needs augmentation, step emission
3. Ignored error at L735: b, _ := json.Marshal(allowedDomains) silently produces [] on failure
4. 6 functions lack doc comments: generateYAML, generatePrompt, generatePreSteps, generatePostSteps, generatePreAgentSteps, generateCreateAwInfo, generateOutputCollectionStep

Top recommendation: Split generatePrompt into collectPromptSources(), extractPromptExpressions(), and emitPromptSteps().

---

Cross-Cutting Strengths

• ✅ Zero use of deprecated interface{} — all files use any consistently
• ✅ 54+ companion test files covering unit, integration, benchmarks, and golden-file tests
• ✅ Structured debug logging with namespace conventions enabling per-component tracing
• ✅ No goroutines used inappropriately — all compilation is synchronous

Cross-Cutting Issues

• ❌ No file has a package-level documentation comment explaining its role
• ❌ Mixed error propagation: some paths use formatCompilerError(), others use bare return err
• ❌ Repetitive map[string]any type assertion pattern appears ~30+ times in compiler_jobs.go without a helper

---

Priority Refactoring Targets

1. Split validateWorkflowData into grouped sub-validators: validatePermissionsConfig, validateSafeOutputsConfig, validateConcurrencyConfig, validateNetworkConfig, validateToolsConfig
2. Refactor buildCustomJobs: extract extractCustomJobConfig() + marshalIndentedYAML() helper
3. Split generatePrompt into 3 focused functions (<50 lines each)
4. Fix ignored error at compiler_yaml.go:735
5. Remove dead code: isActivationJobNeeded always returns true
6. Delete orphaned stub comments at compiler.go:753–780

Generated by Daily Compiler Quality Check · ● 5.4M · ◷

• expires on Apr 17, 2026, 9:50 PM UTC

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-04-17T21:50:29.265Z.

Closed by Workflow