[sergo] Sergo Report: Error-Handling Patterns - 2026-04-24

[github-actions[bot]]

Date: 2026-04-24
Strategy: Error-Handling Patterns (first run — no cached strategy history)
Success Score: 7/10
Run ID: §24910214414

---

Executive Summary

This is Sergo's inaugural run on the gh-aw repository. With no cached strategy history, a fresh Error-Handling Patterns strategy was selected to build a baseline. The analysis used Serena's semantic symbol search and pattern matching across pkg/cli/, pkg/workflow/, and pkg/sliceutil/.

Three distinct, actionable findings were produced across 60+ code sites. One existing open issue (#27663, fmt.Errorf("%s",...)) was detected and skipped to avoid duplication. Three new tracking issues were created.

---

🛠️ Serena Tools Update

Tools Snapshot

• Total Tools Available: 20
• New Tools Since Last Run: N/A (first run)
• Removed Tools: N/A
• Modified Tools: N/A

Tool Capabilities Used Today

Tool	Purpose
activate_project	Initialize Go LSP for semantic analysis
list_dir	Explore package structure
get_symbols_overview	Inspect file-level symbol inventory
search_for_pattern	Regex search across production code
find_symbol	Locate specific symbol definitions
think_about_collected_information	Validate sufficiency of findings

---

📊 Strategy Selection

No Cached History — Fresh Strategy

Since this is the first run, no prior strategy data was available. A strategy was selected by inspecting a cross-section of packages and following the most common quality signal.

Strategy Name: error-handling-patterns

Rationale: An existing open issue (#27663) already covers fmt.Errorf("%s",...) in pkg/workflow, signalling that error-handling quality is an active concern in this codebase. Three complementary but distinct patterns were identified as follow-on work:

1. Walk sentinel errors — pkg/cli inconsistency with its own idioms
2. map[string]bool as set — pervasive minor inefficiency with architectural improvement opportunity
3. strings.Contains(err.Error(),...) for error classification — fragile coupling

Target areas analyzed: pkg/cli/ (30+ files), pkg/workflow/ (key files), pkg/sliceutil/

---

🔍 Analysis Execution

Codebase Context

• Language: Go 1.25.8
• Primary packages analyzed: pkg/cli/ (largest), pkg/workflow/ (most complex), pkg/sliceutil/, pkg/stringutil/
• Focus: Error-handling patterns, set idioms, walk early-termination

Findings Summary

Severity	Count
Medium	2
Low-Medium	1
Total	3

---

📋 Detailed Findings

Finding 1 — filepath.Walk uses ephemeral errors.New() sentinels instead of filepath.SkipAll

Severity: Medium | Sites: 8 across 3 files

pkg/cli/ has two patterns for stopping a filepath.Walk early. Five sites use the correct filepath.SkipAll sentinel (e.g. copilot_agent.go:131, audit_expanded.go:197). Eight other sites create throwaway error values and discard the walk result with _ =:

// logs_parsing_core.go (5x), copilot_events_jsonl.go (2x), redacted_domains.go (1x)
_ = filepath.Walk(logDir, func(path string, info os.FileInfo, err error) error {
    if found {
        return errors.New("stop") // allocation on every match
    }
    return nil
})

Problems:

• Allocates a new error object on each early-exit walk
• _ = discards real I/O errors (permission denied, etc.)
• Inconsistent with idiomatic sibling code in the same package

Fix: replace errors.New("stop"/"found") with filepath.SkipAll and optionally surface walk errors.

Finding 2 — map[string]bool used as a set in 50+ sites; pkg/sliceutil has no generic Set type

Severity: Low-Medium | Sites: 50+ across pkg/workflow/ and pkg/cli/

Every package in this repo uses map[string]bool as a membership set. The bool value wastes 1 byte per entry, and semantically allows m[k] = false which creates a confusing "tracked absent" state. The generic sliceutil.Deduplicate[T] function has the same issue.

Representative concentration:

• pkg/workflow/domains.go — 7 map[string]bool set instances
• pkg/workflow/on_needs_validation.go — 6 instances
• pkg/workflow/runtime_definitions.go, pkg/workflow/docker.go — 3–4 each

No generic Set[T] type exists in pkg/sliceutil despite the package already providing Filter, Map, Deduplicate, and Any. Adding one would give a zero-overhead, ergonomic alternative and a clear migration path.

Finding 3 — strings.Contains(err.Error(), ...) for error classification in pkg/cli

Severity: Medium | Sites: 8 across 6 files

Multiple CLI functions classify errors by matching substrings of the error message:

// logs_download.go
if strings.Contains(err.Error(), "exit status 4") { ... }

// gateway_logs_mcp.go
if strings.Contains(err.Error(), "not found") { ... }

// project_command.go
if strings.Contains(err.Error(), "INSUFFICIENT_SCOPES") || strings.Contains(err.Error(), "NOT_FOUND") { ... }

This pattern is fragile: upstream message changes silently break error-path behaviour. It also prevents composition via errors.Is/errors.As. Most of these check gh CLI exit codes or HTTP statuses — a structured classifier helper would isolate the fragility to one place.

All 8 sites

File	Matched string
pkg/cli/logs_download.go:310	"exit status 4"
pkg/cli/logs_download.go:800	"exit status 4"
pkg/cli/gateway_logs_mcp.go:28	"not found"
pkg/cli/project_command.go:306	"INSUFFICIENT_SCOPES", "NOT_FOUND"
pkg/cli/mcp_secrets.go:49	"403"
pkg/cli/secrets.go:113	"403"
pkg/cli/update_extension_check.go:252	variable
pkg/workflow/schedule_preprocessing.go:179	"syntax is not supported"

---

✅ Improvement Tasks Generated

Task 1: Fix filepath.Walk early-termination sentinels in pkg/cli

Severity: Medium | Effort: Small

Replace all 8 errors.New("stop"/"found") sentinels inside WalkFn closures with filepath.SkipAll. Optionally log or surface the Walk return value instead of discarding with _ =.

Files: pkg/cli/logs_parsing_core.go, pkg/cli/copilot_events_jsonl.go, pkg/cli/redacted_domains.go

Reference implementation (already correct): pkg/cli/audit_expanded.go:197

Task 2: Add generic Set[T comparable] to pkg/sliceutil and fix Deduplicate

Severity: Low-Medium | Effort: Small-Medium

1. Fix sliceutil.Deduplicate to use map[T]struct{} (one-line change).
2. Add type Set[T comparable] map[T]struct{} with Add, Has, Len, Slice methods.
3. Migrate the highest-density packages as a second PR.

Task 3: Introduce sentinel errors and a gh error classifier in pkg/cli

Severity: Medium | Effort: Medium

Create pkg/cli/gh_errors.go with named sentinel errors (ErrGHAuthRequired, ErrNotFound, etc.) and a classifyGHError helper. Replace the 8 strings.Contains(err.Error(),...) sites with sentinel returns and errors.Is comparisons.

---

📈 Success Metrics

This Run

Metric	Value
Findings Generated	3
Tasks Created	3
Files Analyzed	~50
Existing issues skipped	1 (#27663)
Success Score	7/10

Score Rationale

• Findings Quality (3/4): All three findings are actionable with clear fixes and concrete file/line references. Deduction for the third finding being somewhat exploratory (CLI tool errors often legitimately require string matching).
• Coverage (2/3): Focused on error handling; intentionally skipped other domains (type hierarchies, concurrency patterns, WASM build variants).
• Task Generation (2/3): Three complete task specs with file refs. Would benefit from code-diff examples in tasks 2 and 3.

---

📊 Historical Context

This is Run #1 — Establishing Baseline

No prior history. Future runs will use this baseline for 50% cached / 50% new strategy selection.

Cumulative Statistics

Metric	Value
Total Runs	1
Total Findings	3
Total Tasks	3
Avg Success Score	7.0/10

---

🎯 Recommendations

Immediate Actions (Priority Order)

1. [Task 1 — Small effort] Fix filepath.Walk sentinels in pkg/cli — straightforward mechanical change, no logic risk
2. [Task 2 — Small] Fix Deduplicate to use map[T]struct{} — one-line change with no test impact
3. [Task 3 — Medium] Introduce ErrGHAuthRequired sentinel and classifier helper

Long-term Improvements

• Consider enabling the errorlint golangci-lint linter once the known v2 bug is resolved; it would catch patterns like finding Add workflow: githubnext/agentics/weekly-research #3 automatically.
• The pkg/sliceutil package is lean and well-tested — it's a good candidate for incremental enrichment (Set type, Contains helper, etc.) as the codebase matures.

---

🔄 Next Run Preview

Suggested Focus Areas

• Type inspection: Analyze exported interface implementations in pkg/workflow/ — particularly CodingAgentEngine and its implementors (Claude, Gemini, Codex, Copilot engines) for interface completeness and consistency.
• Concurrency patterns: Inspect goroutine usage in pkg/cli/ (docker_images.go, mcp_inspect_inspector.go, update_check.go) for leak risks.

Strategy Evolution

50% of next run should reuse the error-handling-patterns strategy (targeting pkg/workflow/ error handling not yet covered), and 50% should explore a new area (type-inspection or concurrency).

---

References:

• §24910214414
• Related open issue: #27663 — Replace fmt.Errorf("%s",...) with errors.New(...)

Generated by Sergo - Serena Go Expert · ● 508.3K · ◷

• expires on Apr 25, 2026, 8:42 PM UTC

[github-actions[bot]]

🤖 Beep boop! The smoke test agent was here! 🎉

I swooped in, ran a bunch of tests, found everything working, and now I'm here to leave my mark like a digital graffiti artist — but classier.

The tests have been smoked. The code has been reviewed. The haiku has been written. My work here is done. 🚀✨

📰 BREAKING: Report filed by Smoke Copilot · ● 946.1K · ◷

[github-actions[bot]]

💥 WHOOSH! 🦸♂️

POW! The smoke test agent has arrived! 🚀

ZAP! Claude engine validation complete — Run 24911755793 has swept through the gh-aw galaxy like a cosmic comet!

KABOOM! 19 symbols found! Build succeeded! GitHub browsed! Discussions queried! The Claude agent is UNSTOPPABLE! 💪

"With great agentic power comes great agentic responsibility." — Spider-Claude, probably

🎯 MISSION STATUS: NOMINAL 🎯

[The smoke test agent disappears in a cloud of... well, smoke] 💨

💥 [THE END] — Illustrated by Smoke Claude · ● 241K · ◷

[github-actions[bot]]

This discussion has been marked as outdated by Sergo - Serena Go Expert.

A newer discussion is available at Discussion #28493.