From cabd7a9c5ca59b648866aebb616a3367ca38c7fb Mon Sep 17 00:00:00 2001 From: GitHub Copilot Date: Sun, 15 Feb 2026 19:00:10 +0000 Subject: [PATCH] refactor: Simplify locked resource error check logic Simplify the boolean expression for checking locked resource errors by removing redundant status code check. The condition (A && B) || (!A && B) is logically equivalent to just B. Changes: - Remove unused is403Error variable - Simplify conditional from 2 branches to 1 - Update comment to clarify behavior - Preserve all functionality (tests pass) Files: - actions/setup/js/add_reaction.cjs - actions/setup/js/add_reaction_and_edit_comment.cjs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- actions/setup/js/add_reaction.cjs | 6 ++---- actions/setup/js/add_reaction_and_edit_comment.cjs | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/actions/setup/js/add_reaction.cjs b/actions/setup/js/add_reaction.cjs index 42636da87cc..48526958de5 100644 --- a/actions/setup/js/add_reaction.cjs +++ b/actions/setup/js/add_reaction.cjs @@ -100,12 +100,10 @@ async function main() { // Check if the error is due to a locked issue/PR/discussion // GitHub API returns 403 with specific messages for locked resources - const is403Error = error && typeof error === "object" && "status" in error && error.status === 403; const hasLockedMessage = errorMessage && (errorMessage.includes("locked") || errorMessage.includes("Lock conversation")); - // Only ignore the error if it's a 403 AND mentions locked, or if the message mentions locked - if ((is403Error && hasLockedMessage) || (!is403Error && hasLockedMessage)) { - // Silently ignore locked resource errors - just log for debugging + // Silently ignore locked resource errors regardless of status code + if (hasLockedMessage) { core.info(`Cannot add reaction: resource is locked (this is expected and not an error)`); return; } diff --git a/actions/setup/js/add_reaction_and_edit_comment.cjs b/actions/setup/js/add_reaction_and_edit_comment.cjs index 7b7471ef3b2..be7977d6818 100644 --- a/actions/setup/js/add_reaction_and_edit_comment.cjs +++ b/actions/setup/js/add_reaction_and_edit_comment.cjs @@ -158,12 +158,10 @@ async function main() { // Check if the error is due to a locked issue/PR/discussion // GitHub API returns 403 with specific messages for locked resources - const is403Error = error && typeof error === "object" && "status" in error && error.status === 403; const hasLockedMessage = errorMessage && (errorMessage.includes("locked") || errorMessage.includes("Lock conversation")); - // Only ignore the error if it's a 403 AND mentions locked, or if the message mentions locked - if ((is403Error && hasLockedMessage) || (!is403Error && hasLockedMessage)) { - // Silently ignore locked resource errors - just log for debugging + // Silently ignore locked resource errors regardless of status code + if (hasLockedMessage) { core.info(`Cannot add reaction: resource is locked (this is expected and not an error)`); return; }