From c1580672ecd972522a2981a60ebb3e8de2616db8 Mon Sep 17 00:00:00 2001 From: GitHub Copilot <223556219+Copilot@users.noreply.github.com> Date: Tue, 17 Feb 2026 19:01:25 +0000 Subject: [PATCH] Simplify assign-to-agent JavaScript code Improve code clarity in recently modified assign-to-agent files: - Replace string concatenation with array.join() for cleaner template building - Use ES6 property shorthand for object literals (assignableId instead of assignableId: assignableId) These changes improve readability without altering functionality. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- actions/setup/js/assign_agent_helpers.cjs | 4 ++-- actions/setup/js/assign_to_agent.cjs | 17 ++++++++--------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/actions/setup/js/assign_agent_helpers.cjs b/actions/setup/js/assign_agent_helpers.cjs index 1530ad228e0..0dbab6b7f44 100644 --- a/actions/setup/js/assign_agent_helpers.cjs +++ b/actions/setup/js/assign_agent_helpers.cjs @@ -323,7 +323,7 @@ async function assignAgentToIssue(assignableId, agentId, currentAssignees, agent `; variables = { - assignableId: assignableId, + assignableId, actorIds, ...(pullRequestRepoId && { targetRepoId: pullRequestRepoId }), ...(model && { model }), @@ -343,7 +343,7 @@ async function assignAgentToIssue(assignableId, agentId, currentAssignees, agent } `; variables = { - assignableId: assignableId, + assignableId, actorIds, }; } diff --git a/actions/setup/js/assign_to_agent.cjs b/actions/setup/js/assign_to_agent.cjs index 40873de36ee..eddf8b7650e 100644 --- a/actions/setup/js/assign_to_agent.cjs +++ b/actions/setup/js/assign_to_agent.cjs @@ -40,24 +40,23 @@ async function main() { description: "The following agent assignments would be made if staged mode was disabled:", items: assignItems, renderItem: item => { - let content = ""; + const parts = []; if (item.issue_number) { - content += `**Issue:** #${item.issue_number}\n`; + parts.push(`**Issue:** #${item.issue_number}`); } else if (item.pull_number) { - content += `**Pull Request:** #${item.pull_number}\n`; + parts.push(`**Pull Request:** #${item.pull_number}`); } - content += `**Agent:** ${item.agent || previewDefaultAgent}\n`; + parts.push(`**Agent:** ${item.agent || previewDefaultAgent}`); if (previewDefaultModel) { - content += `**Model:** ${previewDefaultModel}\n`; + parts.push(`**Model:** ${previewDefaultModel}`); } if (previewDefaultCustomAgent) { - content += `**Custom Agent:** ${previewDefaultCustomAgent}\n`; + parts.push(`**Custom Agent:** ${previewDefaultCustomAgent}`); } if (previewDefaultCustomInstructions) { - content += `**Custom Instructions:** ${previewDefaultCustomInstructions}\n`; + parts.push(`**Custom Instructions:** ${previewDefaultCustomInstructions}`); } - content += "\n"; - return content; + return parts.join("\n") + "\n\n"; }, }); return;