From 1782198e07cb0c3738ba36cc5336694fae63e782 Mon Sep 17 00:00:00 2001 From: GitHub Copilot Date: Wed, 18 Feb 2026 19:03:07 +0000 Subject: [PATCH] simplify submit_pr_review target parsing for consistency - Remove redundant '&& targetStr != ""' check (setting Target to empty string is equivalent to not setting it; consistent with create_pr_review_comment.go) - Remove per-target debug log (not present in other similar parsers) - Move repo/repoParts declarations inside the else-if branch where they are used, narrowing scope and improving readability Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- actions/setup/js/submit_pr_review.cjs | 5 ++--- pkg/workflow/submit_pr_review.go | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/actions/setup/js/submit_pr_review.cjs b/actions/setup/js/submit_pr_review.cjs index a68bcaad68..c340d7a38f 100644 --- a/actions/setup/js/submit_pr_review.cjs +++ b/actions/setup/js/submit_pr_review.cjs @@ -88,9 +88,6 @@ async function main(config = {}) { // If create_pull_request_review_comment already set context, this is a no-op. // Use target config as single source of truth (same as add_comment): resolveTarget first, then use payload PR only when it matches. if (!buffer.getReviewContext()) { - const repo = `${context.repo.owner}/${context.repo.repo}`; - const repoParts = { owner: context.repo.owner, repo: context.repo.repo }; - const targetResult = resolveTarget({ targetConfig, item: message, @@ -106,6 +103,8 @@ async function main(config = {}) { } } else if (targetResult.number) { const prNum = targetResult.number; + const repo = `${context.repo.owner}/${context.repo.repo}`; + const repoParts = { owner: context.repo.owner, repo: context.repo.repo }; const payloadPR = context.payload?.pull_request; const usePayloadPR = payloadPR && payloadPR.number === prNum && payloadPR.head?.sha; diff --git a/pkg/workflow/submit_pr_review.go b/pkg/workflow/submit_pr_review.go index 8c8116a6d4..1754924074 100644 --- a/pkg/workflow/submit_pr_review.go +++ b/pkg/workflow/submit_pr_review.go @@ -34,9 +34,8 @@ func (c *Compiler) parseSubmitPullRequestReviewConfig(outputMap map[string]any) // Parse target (same semantics as add-comment / create-pull-request-review-comment) if target, exists := configMap["target"]; exists { - if targetStr, ok := target.(string); ok && targetStr != "" { + if targetStr, ok := target.(string); ok { config.Target = targetStr - submitPRReviewLog.Printf("Target: %s", config.Target) } }