From 33982d6044bd404e686729fda90431793283d592 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 1 Apr 2026 12:50:37 +0000 Subject: [PATCH 1/2] Initial plan From 72185d55f33419a01af1f3e5b5f40efab52915be Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 1 Apr 2026 13:17:46 +0000 Subject: [PATCH 2/2] fix: align qmd step names for consistency (#step-names) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Rename 'Start QMD MCP Server' → 'Start qmd MCP Server' - Rename 'Cache qmd models' → 'Save qmd models to cache' - Rename 'Restore qmd models cache' → 'Restore qmd models from cache' - Update related comments in mcp_environment.go and mcp_renderer_builtin.go - Recompile all 10 affected workflow lock files Agent-Logs-Url: https://github.com/github/gh-aw/sessions/54f8a088-7c7b-49a8-8ae1-18122f2706dc Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .github/workflows/daily-doc-healer.lock.yml | 6 +++--- .github/workflows/daily-doc-updater.lock.yml | 6 +++--- .github/workflows/dev.lock.yml | 6 +++--- .github/workflows/developer-docs-consolidator.lock.yml | 6 +++--- .github/workflows/dictation-prompt.lock.yml | 6 +++--- .github/workflows/glossary-maintainer.lock.yml | 6 +++--- .github/workflows/smoke-codex.lock.yml | 6 +++--- .github/workflows/technical-doc-writer.lock.yml | 6 +++--- .github/workflows/unbloat-docs.lock.yml | 6 +++--- .github/workflows/weekly-blog-post-writer.lock.yml | 6 +++--- pkg/workflow/mcp_environment.go | 4 ++-- pkg/workflow/mcp_renderer_builtin.go | 2 +- pkg/workflow/qmd.go | 8 ++++---- 13 files changed, 37 insertions(+), 37 deletions(-) diff --git a/.github/workflows/daily-doc-healer.lock.yml b/.github/workflows/daily-doc-healer.lock.yml index dc7e0912c24..e9d722cb005 100644 --- a/.github/workflows/daily-doc-healer.lock.yml +++ b/.github/workflows/daily-doc-healer.lock.yml @@ -383,7 +383,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -593,7 +593,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1311,7 +1311,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/.github/workflows/daily-doc-updater.lock.yml b/.github/workflows/daily-doc-updater.lock.yml index c7bd8b62644..58163ff6f4e 100644 --- a/.github/workflows/daily-doc-updater.lock.yml +++ b/.github/workflows/daily-doc-updater.lock.yml @@ -381,7 +381,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -555,7 +555,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1273,7 +1273,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/.github/workflows/dev.lock.yml b/.github/workflows/dev.lock.yml index b3e6d98278b..2f6e9599604 100644 --- a/.github/workflows/dev.lock.yml +++ b/.github/workflows/dev.lock.yml @@ -405,7 +405,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -578,7 +578,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1192,7 +1192,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/.github/workflows/developer-docs-consolidator.lock.yml b/.github/workflows/developer-docs-consolidator.lock.yml index fb8e5584bf4..08058ff0e42 100644 --- a/.github/workflows/developer-docs-consolidator.lock.yml +++ b/.github/workflows/developer-docs-consolidator.lock.yml @@ -441,7 +441,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -644,7 +644,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1398,7 +1398,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/.github/workflows/dictation-prompt.lock.yml b/.github/workflows/dictation-prompt.lock.yml index 9ef1039f01b..ccbb6a60b64 100644 --- a/.github/workflows/dictation-prompt.lock.yml +++ b/.github/workflows/dictation-prompt.lock.yml @@ -350,7 +350,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -526,7 +526,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1139,7 +1139,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/.github/workflows/glossary-maintainer.lock.yml b/.github/workflows/glossary-maintainer.lock.yml index 14b8d2b1d80..70317ebecde 100644 --- a/.github/workflows/glossary-maintainer.lock.yml +++ b/.github/workflows/glossary-maintainer.lock.yml @@ -448,7 +448,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -624,7 +624,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1291,7 +1291,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/.github/workflows/smoke-codex.lock.yml b/.github/workflows/smoke-codex.lock.yml index 3876ea52bc5..49443ac7c3b 100644 --- a/.github/workflows/smoke-codex.lock.yml +++ b/.github/workflows/smoke-codex.lock.yml @@ -486,7 +486,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -888,7 +888,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1671,7 +1671,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/.github/workflows/technical-doc-writer.lock.yml b/.github/workflows/technical-doc-writer.lock.yml index 961fadd2b4f..127059831af 100644 --- a/.github/workflows/technical-doc-writer.lock.yml +++ b/.github/workflows/technical-doc-writer.lock.yml @@ -436,7 +436,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -641,7 +641,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1297,7 +1297,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/.github/workflows/unbloat-docs.lock.yml b/.github/workflows/unbloat-docs.lock.yml index c132f398d2a..390d1ae24b6 100644 --- a/.github/workflows/unbloat-docs.lock.yml +++ b/.github/workflows/unbloat-docs.lock.yml @@ -456,7 +456,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -661,7 +661,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1471,7 +1471,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/.github/workflows/weekly-blog-post-writer.lock.yml b/.github/workflows/weekly-blog-post-writer.lock.yml index c933e88917b..fe1ef4db274 100644 --- a/.github/workflows/weekly-blog-post-writer.lock.yml +++ b/.github/workflows/weekly-blog-post-writer.lock.yml @@ -414,7 +414,7 @@ jobs: with: key: gh-aw-qmd-2.0.1-${{ github.run_id }} path: /tmp/gh-aw/qmd-index/ - - name: Restore qmd models cache + - name: Restore qmd models from cache uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ @@ -612,7 +612,7 @@ jobs: uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 with: node-version: "24" - - name: Start QMD MCP Server + - name: Start qmd MCP Server id: qmd-mcp-start env: INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite @@ -1266,7 +1266,7 @@ jobs: path: /tmp/gh-aw/qmd-index/ restore-keys: | gh-aw-qmd-2.0.1- - - name: Cache qmd models + - name: Save qmd models to cache uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4 with: path: ~/.cache/qmd/models/ diff --git a/pkg/workflow/mcp_environment.go b/pkg/workflow/mcp_environment.go index 731001e1c93..b2f50b75550 100644 --- a/pkg/workflow/mcp_environment.go +++ b/pkg/workflow/mcp_environment.go @@ -20,7 +20,7 @@ // - Safe Outputs: GH_AW_SAFE_OUTPUTS_*, GH_AW_ASSETS_* // - MCP Scripts: GH_AW_MCP_SCRIPTS_PORT, GH_AW_MCP_SCRIPTS_API_KEY // - Serena: removed (use shared/mcp/serena.md instead) -// - qmd: env vars are set directly in the "Start QMD MCP Server" Docker step (not via gateway) +// - qmd: env vars are set directly in the "Start qmd MCP Server" Docker step (not via gateway) // - Playwright: Secrets from custom args expressions // - HTTP MCP: Custom secrets from headers and env sections // @@ -127,7 +127,7 @@ func collectMCPEnvironmentVariables(tools map[string]any, mcpTools []string, wor // qmd env vars (INDEX_PATH, NODE_LLAMA_CPP_GPU) are no longer added to the gateway // environment. qmd now runs as a separate Docker container started by the - // "Start QMD MCP Server" step (see qmd.go:generateQmdStartStep), and the gateway + // "Start qmd MCP Server" step (see qmd.go:generateQmdStartStep), and the gateway // connects to it via HTTP. The env vars are set directly in that Docker start step. // Check for agentic-workflows GITHUB_TOKEN diff --git a/pkg/workflow/mcp_renderer_builtin.go b/pkg/workflow/mcp_renderer_builtin.go index 0d93f21e5d3..6376510647b 100644 --- a/pkg/workflow/mcp_renderer_builtin.go +++ b/pkg/workflow/mcp_renderer_builtin.go @@ -75,7 +75,7 @@ func (r *MCPConfigRendererUnified) renderPlaywrightTOML(yaml *strings.Builder, p // RenderQmdMCP generates the qmd documentation search MCP server configuration. // qmd runs natively on the host VM with HTTP transport, started by the -// "Start QMD MCP Server" step before the gateway, so the gateway connects via HTTP. +// "Start qmd MCP Server" step before the gateway, so the gateway connects via HTTP. // Using HTTP transport avoids node-llama-cpp's direct process.stdout writes (dot-progress // during model loading) from corrupting the stdio JSON-RPC stream. func (r *MCPConfigRendererUnified) RenderQmdMCP(yaml *strings.Builder, qmdTool any, workflowData *WorkflowData) { diff --git a/pkg/workflow/qmd.go b/pkg/workflow/qmd.go index c4b25029ef4..efe2d3dd7de 100644 --- a/pkg/workflow/qmd.go +++ b/pkg/workflow/qmd.go @@ -105,7 +105,7 @@ func qmdHasSources(qmdConfig *QmdToolConfig) bool { // // The two steps are: // 1. Setup Node.js – ensures node v24 is available before running npx. -// 2. Start QMD MCP Server – installs @tobilu/qmd via npx, starts the HTTP server as a +// 2. Start qmd MCP Server – installs @tobilu/qmd via npx, starts the HTTP server as a // background process, and polls /health (up to 120 s) before continuing. // // The gateway then connects to http://localhost:{port}/mcp. @@ -124,7 +124,7 @@ func generateQmdStartStep(qmdConfig *QmdToolConfig) string { fmt.Fprintf(&sb, " node-version: \"%s\"\n", string(constants.DefaultNodeVersion)) // Step 2: Start qmd natively - sb.WriteString(" - name: Start QMD MCP Server\n") + sb.WriteString(" - name: Start qmd MCP Server\n") sb.WriteString(" id: qmd-mcp-start\n") sb.WriteString(" env:\n") sb.WriteString(" INDEX_PATH: /tmp/gh-aw/qmd-index/index.sqlite\n") @@ -167,7 +167,7 @@ func generateQmdStartStep(qmdConfig *QmdToolConfig) string { func generateQmdModelsCacheStep() string { version := string(constants.DefaultQmdVersion) var sb strings.Builder - sb.WriteString(" - name: Cache qmd models\n") + sb.WriteString(" - name: Save qmd models to cache\n") fmt.Fprintf(&sb, " uses: %s\n", GetActionPin("actions/cache")) sb.WriteString(" with:\n") sb.WriteString(" path: ~/.cache/qmd/models/\n") @@ -199,7 +199,7 @@ func generateQmdNodeLlamaCppCacheStep() string { func generateQmdModelsCacheRestoreStep() string { version := string(constants.DefaultQmdVersion) var sb strings.Builder - sb.WriteString(" - name: Restore qmd models cache\n") + sb.WriteString(" - name: Restore qmd models from cache\n") fmt.Fprintf(&sb, " uses: %s\n", GetActionPin("actions/cache/restore")) sb.WriteString(" with:\n") sb.WriteString(" path: ~/.cache/qmd/models/\n")