From e35688161f888e86fbc017f4d33e84a4bf8c7c91 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 24 Apr 2026 12:09:14 +0000 Subject: [PATCH] chore: remove dead function extractEngineConfig The extractEngineConfig function was a thin wrapper around extractEngineConfigWithInferredEngine that was only called from test files. Tests now call extractEngineConfigWithInferredEngine directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- pkg/cli/audit_expanded.go | 5 ----- pkg/cli/audit_expanded_test.go | 6 +++--- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/pkg/cli/audit_expanded.go b/pkg/cli/audit_expanded.go index 7a6bd6301f..5f18552be7 100644 --- a/pkg/cli/audit_expanded.go +++ b/pkg/cli/audit_expanded.go @@ -112,11 +112,6 @@ func findAwInfoPath(logsPath string) string { return "" } -// extractEngineConfig parses aw_info.json and returns an AuditEngineConfig -func extractEngineConfig(logsPath string) *AuditEngineConfig { - return extractEngineConfigWithInferredEngine(logsPath, "") -} - func extractEngineConfigWithInferredEngine(logsPath, inferredEngineID string) *AuditEngineConfig { if logsPath == "" { return nil diff --git a/pkg/cli/audit_expanded_test.go b/pkg/cli/audit_expanded_test.go index 23f843fcb8..6fcfd495df 100644 --- a/pkg/cli/audit_expanded_test.go +++ b/pkg/cli/audit_expanded_test.go @@ -54,7 +54,7 @@ func TestExtractEngineConfig(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { if tt.expectNil && tt.awInfoContent == "" { - result := extractEngineConfig("") + result := extractEngineConfigWithInferredEngine("", "") assert.Nil(t, result, "Should return nil for empty logs path") return } @@ -69,7 +69,7 @@ func TestExtractEngineConfig(t *testing.T) { err := os.WriteFile(filepath.Join(targetDir, "aw_info.json"), []byte(tt.awInfoContent), 0644) require.NoError(t, err, "Should write aw_info.json") - result := extractEngineConfig(tmpDir) + result := extractEngineConfigWithInferredEngine(tmpDir, "") if tt.expectNil { assert.Nil(t, result, "Should return nil") return @@ -99,7 +99,7 @@ func TestExtractEngineConfigWithDetails(t *testing.T) { err := os.WriteFile(filepath.Join(tmpDir, "aw_info.json"), []byte(awInfoContent), 0644) require.NoError(t, err, "Should write aw_info.json") - result := extractEngineConfig(tmpDir) + result := extractEngineConfigWithInferredEngine(tmpDir, "") require.NotNil(t, result, "Engine config should not be nil") assert.Equal(t, "copilot", result.EngineID, "Engine ID should match") assert.Equal(t, "GitHub Copilot CLI", result.EngineName, "Engine name should match")