From 89ca6fc01ad653a5bba035f0574ccba9c75f1322 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 24 Apr 2026 05:56:57 +0000
Subject: [PATCH 1/2] feat: apply progressive disclosure to firewall alert
using details/summary
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/40375956-49f5-42ea-9461-0487043090ac
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
---
actions/setup/js/firewall_blocked_domains.cjs | 9 ++++++---
actions/setup/js/firewall_blocked_domains.test.cjs | 8 ++++++--
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/actions/setup/js/firewall_blocked_domains.cjs b/actions/setup/js/firewall_blocked_domains.cjs
index 69beb00f2ec..84c0b39393f 100644
--- a/actions/setup/js/firewall_blocked_domains.cjs
+++ b/actions/setup/js/firewall_blocked_domains.cjs
@@ -196,18 +196,19 @@ function generateBlockedDomainsSection(blockedDomains) {
const domainWord = domainCount === 1 ? "domain" : "domains";
let section = "\n\n> [!WARNING]\n";
- section += `> **⚠️ Firewall blocked ${domainCount} ${domainWord}**\n`;
+ section += `> \n`;
+ section += `> ⚠️ Firewall blocked ${domainCount} ${domainWord}
\n`;
section += `>\n`;
section += `> The following ${domainWord} ${domainCount === 1 ? "was" : "were"} blocked by the firewall during workflow execution:\n`;
section += `>\n`;
- // List domains as bullet points (within the alert)
+ // List domains as bullet points (within the details)
for (const domain of blockedDomains) {
section += `> - \`${domain}\`\n`;
}
section += `>\n`;
- section += `> To allow these domains, add them to the \`network.allowed\` list in your workflow frontmatter:\n`;
+ section += `> To allow ${domainCount === 1 ? "this domain" : "these domains"}, add ${domainCount === 1 ? "it" : "them"} to the \`network.allowed\` list in your workflow frontmatter:\n`;
section += `>\n`;
section += `> \`\`\`yaml\n`;
section += `> network:\n`;
@@ -219,6 +220,8 @@ function generateBlockedDomainsSection(blockedDomains) {
section += `> \`\`\`\n`;
section += `>\n`;
section += `> See [Network Configuration](https://github.github.com/gh-aw/reference/network/) for more information.\n`;
+ section += `>\n`;
+ section += `> \n`;
return section;
}
diff --git a/actions/setup/js/firewall_blocked_domains.test.cjs b/actions/setup/js/firewall_blocked_domains.test.cjs
index 71c70f8b65f..5e3a49243a9 100644
--- a/actions/setup/js/firewall_blocked_domains.test.cjs
+++ b/actions/setup/js/firewall_blocked_domains.test.cjs
@@ -309,7 +309,9 @@ describe("firewall_blocked_domains.cjs", () => {
const result = generateBlockedDomainsSection(["blocked.example.com"]);
expect(result).toContain("> [!WARNING]");
- expect(result).toContain("> **⚠️ Firewall blocked 1 domain**");
+ expect(result).toContain("> ");
+ expect(result).toContain("> ⚠️ Firewall blocked 1 domain
");
+ expect(result).toContain("> ");
expect(result).toContain("> - `blocked.example.com`");
expect(result).toContain("> The following domain was blocked by the firewall during workflow execution:");
expect(result).toContain('> ```yaml\n> network:\n> allowed:\n> - defaults\n> - "blocked.example.com"\n> ```');
@@ -321,7 +323,9 @@ describe("firewall_blocked_domains.cjs", () => {
const result = generateBlockedDomainsSection(domains);
expect(result).toContain("> [!WARNING]");
- expect(result).toContain("> **⚠️ Firewall blocked 3 domains**");
+ expect(result).toContain("> ");
+ expect(result).toContain("> ⚠️ Firewall blocked 3 domains
");
+ expect(result).toContain("> ");
expect(result).toContain("> - `alpha.example.com`");
expect(result).toContain("> - `beta.example.com`");
expect(result).toContain("> - `gamma.example.com`");
From 6d342ee6ffd8c496c5ed60953395f2fa16cfb192 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 24 Apr 2026 20:09:22 +0000
Subject: [PATCH 2/2] fix: remove duplicate emoji from firewall alert summary
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b8aaadba-06d5-4735-bbed-60f10a919560
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
---
actions/setup/js/firewall_blocked_domains.cjs | 2 +-
actions/setup/js/firewall_blocked_domains.test.cjs | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/actions/setup/js/firewall_blocked_domains.cjs b/actions/setup/js/firewall_blocked_domains.cjs
index 84c0b39393f..044d1097be2 100644
--- a/actions/setup/js/firewall_blocked_domains.cjs
+++ b/actions/setup/js/firewall_blocked_domains.cjs
@@ -197,7 +197,7 @@ function generateBlockedDomainsSection(blockedDomains) {
let section = "\n\n> [!WARNING]\n";
section += `> \n`;
- section += `> ⚠️ Firewall blocked ${domainCount} ${domainWord}
\n`;
+ section += `> Firewall blocked ${domainCount} ${domainWord}
\n`;
section += `>\n`;
section += `> The following ${domainWord} ${domainCount === 1 ? "was" : "were"} blocked by the firewall during workflow execution:\n`;
section += `>\n`;
diff --git a/actions/setup/js/firewall_blocked_domains.test.cjs b/actions/setup/js/firewall_blocked_domains.test.cjs
index 5e3a49243a9..243886b8457 100644
--- a/actions/setup/js/firewall_blocked_domains.test.cjs
+++ b/actions/setup/js/firewall_blocked_domains.test.cjs
@@ -310,7 +310,7 @@ describe("firewall_blocked_domains.cjs", () => {
expect(result).toContain("> [!WARNING]");
expect(result).toContain("> ");
- expect(result).toContain("> ⚠️ Firewall blocked 1 domain
");
+ expect(result).toContain("> Firewall blocked 1 domain
");
expect(result).toContain("> ");
expect(result).toContain("> - `blocked.example.com`");
expect(result).toContain("> The following domain was blocked by the firewall during workflow execution:");
@@ -324,7 +324,7 @@ describe("firewall_blocked_domains.cjs", () => {
expect(result).toContain("> [!WARNING]");
expect(result).toContain("> ");
- expect(result).toContain("> ⚠️ Firewall blocked 3 domains
");
+ expect(result).toContain("> Firewall blocked 3 domains
");
expect(result).toContain("> ");
expect(result).toContain("> - `alpha.example.com`");
expect(result).toContain("> - `beta.example.com`");