From 0c306d13de1ad5ed02c9fcfa79e8a093eb616c83 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sat, 27 Dec 2025 20:12:08 +0000 Subject: [PATCH] Fix unhandled error in mcp_inspect.go HTTP server startup (Alert #406) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Added error handling for os.RemoveAll(tmpDir) at line 525 to prevent silently ignoring cleanup failures when HTTP server startup fails. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 --- pkg/cli/mcp_inspect.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/cli/mcp_inspect.go b/pkg/cli/mcp_inspect.go index 14f2fe81167..5b469622ba1 100644 --- a/pkg/cli/mcp_inspect.go +++ b/pkg/cli/mcp_inspect.go @@ -522,7 +522,10 @@ func startSafeInputsServer(safeInputsConfig *workflow.SafeInputsConfig, verbose // Start the HTTP server serverCmd, err := startSafeInputsHTTPServer(tmpDir, port, verbose) if err != nil { - os.RemoveAll(tmpDir) + // Clean up temporary directory on error + if rmErr := os.RemoveAll(tmpDir); rmErr != nil && verbose { + mcpInspectLog.Printf("Warning: failed to clean up temporary directory %s: %v", tmpDir, rmErr) + } return nil, nil, "", fmt.Errorf("failed to start safe-inputs HTTP server: %w", err) }