From eaf7802b7b36e0e1745bbfaa4049f23162e765eb Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 18 Sep 2025 00:52:53 +0000 Subject: [PATCH 1/2] Initial plan From a229af6786e070fd9aed8a7664fc12f8ccfbdc06 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 18 Sep 2025 01:01:33 +0000 Subject: [PATCH 2/2] Rename supportsToolsWhitelist to supportsToolsAllowlist throughout codebase Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .github/workflows/ci-doctor.lock.yml | 2 +- .github/workflows/dev.lock.yml | 2 +- pkg/cli/commands.go | 2 +- .../workflows/test-ai-inference-github-models.lock.yml | 2 +- .../workflows/test-claude-add-issue-comment.lock.yml | 2 +- .../workflows/test-claude-add-issue-labels.lock.yml | 2 +- pkg/cli/workflows/test-claude-cache-memory.lock.yml | 2 +- pkg/cli/workflows/test-claude-command.lock.yml | 2 +- pkg/cli/workflows/test-claude-create-issue.lock.yml | 2 +- ...-claude-create-pull-request-review-comment.lock.yml | 2 +- .../workflows/test-claude-create-pull-request.lock.yml | 2 +- ...claude-create-repository-security-advisory.lock.yml | 2 +- pkg/cli/workflows/test-claude-max-patch-size.lock.yml | 2 +- pkg/cli/workflows/test-claude-mcp.lock.yml | 2 +- pkg/cli/workflows/test-claude-missing-tool.lock.yml | 2 +- .../workflows/test-claude-patch-size-exceeded.lock.yml | 2 +- .../workflows/test-claude-push-to-pr-branch.lock.yml | 2 +- pkg/cli/workflows/test-claude-update-issue.lock.yml | 2 +- .../workflows/test-codex-add-issue-comment.lock.yml | 4 ++-- pkg/cli/workflows/test-codex-add-issue-labels.lock.yml | 4 ++-- pkg/cli/workflows/test-codex-command.lock.yml | 4 ++-- pkg/cli/workflows/test-codex-custom-env.lock.yml | 4 ++-- .../test-playwright-accessibility-contrast.lock.yml | 2 +- pkg/workflow/agentic_engine.go | 10 +++++----- pkg/workflow/agentic_engine_test.go | 2 +- pkg/workflow/claude_engine.go | 2 +- pkg/workflow/claude_engine_test.go | 2 +- pkg/workflow/codex_engine.go | 2 +- pkg/workflow/codex_engine_test.go | 2 +- pkg/workflow/compiler.go | 6 +++--- pkg/workflow/custom_engine.go | 2 +- pkg/workflow/custom_engine_test.go | 4 ++-- 32 files changed, 43 insertions(+), 43 deletions(-) diff --git a/.github/workflows/ci-doctor.lock.yml b/.github/workflows/ci-doctor.lock.yml index daae6c2a619..2bec5251f09 100644 --- a/.github/workflows/ci-doctor.lock.yml +++ b/.github/workflows/ci-doctor.lock.yml @@ -780,7 +780,7 @@ jobs: version: "", workflow_name: "CI Failure Doctor", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/.github/workflows/dev.lock.yml b/.github/workflows/dev.lock.yml index 6cd845791ce..4b0edb98e8b 100644 --- a/.github/workflows/dev.lock.yml +++ b/.github/workflows/dev.lock.yml @@ -833,7 +833,7 @@ jobs: version: "", workflow_name: "dev", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/commands.go b/pkg/cli/commands.go index 54dec0e19cc..39f44291a11 100644 --- a/pkg/cli/commands.go +++ b/pkg/cli/commands.go @@ -110,7 +110,7 @@ func listAgenticEngines(verbose bool) error { // MCP support mcpSupport := "No" - if engine.SupportsToolsWhitelist() { + if engine.SupportsToolsAllowlist() { mcpSupport = "Yes" } diff --git a/pkg/cli/workflows/test-ai-inference-github-models.lock.yml b/pkg/cli/workflows/test-ai-inference-github-models.lock.yml index 87fd4a9b0d4..e8205b57d5a 100644 --- a/pkg/cli/workflows/test-ai-inference-github-models.lock.yml +++ b/pkg/cli/workflows/test-ai-inference-github-models.lock.yml @@ -190,7 +190,7 @@ jobs: version: "", workflow_name: "Test AI Inference GitHub Models", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-add-issue-comment.lock.yml b/pkg/cli/workflows/test-claude-add-issue-comment.lock.yml index f748cb6b7b4..28b9653c548 100644 --- a/pkg/cli/workflows/test-claude-add-issue-comment.lock.yml +++ b/pkg/cli/workflows/test-claude-add-issue-comment.lock.yml @@ -187,7 +187,7 @@ jobs: version: "", workflow_name: "Test Claude Add Issue Comment", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-add-issue-labels.lock.yml b/pkg/cli/workflows/test-claude-add-issue-labels.lock.yml index 82209e7f518..9d04f5f2368 100644 --- a/pkg/cli/workflows/test-claude-add-issue-labels.lock.yml +++ b/pkg/cli/workflows/test-claude-add-issue-labels.lock.yml @@ -187,7 +187,7 @@ jobs: version: "", workflow_name: "Test Claude Add Issue Labels", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-cache-memory.lock.yml b/pkg/cli/workflows/test-claude-cache-memory.lock.yml index 05342b922f5..df0ac3032d6 100644 --- a/pkg/cli/workflows/test-claude-cache-memory.lock.yml +++ b/pkg/cli/workflows/test-claude-cache-memory.lock.yml @@ -264,7 +264,7 @@ jobs: version: "", workflow_name: "Test Claude with Cache Memory File Share", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-command.lock.yml b/pkg/cli/workflows/test-claude-command.lock.yml index 680dc788287..b7a546f39c2 100644 --- a/pkg/cli/workflows/test-claude-command.lock.yml +++ b/pkg/cli/workflows/test-claude-command.lock.yml @@ -187,7 +187,7 @@ jobs: version: "", workflow_name: "Test Claude Command", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-create-issue.lock.yml b/pkg/cli/workflows/test-claude-create-issue.lock.yml index e09fce94f69..af0d09208f3 100644 --- a/pkg/cli/workflows/test-claude-create-issue.lock.yml +++ b/pkg/cli/workflows/test-claude-create-issue.lock.yml @@ -187,7 +187,7 @@ jobs: version: "", workflow_name: "Test Claude Create Issue", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-create-pull-request-review-comment.lock.yml b/pkg/cli/workflows/test-claude-create-pull-request-review-comment.lock.yml index 3c4225c9d0e..bedc82e23e5 100644 --- a/pkg/cli/workflows/test-claude-create-pull-request-review-comment.lock.yml +++ b/pkg/cli/workflows/test-claude-create-pull-request-review-comment.lock.yml @@ -187,7 +187,7 @@ jobs: version: "", workflow_name: "Test Claude Create Pull Request Review Comment", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-create-pull-request.lock.yml b/pkg/cli/workflows/test-claude-create-pull-request.lock.yml index 7c7740984b8..f7d55e3b53c 100644 --- a/pkg/cli/workflows/test-claude-create-pull-request.lock.yml +++ b/pkg/cli/workflows/test-claude-create-pull-request.lock.yml @@ -192,7 +192,7 @@ jobs: version: "", workflow_name: "Test Claude Create Pull Request", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-create-repository-security-advisory.lock.yml b/pkg/cli/workflows/test-claude-create-repository-security-advisory.lock.yml index 4e221657a13..5d879e72891 100644 --- a/pkg/cli/workflows/test-claude-create-repository-security-advisory.lock.yml +++ b/pkg/cli/workflows/test-claude-create-repository-security-advisory.lock.yml @@ -190,7 +190,7 @@ jobs: version: "", workflow_name: "Test Claude Create Repository Security Advisory", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-max-patch-size.lock.yml b/pkg/cli/workflows/test-claude-max-patch-size.lock.yml index ae627e9db6a..8b546dc1828 100644 --- a/pkg/cli/workflows/test-claude-max-patch-size.lock.yml +++ b/pkg/cli/workflows/test-claude-max-patch-size.lock.yml @@ -696,7 +696,7 @@ jobs: version: "", workflow_name: "Test Claude Patch Size Validation", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-mcp.lock.yml b/pkg/cli/workflows/test-claude-mcp.lock.yml index 6d63b43a9f9..9178cbd5420 100644 --- a/pkg/cli/workflows/test-claude-mcp.lock.yml +++ b/pkg/cli/workflows/test-claude-mcp.lock.yml @@ -190,7 +190,7 @@ jobs: version: "", workflow_name: "Test Claude MCP", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-missing-tool.lock.yml b/pkg/cli/workflows/test-claude-missing-tool.lock.yml index 1510970f98c..263d00f1abc 100644 --- a/pkg/cli/workflows/test-claude-missing-tool.lock.yml +++ b/pkg/cli/workflows/test-claude-missing-tool.lock.yml @@ -755,7 +755,7 @@ jobs: version: "", workflow_name: "Test Claude with Missing Tool Safe Output and Cache Memory", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-patch-size-exceeded.lock.yml b/pkg/cli/workflows/test-claude-patch-size-exceeded.lock.yml index f1e93e2cf46..c6eae48bd64 100644 --- a/pkg/cli/workflows/test-claude-patch-size-exceeded.lock.yml +++ b/pkg/cli/workflows/test-claude-patch-size-exceeded.lock.yml @@ -698,7 +698,7 @@ jobs: version: "", workflow_name: "Test Claude Patch Size Limit Exceeded", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-push-to-pr-branch.lock.yml b/pkg/cli/workflows/test-claude-push-to-pr-branch.lock.yml index bfe2624b2a9..426edb7b037 100644 --- a/pkg/cli/workflows/test-claude-push-to-pr-branch.lock.yml +++ b/pkg/cli/workflows/test-claude-push-to-pr-branch.lock.yml @@ -192,7 +192,7 @@ jobs: version: "", workflow_name: "Test Claude Push to PR Branch", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-claude-update-issue.lock.yml b/pkg/cli/workflows/test-claude-update-issue.lock.yml index ceb49762252..278548bfcf2 100644 --- a/pkg/cli/workflows/test-claude-update-issue.lock.yml +++ b/pkg/cli/workflows/test-claude-update-issue.lock.yml @@ -190,7 +190,7 @@ jobs: version: "", workflow_name: "Test Claude Update Issue", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/cli/workflows/test-codex-add-issue-comment.lock.yml b/pkg/cli/workflows/test-codex-add-issue-comment.lock.yml index 2fd3351bd55..e80706fec1c 100644 --- a/pkg/cli/workflows/test-codex-add-issue-comment.lock.yml +++ b/pkg/cli/workflows/test-codex-add-issue-comment.lock.yml @@ -82,7 +82,7 @@ jobs: version: "", workflow_name: "Test Codex Add Issue Comment", experimental: true, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: false, run_id: context.runId, run_number: context.runNumber, @@ -135,7 +135,7 @@ jobs: codex login --api-key "$OPENAI_API_KEY" # Run codex with log capture - pipefail ensures codex exit code is preserved - codex exec --full-auto "$INSTRUCTION" 2>&1 | tee /tmp/test-codex-add-issue-comment.log + codex --full-auto exec --dangerously-bypass-approvals-and-sandbox "$INSTRUCTION" 2>&1 | tee /tmp/test-codex-add-issue-comment.log env: GITHUB_AW_PROMPT: /tmp/aw-prompts/prompt.txt GITHUB_STEP_SUMMARY: ${{ env.GITHUB_STEP_SUMMARY }} diff --git a/pkg/cli/workflows/test-codex-add-issue-labels.lock.yml b/pkg/cli/workflows/test-codex-add-issue-labels.lock.yml index ae49eebb6f1..af534d837a8 100644 --- a/pkg/cli/workflows/test-codex-add-issue-labels.lock.yml +++ b/pkg/cli/workflows/test-codex-add-issue-labels.lock.yml @@ -82,7 +82,7 @@ jobs: version: "", workflow_name: "Test Codex Add Issue Labels", experimental: true, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: false, run_id: context.runId, run_number: context.runNumber, @@ -135,7 +135,7 @@ jobs: codex login --api-key "$OPENAI_API_KEY" # Run codex with log capture - pipefail ensures codex exit code is preserved - codex exec --full-auto "$INSTRUCTION" 2>&1 | tee /tmp/test-codex-add-issue-labels.log + codex --full-auto exec --dangerously-bypass-approvals-and-sandbox "$INSTRUCTION" 2>&1 | tee /tmp/test-codex-add-issue-labels.log env: GITHUB_AW_PROMPT: /tmp/aw-prompts/prompt.txt GITHUB_STEP_SUMMARY: ${{ env.GITHUB_STEP_SUMMARY }} diff --git a/pkg/cli/workflows/test-codex-command.lock.yml b/pkg/cli/workflows/test-codex-command.lock.yml index 329bf9e8c10..6215376f021 100644 --- a/pkg/cli/workflows/test-codex-command.lock.yml +++ b/pkg/cli/workflows/test-codex-command.lock.yml @@ -82,7 +82,7 @@ jobs: version: "", workflow_name: "Test Codex Command", experimental: true, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: false, run_id: context.runId, run_number: context.runNumber, @@ -135,7 +135,7 @@ jobs: codex login --api-key "$OPENAI_API_KEY" # Run codex with log capture - pipefail ensures codex exit code is preserved - codex exec --full-auto "$INSTRUCTION" 2>&1 | tee /tmp/test-codex-command.log + codex --full-auto exec --dangerously-bypass-approvals-and-sandbox "$INSTRUCTION" 2>&1 | tee /tmp/test-codex-command.log env: GITHUB_AW_PROMPT: /tmp/aw-prompts/prompt.txt GITHUB_STEP_SUMMARY: ${{ env.GITHUB_STEP_SUMMARY }} diff --git a/pkg/cli/workflows/test-codex-custom-env.lock.yml b/pkg/cli/workflows/test-codex-custom-env.lock.yml index 607c723901f..b7481eddbf8 100644 --- a/pkg/cli/workflows/test-codex-custom-env.lock.yml +++ b/pkg/cli/workflows/test-codex-custom-env.lock.yml @@ -82,7 +82,7 @@ jobs: version: "", workflow_name: "Test Codex Custom Environment Variable", experimental: true, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: false, run_id: context.runId, run_number: context.runNumber, @@ -135,7 +135,7 @@ jobs: codex login --api-key "$OPENAI_API_KEY" # Run codex with log capture - pipefail ensures codex exit code is preserved - codex exec --full-auto "$INSTRUCTION" 2>&1 | tee /tmp/test-codex-custom-environment-variable.log + codex --full-auto exec --dangerously-bypass-approvals-and-sandbox "$INSTRUCTION" 2>&1 | tee /tmp/test-codex-custom-environment-variable.log env: GITHUB_AW_PROMPT: /tmp/aw-prompts/prompt.txt GITHUB_STEP_SUMMARY: ${{ env.GITHUB_STEP_SUMMARY }} diff --git a/pkg/cli/workflows/test-playwright-accessibility-contrast.lock.yml b/pkg/cli/workflows/test-playwright-accessibility-contrast.lock.yml index addc0d3137a..70dbebfe1e2 100644 --- a/pkg/cli/workflows/test-playwright-accessibility-contrast.lock.yml +++ b/pkg/cli/workflows/test-playwright-accessibility-contrast.lock.yml @@ -704,7 +704,7 @@ jobs: version: "", workflow_name: "Test Playwright Accessibility Contrast", experimental: false, - supports_tools_whitelist: true, + supports_tools_allowlist: true, supports_http_transport: true, run_id: context.runId, run_number: context.runNumber, diff --git a/pkg/workflow/agentic_engine.go b/pkg/workflow/agentic_engine.go index 2c10970fe3f..657499cb648 100644 --- a/pkg/workflow/agentic_engine.go +++ b/pkg/workflow/agentic_engine.go @@ -26,8 +26,8 @@ type CodingAgentEngine interface { // IsExperimental returns true if this engine is experimental IsExperimental() bool - // SupportsToolsWhitelist returns true if this engine supports MCP tool allow-listing - SupportsToolsWhitelist() bool + // SupportsToolsAllowlist returns true if this engine supports MCP tool allow-listing + SupportsToolsAllowlist() bool // SupportsHTTPTransport returns true if this engine supports HTTP transport for MCP servers SupportsHTTPTransport() bool @@ -78,7 +78,7 @@ type BaseEngine struct { displayName string description string experimental bool - supportsToolsWhitelist bool + supportsToolsAllowlist bool supportsHTTPTransport bool supportsMaxTurns bool } @@ -99,8 +99,8 @@ func (e *BaseEngine) IsExperimental() bool { return e.experimental } -func (e *BaseEngine) SupportsToolsWhitelist() bool { - return e.supportsToolsWhitelist +func (e *BaseEngine) SupportsToolsAllowlist() bool { + return e.supportsToolsAllowlist } func (e *BaseEngine) SupportsHTTPTransport() bool { diff --git a/pkg/workflow/agentic_engine_test.go b/pkg/workflow/agentic_engine_test.go index 10a4bdff5b7..4ec48c7e333 100644 --- a/pkg/workflow/agentic_engine_test.go +++ b/pkg/workflow/agentic_engine_test.go @@ -93,7 +93,7 @@ func TestEngineRegistryCustomEngine(t *testing.T) { displayName: "Test Custom Engine", description: "A test custom engine", experimental: true, - supportsToolsWhitelist: false, + supportsToolsAllowlist: false, }, } diff --git a/pkg/workflow/claude_engine.go b/pkg/workflow/claude_engine.go index 993d420a3a0..29afb482452 100644 --- a/pkg/workflow/claude_engine.go +++ b/pkg/workflow/claude_engine.go @@ -21,7 +21,7 @@ func NewClaudeEngine() *ClaudeEngine { displayName: "Claude Code", description: "Uses Claude Code with full MCP tool support and allow-listing", experimental: false, - supportsToolsWhitelist: true, + supportsToolsAllowlist: true, supportsHTTPTransport: true, // Claude supports both stdio and HTTP transport supportsMaxTurns: true, // Claude supports max-turns feature }, diff --git a/pkg/workflow/claude_engine_test.go b/pkg/workflow/claude_engine_test.go index fa84e330aa9..91861603074 100644 --- a/pkg/workflow/claude_engine_test.go +++ b/pkg/workflow/claude_engine_test.go @@ -25,7 +25,7 @@ func TestClaudeEngine(t *testing.T) { t.Error("Claude engine should not be experimental") } - if !engine.SupportsToolsWhitelist() { + if !engine.SupportsToolsAllowlist() { t.Error("Claude engine should support MCP tools") } diff --git a/pkg/workflow/codex_engine.go b/pkg/workflow/codex_engine.go index d35c30e1af0..0d65107443a 100644 --- a/pkg/workflow/codex_engine.go +++ b/pkg/workflow/codex_engine.go @@ -44,7 +44,7 @@ func NewCodexEngine() *CodexEngine { displayName: "Codex", description: "Uses OpenAI Codex CLI with MCP server support", experimental: true, - supportsToolsWhitelist: true, + supportsToolsAllowlist: true, supportsHTTPTransport: false, // Codex only supports stdio transport supportsMaxTurns: false, // Codex does not support max-turns feature }, diff --git a/pkg/workflow/codex_engine_test.go b/pkg/workflow/codex_engine_test.go index a40a0221429..126ede4fe0d 100644 --- a/pkg/workflow/codex_engine_test.go +++ b/pkg/workflow/codex_engine_test.go @@ -21,7 +21,7 @@ func TestCodexEngine(t *testing.T) { t.Error("Codex engine should be experimental") } - if !engine.SupportsToolsWhitelist() { + if !engine.SupportsToolsAllowlist() { t.Error("Codex engine should support MCP tools") } diff --git a/pkg/workflow/compiler.go b/pkg/workflow/compiler.go index 015c5f8a144..aa675665f48 100644 --- a/pkg/workflow/compiler.go +++ b/pkg/workflow/compiler.go @@ -602,8 +602,8 @@ func (c *Compiler) parseWorkflowFile(markdownPath string) (*WorkflowData, error) return nil, fmt.Errorf("HTTP transport not supported: %w", err) } - if !agenticEngine.SupportsToolsWhitelist() { - // For engines that don't support tool whitelists (like codex), ignore tools section and provide warnings + if !agenticEngine.SupportsToolsAllowlist() { + // For engines that don't support tool allowlists (like codex), ignore tools section and provide warnings fmt.Println(console.FormatWarningMessage(fmt.Sprintf("Using experimental %s support (engine: %s)", agenticEngine.GetDisplayName(), engineSetting))) if _, hasTools := result.Frontmatter["tools"]; hasTools { fmt.Println(console.FormatWarningMessage(fmt.Sprintf("'tools' section ignored when using engine: %s (%s doesn't support MCP tool allow-listing)", engineSetting, agenticEngine.GetDisplayName()))) @@ -4585,7 +4585,7 @@ func (c *Compiler) generateCreateAwInfo(yaml *strings.Builder, data *WorkflowDat // Workflow information fmt.Fprintf(yaml, " workflow_name: \"%s\",\n", data.Name) fmt.Fprintf(yaml, " experimental: %t,\n", engine.IsExperimental()) - fmt.Fprintf(yaml, " supports_tools_whitelist: %t,\n", engine.SupportsToolsWhitelist()) + fmt.Fprintf(yaml, " supports_tools_allowlist: %t,\n", engine.SupportsToolsAllowlist()) fmt.Fprintf(yaml, " supports_http_transport: %t,\n", engine.SupportsHTTPTransport()) // Run metadata diff --git a/pkg/workflow/custom_engine.go b/pkg/workflow/custom_engine.go index fd57c7bf950..7e63fcf1170 100644 --- a/pkg/workflow/custom_engine.go +++ b/pkg/workflow/custom_engine.go @@ -18,7 +18,7 @@ func NewCustomEngine() *CustomEngine { displayName: "Custom Steps", description: "Executes user-defined GitHub Actions steps", experimental: false, - supportsToolsWhitelist: false, + supportsToolsAllowlist: false, supportsHTTPTransport: false, supportsMaxTurns: true, // Custom engine supports max-turns for consistency }, diff --git a/pkg/workflow/custom_engine_test.go b/pkg/workflow/custom_engine_test.go index b28fac9a256..c3aeff0d959 100644 --- a/pkg/workflow/custom_engine_test.go +++ b/pkg/workflow/custom_engine_test.go @@ -70,8 +70,8 @@ func TestCustomEngine(t *testing.T) { t.Error("Expected custom engine to not be experimental") } - if engine.SupportsToolsWhitelist() { - t.Error("Expected custom engine to not support tools whitelist") + if engine.SupportsToolsAllowlist() { + t.Error("Expected custom engine to not support tools allowlist") } if engine.SupportsHTTPTransport() {