From 4b8ac0a5162c6c469f9d2133bf29f834e6da4b89 Mon Sep 17 00:00:00 2001 From: Elijah Buck Date: Mon, 1 Sep 2014 14:36:19 -0700 Subject: [PATCH 1/2] Add group objectclass to allow AD nested group search. Bump to 1.3.5 --- github-ldap.gemspec | 2 +- lib/github/ldap/group.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/github-ldap.gemspec b/github-ldap.gemspec index 9b598d6..8458897 100644 --- a/github-ldap.gemspec +++ b/github-ldap.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |spec| spec.name = "github-ldap" - spec.version = "1.3.4" + spec.version = "1.3.5" spec.authors = ["David Calavera"] spec.email = ["david.calavera@gmail.com"] spec.description = %q{Ldap authentication for humans} diff --git a/lib/github/ldap/group.rb b/lib/github/ldap/group.rb index 3d53066..25066a0 100644 --- a/lib/github/ldap/group.rb +++ b/lib/github/ldap/group.rb @@ -12,7 +12,7 @@ class Ldap class Group include Filter - GROUP_CLASS_NAMES = %w(groupOfNames groupOfUniqueNames posixGroup) + GROUP_CLASS_NAMES = %w(groupOfNames groupOfUniqueNames posixGroup group) attr_reader :ldap, :entry From c5f5b12e7621604a77678883c239aae4968d7b65 Mon Sep 17 00:00:00 2001 From: Matt Todd Date: Mon, 1 Sep 2014 19:59:12 -0700 Subject: [PATCH 2/2] Test group detection for supported object classes --- test/group_test.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/group_test.rb b/test/group_test.rb index a6fbf1f..6f1714d 100644 --- a/test/group_test.rb +++ b/test/group_test.rb @@ -15,6 +15,10 @@ def setup end def test_group? + assert @group.group?(%w(group)) + assert @group.group?(%w(groupOfUniqueNames)) + assert @group.group?(%w(posixGroup)) + object_classes = %w(groupOfNames) assert @group.group?(object_classes) assert @group.group?(object_classes.map(&:downcase))