add in e2e and also try to get the LLM to call notifications off its own back

Author: SamMorrowDrums

e2e/e2e_test.go

@@ -1525,3 +1525,251 @@ func TestPullRequestReviewDeletion(t *testing.T) {
 	require.NoError(t, err, "expected to unmarshal text content successfully")
 	require.Len(t, noReviews, 0, "expected to find no reviews")
 }
+
+func TestE2E_ListNotifications(t *testing.T) {
+	t.Parallel()
+	client := setupMCPClient(t)
+	ctx := context.Background()
+
+	request := mcp.CallToolRequest{}
+	request.Params.Name = "list_notifications"
+	request.Params.Arguments = map[string]any{}
+
+	resp, err := client.CallTool(ctx, request)
+	require.NoError(t, err, "expected to call 'list_notifications' tool successfully")
+	require.False(t, resp.IsError, fmt.Sprintf("expected result not to be an error: %+v", resp))
+	require.Len(t, resp.Content, 1, "expected content to have one item")
+
+	var notifications []struct {
+		ID string `json:"id"`
+	}
+	textContent, ok := resp.Content[0].(mcp.TextContent)
+	require.True(t, ok, "expected content to be of type TextContent")
+	err = json.Unmarshal([]byte(textContent.Text), &notifications)
+	require.NoError(t, err, "expected to unmarshal text content successfully")
+}
+
+func TestE2E_ManageNotificationSubscription(t *testing.T) {
+	t.Parallel()
+	client := setupMCPClient(t)
+	ctx := context.Background()
+
+	// List notifications to get a valid notificationID
+	listReq := mcp.CallToolRequest{}
+	listReq.Params.Name = "list_notifications"
+	listReq.Params.Arguments = map[string]any{}
+	resp, err := client.CallTool(ctx, listReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	if len(resp.Content) == 0 {
+		return t.Skip("No notifications available to test subscription management")
+	}
+	textContent, ok := resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	var notifications []struct {
+		ID string `json:"id"`
+	}
+	err = json.Unmarshal([]byte(textContent.Text), &notifications)
+	require.NoError(t, err)
+	require.NotEmpty(t, notifications)
+	notificationID := notifications[0].ID
+
+	// Ignore notification
+	ignoreReq := mcp.CallToolRequest{}
+	ignoreReq.Params.Name = "manage_notification_subscription"
+	ignoreReq.Params.Arguments = map[string]any{
+		"notificationID": notificationID,
+		"action":         "ignore",
+	}
+	resp, err = client.CallTool(ctx, ignoreReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok = resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	require.Contains(t, textContent.Text, "ignored")
+
+	// Watch notification
+	watchReq := mcp.CallToolRequest{}
+	watchReq.Params.Name = "manage_notification_subscription"
+	watchReq.Params.Arguments = map[string]any{
+		"notificationID": notificationID,
+		"action":         "watch",
+	}
+	resp, err = client.CallTool(ctx, watchReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok = resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	require.Contains(t, textContent.Text, "subscribed")
+
+	// Delete notification subscription
+	deleteReq := mcp.CallToolRequest{}
+	deleteReq.Params.Name = "manage_notification_subscription"
+	deleteReq.Params.Arguments = map[string]any{
+		"notificationID": notificationID,
+		"action":         "delete",
+	}
+	resp, err = client.CallTool(ctx, deleteReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok = resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	require.Contains(t, textContent.Text, "deleted")
+}
+
+func TestE2E_ManageRepositoryNotificationSubscription(t *testing.T) {
+	t.Parallel()
+	client := setupMCPClient(t)
+	ctx := context.Background()
+
+	// Use a well-known repo for the test (e.g., the user's own repo)
+	owner := "github"
+	repo := "github-mcp-server"
+
+	// Ignore repo notifications
+	ignoreReq := mcp.CallToolRequest{}
+	ignoreReq.Params.Name = "manage_repository_notification_subscription"
+	ignoreReq.Params.Arguments = map[string]any{
+		"owner":  owner,
+		"repo":   repo,
+		"action": "ignore",
+	}
+	resp, err := client.CallTool(ctx, ignoreReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok := resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	require.Contains(t, textContent.Text, "ignored")
+
+	// Watch repo notifications
+	watchReq := mcp.CallToolRequest{}
+	watchReq.Params.Name = "manage_repository_notification_subscription"
+	watchReq.Params.Arguments = map[string]any{
+		"owner":  owner,
+		"repo":   repo,
+		"action": "watch",
+	}
+	resp, err = client.CallTool(ctx, watchReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok = resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	require.Contains(t, textContent.Text, "subscribed")
+
+	// Delete repo notification subscription
+	deleteReq := mcp.CallToolRequest{}
+	deleteReq.Params.Name = "manage_repository_notification_subscription"
+	deleteReq.Params.Arguments = map[string]any{
+		"owner":  owner,
+		"repo":   repo,
+		"action": "delete",
+	}
+	resp, err = client.CallTool(ctx, deleteReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok = resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	require.Contains(t, textContent.Text, "deleted")
+}
+
+func TestE2E_DismissNotification(t *testing.T) {
+	t.Parallel()
+	client := setupMCPClient(t)
+	ctx := context.Background()
+
+	// List notifications to get a valid threadID
+	listReq := mcp.CallToolRequest{}
+	listReq.Params.Name = "list_notifications"
+	listReq.Params.Arguments = map[string]any{}
+	resp, err := client.CallTool(ctx, listReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	if len(resp.Content) == 0 {
+		return t.Skip("No notifications available to test dismissal")
+	}
+	textContent, ok := resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	var notifications []struct {
+		ID string `json:"id"`
+	}
+	err = json.Unmarshal([]byte(textContent.Text), &notifications)
+	require.NoError(t, err)
+	require.NotEmpty(t, notifications)
+	threadID := notifications[0].ID
+
+	// Dismiss notification (mark as read)
+	dismissReq := mcp.CallToolRequest{}
+	dismissReq.Params.Name = "dismiss_notification"
+	dismissReq.Params.Arguments = map[string]any{
+		"threadID": threadID,
+		"state":    "read",
+	}
+	resp, err = client.CallTool(ctx, dismissReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok = resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	require.Contains(t, textContent.Text, "read")
+}
+
+func TestE2E_MarkAllNotificationsRead(t *testing.T) {
+	t.Parallel()
+	client := setupMCPClient(t)
+	ctx := context.Background()
+
+	// Limit to notifications updated within the last hour
+	oneHourAgo := nowMinusOneHourRFC3339()
+	markAllReq := mcp.CallToolRequest{}
+	markAllReq.Params.Name = "mark_all_notifications_read"
+	markAllReq.Params.Arguments = map[string]any{
+		"since": oneHourAgo,
+	}
+	resp, err := client.CallTool(ctx, markAllReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok := resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	require.Contains(t, textContent.Text, "All notifications marked as read")
+
+}
+
+// nowMinusOneHourRFC3339 returns the RFC3339 timestamp for one hour ago from now (UTC)
+func nowMinusOneHourRFC3339() string {
+	return time.Now().UTC().Add(-1 * time.Hour).Format(time.RFC3339)
+}
+
+func TestE2E_GetNotificationDetails(t *testing.T) {
+	t.Parallel()
+	client := setupMCPClient(t)
+	ctx := context.Background()
+
+	// List notifications to get a valid notificationID
+	listReq := mcp.CallToolRequest{}
+	listReq.Params.Name = "list_notifications"
+	listReq.Params.Arguments = map[string]any{}
+	resp, err := client.CallTool(ctx, listReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok := resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	var notifications []struct {
+		ID string `json:"id"`
+	}
+	err = json.Unmarshal([]byte(textContent.Text), &notifications)
+	require.NoError(t, err)
+	require.NotEmpty(t, notifications)
+	notificationID := notifications[0].ID
+
+	// Get notification details
+	detailsReq := mcp.CallToolRequest{}
+	detailsReq.Params.Name = "get_notification_details"
+	detailsReq.Params.Arguments = map[string]any{
+		"notificationID": notificationID,
+	}
+	resp, err = client.CallTool(ctx, detailsReq)
+	require.NoError(t, err)
+	require.False(t, resp.IsError)
+	textContent, ok = resp.Content[0].(mcp.TextContent)
+	require.True(t, ok)
+	require.Contains(t, textContent.Text, notificationID)
+}

pkg/github/notifications.go

@@ -24,7 +24,7 @@ const (
 // ListNotifications creates a tool to list notifications for the current user.
 func ListNotifications(getClient GetClientFn, t translations.TranslationHelperFunc) (tool mcp.Tool, handler server.ToolHandlerFunc) {
 	return mcp.NewTool("list_notifications",
-			mcp.WithDescription(t("TOOL_LIST_NOTIFICATIONS_DESCRIPTION", "List current notifications for the authenticated GitHub user")),
+			mcp.WithDescription(t("TOOL_LIST_NOTIFICATIONS_DESCRIPTION", "List current notifications for the authenticated GitHub user, check these from time to time, especially if you know the user is involved in discussions, issues or pull requests.")),
 			mcp.WithToolAnnotation(mcp.ToolAnnotation{
 				Title:        t("TOOL_LIST_NOTIFICATIONS_USER_TITLE", "List notifications"),
 				ReadOnlyHint: toBoolPtr(true),