Independent publishing for npm and github registry #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthkp
commented
Oct 10, 2022
| cache: npm | ||
| - run: npm ci | ||
| - run: npm test | ||
| - run: npm version ${TAG_NAME} --git-tag-version=false |
Contributor
Author
There was a problem hiding this comment.
Task for the future (after verifying this works): I think this can be optimised by combining common steps between the two jobs
keithamus
reviewed
Oct 10, 2022
.github/workflows/publish.yml
Outdated
| - run: npm version ${TAG_NAME} --git-tag-version=false | ||
| env: | ||
| TAG_NAME: ${{ github.event.release.tag_name }} | ||
| - run: npm whoami; npm publish --ignore-scripts --@github:registry='https://npm.pkg.github.com' |
Contributor
There was a problem hiding this comment.
you probably don't want --ignore-scripts here, now.
Contributor
Author
There was a problem hiding this comment.
good catch! removed
keithamus
approved these changes
Oct 10, 2022
siddharthkp
changed the title
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes publishing to npm and github registry independent
Unlike before, If the first one fails, it would not stop the second