From ff954fdaba9558640575536e991d18b4f098696a Mon Sep 17 00:00:00 2001
From: Matt Todd <chiology@gmail.com>
Date: Mon, 22 Sep 2014 13:48:22 -0700
Subject: [PATCH 1/4] Add failing test for task list updates on links

---
 test/unit/test_updates.coffee | 66 +++++++++++++++++++++++++++++++++++
 1 file changed, 66 insertions(+)

diff --git a/test/unit/test_updates.coffee b/test/unit/test_updates.coffee
index 1f7c595..ac38506 100644
--- a/test/unit/test_updates.coffee
+++ b/test/unit/test_updates.coffee
@@ -440,3 +440,69 @@ asyncTest "update ignores items that look like Task List items but lack list pre
   , 20
 
   item2Checkbox.click()
+
+asyncTest "update ignores items that look like Task List items but are links", ->
+  expect 3
+
+  $('#qunit-fixture').empty()
+
+  container = $ '<div>', class: 'js-task-list-container'
+
+  list = $ '<ul>', class: 'task-list'
+
+  item1 = $ '<li>', class: 'task-list-item'
+  item1Checkbox = $ '<input>',
+    type: 'checkbox'
+    class: 'task-list-item-checkbox'
+    disabled: true
+    checked: false
+
+  item2 = $ '<li>', class: 'task-list-item'
+  item2Checkbox = $ '<input>',
+    type: 'checkbox'
+    class: 'task-list-item-checkbox'
+    disabled: true
+    checked: false
+
+  field = $ '<textarea>', class: 'js-task-list-field', text: """
+    - [ ] (link)
+    - [ ] [reference]
+    - [ ] () collapsed
+    - [ ] [] collapsed reference
+    - [ ] \(escaped item)
+    - [ ] item
+  """
+
+  changes = """
+    - [ ] (link)
+    - [ ] [reference]
+    - [ ] () collapsed
+    - [ ] [] collapsed reference
+    - [ ] \(escaped item)
+    - [x] item
+  """
+
+  item1.append item2Checkbox
+  list.append item1
+  item1.expectedIndex = 1
+
+  item2.append item2Checkbox
+  list.append item2
+  item2.expectedIndex = 2
+
+  container.append list
+  container.append field
+
+  $('#qunit-fixture').append(container)
+  container.taskList()
+
+  field.on 'tasklist:changed', (event, index, checked) =>
+    ok checked
+    equal index, item2.expectedIndex
+    equal field.val(), changes
+
+  setTimeout ->
+    start()
+  , 20
+
+  item2Checkbox.click()

From 02bc4beca4d32161e2b5ea4fbd6ef29ef6ab6a39 Mon Sep 17 00:00:00 2001
From: Matt Todd <chiology@gmail.com>
Date: Mon, 22 Sep 2014 13:56:48 -0700
Subject: [PATCH 2/4] Whoops, fix the failing test

---
 test/unit/test_updates.coffee | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/unit/test_updates.coffee b/test/unit/test_updates.coffee
index ac38506..c5b55e5 100644
--- a/test/unit/test_updates.coffee
+++ b/test/unit/test_updates.coffee
@@ -469,7 +469,7 @@ asyncTest "update ignores items that look like Task List items but are links", -
     - [ ] [reference]
     - [ ] () collapsed
     - [ ] [] collapsed reference
-    - [ ] \(escaped item)
+    - [ ] \\(escaped item)
     - [ ] item
   """
 
@@ -478,11 +478,11 @@ asyncTest "update ignores items that look like Task List items but are links", -
     - [ ] [reference]
     - [ ] () collapsed
     - [ ] [] collapsed reference
-    - [ ] \(escaped item)
+    - [ ] \\(escaped item)
     - [x] item
   """
 
-  item1.append item2Checkbox
+  item1.append item1Checkbox
   list.append item1
   item1.expectedIndex = 1
 

From d2447f61cbb512004da85a94e1c9f8f6e2099409 Mon Sep 17 00:00:00 2001
From: Matt Todd <chiology@gmail.com>
Date: Mon, 22 Sep 2014 13:58:05 -0700
Subject: [PATCH 3/4] Ignore links, easily mistaken as task list items

cc @aroben @bkeepers @raganwald
---
 app/assets/javascripts/task_list.coffee | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/app/assets/javascripts/task_list.coffee b/app/assets/javascripts/task_list.coffee
index 8996cab..95f6f63 100644
--- a/app/assets/javascripts/task_list.coffee
+++ b/app/assets/javascripts/task_list.coffee
@@ -125,7 +125,11 @@ itemPattern = ///
     #{escapePattern(complete)}|
     #{escapePattern(incomplete)}
   )
-  (?=\s)                  # followed by whitespace
+  (?!                     # is not a link
+    \s*                   # with optional whitespace
+    (?=\(.*?\)|\[.*?\])   # because of destination or reference
+  )
+  (?=\s)                  # is followed by whitespace
 ///
 
 # Used to filter out code fences from the source for comparison only.

From 7766dedd6885b114c53c444c9e24fb6ffad5584e Mon Sep 17 00:00:00 2001
From: Matt Todd <chiology@gmail.com>
Date: Mon, 22 Sep 2014 14:10:33 -0700
Subject: [PATCH 4/4] No lookahead needed here

h/t @aroben
---
 app/assets/javascripts/task_list.coffee | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/assets/javascripts/task_list.coffee b/app/assets/javascripts/task_list.coffee
index 95f6f63..fbb08d8 100644
--- a/app/assets/javascripts/task_list.coffee
+++ b/app/assets/javascripts/task_list.coffee
@@ -127,7 +127,7 @@ itemPattern = ///
   )
   (?!                     # is not a link
     \s*                   # with optional whitespace
-    (?=\(.*?\)|\[.*?\])   # because of destination or reference
+    (?:\(.*?\)|\[.*?\])   # because of destination or reference
   )
   (?=\s)                  # is followed by whitespace
 ///