From 7358e7f33b72915d438d0ffaf185697d2fe58a4d Mon Sep 17 00:00:00 2001 From: Jak Spalding Date: Mon, 29 Oct 2012 15:32:48 +0000 Subject: [PATCH 1/4] IE10 doesn't use alpha(opacity) --- src/dom/dom.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dom/dom.js b/src/dom/dom.js index 3c23999..57cd7c4 100755 --- a/src/dom/dom.js +++ b/src/dom/dom.js @@ -2845,7 +2845,7 @@ if (typeof val == "number" && hasUnits.test(originalProp)) { val = val.toString() + "px"; } - if (prop == "opacity" && env.ie) { + if (prop == "opacity" && env.ie < 10) { //in IE the element needs hasLayout for opacity to work thisStyle.zoom = "1"; if (val === "") { From 50241cf139deb7f1b1d268c53d58b37b87cc8880 Mon Sep 17 00:00:00 2001 From: Jak Spalding Date: Mon, 29 Oct 2012 15:46:10 +0000 Subject: [PATCH 2/4] More likely to work --- src/dom/dom.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dom/dom.js b/src/dom/dom.js index 57cd7c4..394dfab 100755 --- a/src/dom/dom.js +++ b/src/dom/dom.js @@ -2845,7 +2845,7 @@ if (typeof val == "number" && hasUnits.test(originalProp)) { val = val.toString() + "px"; } - if (prop == "opacity" && env.ie < 10) { + if (prop == "opacity" && parseInt(env.ie, 10) < 10) { //in IE the element needs hasLayout for opacity to work thisStyle.zoom = "1"; if (val === "") { From 9d132e7c5458cda4a4300113cc25b1651e8cb5d4 Mon Sep 17 00:00:00 2001 From: Jak Spalding Date: Mon, 29 Oct 2012 20:39:57 +0000 Subject: [PATCH 3/4] Use feature detection rather than browser detection --- src/dom/dom.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/dom/dom.js b/src/dom/dom.js index 394dfab..8c7321a 100755 --- a/src/dom/dom.js +++ b/src/dom/dom.js @@ -2845,7 +2845,10 @@ if (typeof val == "number" && hasUnits.test(originalProp)) { val = val.toString() + "px"; } - if (prop == "opacity" && parseInt(env.ie, 10) < 10) { + + // Use feature detection to support older IEs + // http://blogs.msdn.com/b/ie/archive/2010/08/17/ie9-opacity-and-alpha.aspx + if (prop == "opacity" && typeof document.createElement("div").style.opacity == 'undefined') { //in IE the element needs hasLayout for opacity to work thisStyle.zoom = "1"; if (val === "") { From 1291c8aa7c3c51cd61c78ae6c49b20a530fb8d3f Mon Sep 17 00:00:00 2001 From: Jak Spalding Date: Mon, 29 Oct 2012 20:51:07 +0000 Subject: [PATCH 4/4] Document changes and up version number --- CHANGES | 4 ++++ build.properties | 4 ++-- src/map.js | 4 ++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index e52d6be..65b51bd 100644 --- a/CHANGES +++ b/CHANGES @@ -1,5 +1,9 @@ Glow Changelog +1.7.8 + +* glow.dom - Switched IE browser detection for feature detection so opacity works in IE 10 + 1.7.7 * glow.widgets.AutoSuggest - Fix bug that appeared when escaping the textfield after entering no text. diff --git a/build.properties b/build.properties index e00c63a..ee36493 100644 --- a/build.properties +++ b/build.properties @@ -1,3 +1,3 @@ LINE=1.7 -VERSION=1.7.7 -CSSVERSION=177 +VERSION=1.7.8 +CSSVERSION=178 diff --git a/src/map.js b/src/map.js index 91f2884..2788457 100755 --- a/src/map.js +++ b/src/map.js @@ -184,6 +184,10 @@ gloader.map.add( { $version: "1.7.7" } + , + { + $version: "1.7.8" + } ); })(); // end closure