Skip to content

Use gomail library instead of gomail's smtp #36032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lunny wants to merge 2 commits into from
Closed

Use gomail library instead of gomail's smtp #36032

lunny wants to merge 2 commits into from

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 26, 2025

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 26, 2025
@silverwind
Copy link
Member

silverwind commented Nov 28, 2025 •
edited
Loading

I see this is still importing go-mail/smtp, I assume all these imports will be removed in the end?

BTW not sure how feasible, but there is https://pkg.go.dev/net/smtp in the stdlib which should be enough for basic mail sending at least and less 3rd-party dependencies is always good.

@lunny lunny mentioned this pull request Nov 29, 2025
Merged
@lunny
Copy link
Member Author

lunny commented Nov 29, 2025

I see this is still importing go-mail/smtp, I assume all these imports will be removed in the end?

BTW not sure how feasible, but there is pkg.go.dev/net/smtp in the stdlib which should be enough for basic mail sending at least and less 3rd-party dependencies is always good.

Good idea. I sent #36055 to replace this one.

@lunny lunny closed this Nov 29, 2025
@lunny lunny deleted the lunny/mail branch November 29, 2025 00:58
silverwind pushed a commit that referenced this pull request Dec 4, 2025
@lunny @GiteaBot
Use Golang net/smtp instead of gomail's smtp to send email (#36055)
ee6e371 
Replace #36032
Fix #36030

This PR use `net/smtp` instead of gomail's smtp. Now
github.com/wneessen/go-mail will be used only for generating email
message body.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Dec 4, 2025
@lunny @GiteaBot
Use Golang net/smtp instead of gomail's smtp to send email (go-gitea#…
366bac0 
…36055)

Replace go-gitea#36032
Fix go-gitea#36030

This PR use `net/smtp` instead of gomail's smtp. Now
github.com/wneessen/go-mail will be used only for generating email
message body.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot mentioned this pull request Dec 4, 2025
Merged
silverwind pushed a commit that referenced this pull request Dec 4, 2025
@GiteaBot @lunny
Use Golang net/smtp instead of gomail's smtp to send email (#36055) (#…
0ab4470 
…36083)

Backport #36055 by @lunny

Replace #36032
Fix #36030

This PR use `net/smtp` instead of gomail's smtp. Now
github.com/wneessen/go-mail will be used only for generating email
message body.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@xnox xnox mentioned this pull request Dec 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lunny @silverwind @GiteaBot