From 76e141aefb81452b0f9be070863c77b167eadf3f Mon Sep 17 00:00:00 2001 From: Terin Stock Date: Tue, 9 May 2017 08:08:44 -0700 Subject: [PATCH] fix(transport/grpc): remove autoprefixing logic Removes the autoprefixing of "pb" to service names, to allow for grpc services created without a package prefix. Fixes #447. BREAKING CHANGE: Existing users of the grpc client transport who were relying on the autoprefixing of the "pb" package name must manually update their clients to add it. No change is required if a package name was already being manually prefixed. --- examples/addsvc/client/grpc/client.go | 4 ++-- transport/grpc/client.go | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/examples/addsvc/client/grpc/client.go b/examples/addsvc/client/grpc/client.go index 5ede6197e..2abcdae27 100644 --- a/examples/addsvc/client/grpc/client.go +++ b/examples/addsvc/client/grpc/client.go @@ -34,7 +34,7 @@ func New(conn *grpc.ClientConn, tracer stdopentracing.Tracer, logger log.Logger) { sumEndpoint = grpctransport.NewClient( conn, - "Add", + "pb.Add", "Sum", addsvc.EncodeGRPCSumRequest, addsvc.DecodeGRPCSumResponse, @@ -53,7 +53,7 @@ func New(conn *grpc.ClientConn, tracer stdopentracing.Tracer, logger log.Logger) { concatEndpoint = grpctransport.NewClient( conn, - "Add", + "pb.Add", "Concat", addsvc.EncodeGRPCConcatRequest, addsvc.DecodeGRPCConcatResponse, diff --git a/transport/grpc/client.go b/transport/grpc/client.go index c0faa2b36..535b70f24 100644 --- a/transport/grpc/client.go +++ b/transport/grpc/client.go @@ -4,7 +4,6 @@ import ( "context" "fmt" "reflect" - "strings" "google.golang.org/grpc" "google.golang.org/grpc/metadata" @@ -37,9 +36,6 @@ func NewClient( grpcReply interface{}, options ...ClientOption, ) *Client { - if strings.IndexByte(serviceName, '.') == -1 { - serviceName = "pb." + serviceName - } c := &Client{ client: cc, method: fmt.Sprintf("/%s/%s", serviceName, method),