From 69b3812d15659409f05aeec460d600f5a4034c65 Mon Sep 17 00:00:00 2001 From: Nicolas Merget Date: Tue, 17 Sep 2024 22:26:48 +0200 Subject: [PATCH] fix: issue with !is_inside_tree() when starting editor --- .gitignore | 1 + CONTRIBUTING.md | 2 +- editor/editor_tools.cpp | 2 -- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index f1ec0ff7..1d0b7e8a 100644 --- a/.gitignore +++ b/.gitignore @@ -10,3 +10,4 @@ .vscode .idea /site +venv diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4f10f618..4ae82256 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,6 +25,6 @@ As a maintainer you are able to create a new release. 3. Select target ``master`` 4. Click ``Generate release notes`` 5. (Optional) You can edit the generated release notes -6. Add a release title in the format ``[Godot_Version]-[Tag]-alpha-[Year][Month][Day]`` as an example ``4.1-v0.0.17-alpha-20231003`` +6. Add a release title in the format ``[Tag]-alpha-[Year][Month][Day]`` as an example ``v0.0.17-alpha-20231003``. The used godot version will be added ass prefix automatically 7. Press ``Publish release`` diff --git a/editor/editor_tools.cpp b/editor/editor_tools.cpp index 6373b8c4..875405dc 100644 --- a/editor/editor_tools.cpp +++ b/editor/editor_tools.cpp @@ -80,7 +80,6 @@ JavaScriptPlugin::JavaScriptPlugin(EditorNode *p_node) { declaration_file_dialog->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE); declaration_file_dialog->set_access(EditorFileDialog::ACCESS_FILESYSTEM); declaration_file_dialog->add_filter(TTR("*.d.ts;TypeScript Declaration file")); - declaration_file_dialog->set_current_file("godot.d.ts"); declaration_file_dialog->connect("file_selected", callable_mp(this, &JavaScriptPlugin::_export_typescript_declare_file)); EditorNode::get_singleton()->get_gui_base()->add_child(declaration_file_dialog); @@ -89,7 +88,6 @@ JavaScriptPlugin::JavaScriptPlugin(EditorNode *p_node) { enumberation_file_dialog->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE); enumberation_file_dialog->set_access(EditorFileDialog::ACCESS_FILESYSTEM); enumberation_file_dialog->add_filter(TTR("*.mjs;JavaScript file")); - enumberation_file_dialog->set_current_file("enumerations.mjs"); enumberation_file_dialog->connect("file_selected", callable_mp(this, &JavaScriptPlugin::_export_enumeration_binding_file)); EditorNode::get_singleton()->get_gui_base()->add_child(enumberation_file_dialog);