From 65957cb9890cd1ffd7a6c05c179c75a45f998fb4 Mon Sep 17 00:00:00 2001 From: RW Date: Mon, 14 Jul 2025 09:22:17 +0200 Subject: [PATCH 1/3] fix: use go install for upgrade --- cmd/upgrade.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/upgrade.go b/cmd/upgrade.go index a2b338a..ba8216c 100644 --- a/cmd/upgrade.go +++ b/cmd/upgrade.go @@ -35,9 +35,9 @@ func upgradeRunE(cmd *cobra.Command, _ []string) error { } func upgrade(cmd *cobra.Command, cliLatestVersion string) { - upgrader := execCommand("go", "get", "-u", "-v", "github.com/gofiber/cli/fiber") + module := fmt.Sprintf("github.com/gofiber/cli/fiber@%s", cliLatestVersion) + upgrader := execCommand("go", "install", module) upgrader.Env = append(upgrader.Env, os.Environ()...) - upgrader.Env = append(upgrader.Env, "GO111MODULE=off") scmd := internal.NewSpinnerCmd(upgrader, "Upgrading") From 873d49691864e517f3e0f1c4b6a8262b1c5bbcc4 Mon Sep 17 00:00:00 2001 From: RW Date: Mon, 14 Jul 2025 09:40:10 +0200 Subject: [PATCH 2/3] Use string concatenation for module path --- cmd/upgrade.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/upgrade.go b/cmd/upgrade.go index ba8216c..5fe0990 100644 --- a/cmd/upgrade.go +++ b/cmd/upgrade.go @@ -35,7 +35,7 @@ func upgradeRunE(cmd *cobra.Command, _ []string) error { } func upgrade(cmd *cobra.Command, cliLatestVersion string) { - module := fmt.Sprintf("github.com/gofiber/cli/fiber@%s", cliLatestVersion) + module := "github.com/gofiber/cli/fiber@" + cliLatestVersion upgrader := execCommand("go", "install", module) upgrader.Env = append(upgrader.Env, os.Environ()...) From ac7b69488699fa67966197ce58901baa1064c4f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9?= Date: Mon, 14 Jul 2025 09:46:19 +0200 Subject: [PATCH 3/3] fix review hints --- cmd/upgrade.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/upgrade.go b/cmd/upgrade.go index 5fe0990..b377905 100644 --- a/cmd/upgrade.go +++ b/cmd/upgrade.go @@ -35,7 +35,7 @@ func upgradeRunE(cmd *cobra.Command, _ []string) error { } func upgrade(cmd *cobra.Command, cliLatestVersion string) { - module := "github.com/gofiber/cli/fiber@" + cliLatestVersion + module := "github.com/gofiber/cli/fiber@v" + cliLatestVersion upgrader := execCommand("go", "install", module) upgrader.Env = append(upgrader.Env, os.Environ()...)