From 9e84287ac0b860cb1e3dceedcbf19663921cfaee Mon Sep 17 00:00:00 2001 From: matt korwel Date: Tue, 10 Feb 2026 08:25:21 -0600 Subject: [PATCH 1/3] feat(routing): restrict numerical routing to Gemini 3 family (#18478) # Conflicts: # packages/core/src/routing/strategies/classifierStrategy.test.ts # packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts # packages/core/src/routing/strategies/numericalClassifierStrategy.ts --- packages/core/src/config/models.test.ts | 24 ++++++++ packages/core/src/config/models.ts | 11 ++++ .../strategies/classifierStrategy.test.ts | 26 ++++++++- .../routing/strategies/classifierStrategy.ts | 10 +++- .../numericalClassifierStrategy.test.ts | 56 +++++++++++++++---- .../strategies/numericalClassifierStrategy.ts | 11 +++- 6 files changed, 121 insertions(+), 17 deletions(-) diff --git a/packages/core/src/config/models.test.ts b/packages/core/src/config/models.test.ts index 8e6c3ea8954..73865accd2e 100644 --- a/packages/core/src/config/models.test.ts +++ b/packages/core/src/config/models.test.ts @@ -8,6 +8,7 @@ import { describe, it, expect } from 'vitest'; import { resolveModel, resolveClassifierModel, + isGemini3Model, isGemini2Model, isAutoModel, getDisplayString, @@ -25,6 +26,29 @@ import { DEFAULT_GEMINI_MODEL_AUTO, } from './models.js'; +describe('isGemini3Model', () => { + it('should return true for gemini-3 models', () => { + expect(isGemini3Model('gemini-3-pro-preview')).toBe(true); + expect(isGemini3Model('gemini-3-flash-preview')).toBe(true); + }); + + it('should return true for aliases that resolve to Gemini 3', () => { + expect(isGemini3Model(GEMINI_MODEL_ALIAS_AUTO)).toBe(true); + expect(isGemini3Model(GEMINI_MODEL_ALIAS_PRO)).toBe(true); + expect(isGemini3Model(PREVIEW_GEMINI_MODEL_AUTO)).toBe(true); + }); + + it('should return false for Gemini 2 models', () => { + expect(isGemini3Model('gemini-2.5-pro')).toBe(false); + expect(isGemini3Model('gemini-2.5-flash')).toBe(false); + expect(isGemini3Model(DEFAULT_GEMINI_MODEL_AUTO)).toBe(false); + }); + + it('should return false for arbitrary strings', () => { + expect(isGemini3Model('gpt-4')).toBe(false); + }); +}); + describe('getDisplayString', () => { it('should return Auto (Gemini 3) for preview auto model', () => { expect(getDisplayString(PREVIEW_GEMINI_MODEL_AUTO)).toBe('Auto (Gemini 3)'); diff --git a/packages/core/src/config/models.ts b/packages/core/src/config/models.ts index 519f49c98ec..24d747b9696 100644 --- a/packages/core/src/config/models.ts +++ b/packages/core/src/config/models.ts @@ -137,6 +137,17 @@ export function isPreviewModel(model: string): boolean { ); } +/** + * Checks if the model is a Gemini 3 model. + * + * @param model The model name to check. + * @returns True if the model is a Gemini 3 model. + */ +export function isGemini3Model(model: string): boolean { + const resolved = resolveModel(model); + return /^gemini-3(\.|-|$)/.test(resolved); +} + /** * Checks if the model is a Gemini 2.x model. * diff --git a/packages/core/src/routing/strategies/classifierStrategy.test.ts b/packages/core/src/routing/strategies/classifierStrategy.test.ts index ef0f784ee20..9b6c3e35d01 100644 --- a/packages/core/src/routing/strategies/classifierStrategy.test.ts +++ b/packages/core/src/routing/strategies/classifierStrategy.test.ts @@ -17,6 +17,7 @@ import { DEFAULT_GEMINI_FLASH_MODEL, DEFAULT_GEMINI_MODEL, DEFAULT_GEMINI_MODEL_AUTO, + PREVIEW_GEMINI_MODEL_AUTO, } from '../../config/models.js'; import { promptIdContext } from '../../utils/promptIdContext.js'; import type { Content } from '@google/genai'; @@ -50,8 +51,12 @@ describe('ClassifierStrategy', () => { modelConfigService: { getResolvedConfig: vi.fn().mockReturnValue(mockResolvedConfig), }, +<<<<<<< HEAD getModel: () => DEFAULT_GEMINI_MODEL_AUTO, getPreviewFeatures: () => false, +======= + getModel: vi.fn().mockReturnValue(DEFAULT_GEMINI_MODEL_AUTO), +>>>>>>> 37f128a10 (feat(routing): restrict numerical routing to Gemini 3 family (#18478)) getNumericalRoutingEnabled: vi.fn().mockResolvedValue(false), } as unknown as Config; mockBaseLlmClient = { @@ -61,8 +66,9 @@ describe('ClassifierStrategy', () => { vi.spyOn(promptIdContext, 'getStore').mockReturnValue('test-prompt-id'); }); - it('should return null if numerical routing is enabled', async () => { + it('should return null if numerical routing is enabled and model is Gemini 3', async () => { vi.mocked(mockConfig.getNumericalRoutingEnabled).mockResolvedValue(true); + vi.mocked(mockConfig.getModel).mockReturnValue(PREVIEW_GEMINI_MODEL_AUTO); const decision = await strategy.route( mockContext, @@ -74,6 +80,24 @@ describe('ClassifierStrategy', () => { expect(mockBaseLlmClient.generateJson).not.toHaveBeenCalled(); }); + it('should NOT return null if numerical routing is enabled but model is NOT Gemini 3', async () => { + vi.mocked(mockConfig.getNumericalRoutingEnabled).mockResolvedValue(true); + vi.mocked(mockConfig.getModel).mockReturnValue(DEFAULT_GEMINI_MODEL_AUTO); + vi.mocked(mockBaseLlmClient.generateJson).mockResolvedValue({ + reasoning: 'test', + model_choice: 'flash', + }); + + const decision = await strategy.route( + mockContext, + mockConfig, + mockBaseLlmClient, + ); + + expect(decision).not.toBeNull(); + expect(mockBaseLlmClient.generateJson).toHaveBeenCalled(); + }); + it('should call generateJson with the correct parameters', async () => { const mockApiResponse = { reasoning: 'Simple task', diff --git a/packages/core/src/routing/strategies/classifierStrategy.ts b/packages/core/src/routing/strategies/classifierStrategy.ts index 4edf85a3515..8396f4aceb1 100644 --- a/packages/core/src/routing/strategies/classifierStrategy.ts +++ b/packages/core/src/routing/strategies/classifierStrategy.ts @@ -12,7 +12,7 @@ import type { RoutingDecision, RoutingStrategy, } from '../routingStrategy.js'; -import { resolveClassifierModel } from '../../config/models.js'; +import { resolveClassifierModel, isGemini3Model } from '../../config/models.js'; import { createUserContent, Type } from '@google/genai'; import type { Config } from '../../config/config.js'; import { @@ -133,7 +133,11 @@ export class ClassifierStrategy implements RoutingStrategy { ): Promise { const startTime = Date.now(); try { - if (await config.getNumericalRoutingEnabled()) { + const model = context.requestedModel ?? config.getModel(); + if ( + (await config.getNumericalRoutingEnabled()) && + isGemini3Model(model) + ) { return null; } @@ -164,7 +168,7 @@ export class ClassifierStrategy implements RoutingStrategy { const reasoning = routerResponse.reasoning; const latencyMs = Date.now() - startTime; const selectedModel = resolveClassifierModel( - context.requestedModel ?? config.getModel(), + model, routerResponse.model_choice, config.getPreviewFeatures(), ); diff --git a/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts b/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts index 93e75fcdb5b..facae8a1863 100644 --- a/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts +++ b/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts @@ -10,9 +10,11 @@ import type { RoutingContext } from '../routingStrategy.js'; import type { Config } from '../../config/config.js'; import type { BaseLlmClient } from '../../core/baseLlmClient.js'; import { - DEFAULT_GEMINI_FLASH_MODEL, - DEFAULT_GEMINI_MODEL, + PREVIEW_GEMINI_FLASH_MODEL, + PREVIEW_GEMINI_MODEL, + PREVIEW_GEMINI_MODEL_AUTO, DEFAULT_GEMINI_MODEL_AUTO, + DEFAULT_GEMINI_MODEL, } from '../../config/models.js'; import { promptIdContext } from '../../utils/promptIdContext.js'; import type { Content } from '@google/genai'; @@ -46,8 +48,12 @@ describe('NumericalClassifierStrategy', () => { modelConfigService: { getResolvedConfig: vi.fn().mockReturnValue(mockResolvedConfig), }, +<<<<<<< HEAD getModel: () => DEFAULT_GEMINI_MODEL_AUTO, getPreviewFeatures: () => false, +======= + getModel: vi.fn().mockReturnValue(PREVIEW_GEMINI_MODEL_AUTO), +>>>>>>> 37f128a10 (feat(routing): restrict numerical routing to Gemini 3 family (#18478)) getSessionId: vi.fn().mockReturnValue('control-group-id'), // Default to Control Group (Hash 71 >= 50) getNumericalRoutingEnabled: vi.fn().mockResolvedValue(true), getClassifierThreshold: vi.fn().mockResolvedValue(undefined), @@ -76,6 +82,32 @@ describe('NumericalClassifierStrategy', () => { expect(mockBaseLlmClient.generateJson).not.toHaveBeenCalled(); }); + it('should return null if the model is not a Gemini 3 model', async () => { + vi.mocked(mockConfig.getModel).mockReturnValue(DEFAULT_GEMINI_MODEL_AUTO); + + const decision = await strategy.route( + mockContext, + mockConfig, + mockBaseLlmClient, + ); + + expect(decision).toBeNull(); + expect(mockBaseLlmClient.generateJson).not.toHaveBeenCalled(); + }); + + it('should return null if the model is explicitly a Gemini 2 model', async () => { + vi.mocked(mockConfig.getModel).mockReturnValue(DEFAULT_GEMINI_MODEL); + + const decision = await strategy.route( + mockContext, + mockConfig, + mockBaseLlmClient, + ); + + expect(decision).toBeNull(); + expect(mockBaseLlmClient.generateJson).not.toHaveBeenCalled(); + }); + it('should call generateJson with the correct parameters and wrapped user content', async () => { const mockApiResponse = { complexity_reasoning: 'Simple task', @@ -120,7 +152,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_FLASH_MODEL, + model: PREVIEW_GEMINI_FLASH_MODEL, metadata: { source: 'NumericalClassifier (Control)', latencyMs: expect.any(Number), @@ -146,7 +178,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_MODEL, + model: PREVIEW_GEMINI_MODEL, metadata: { source: 'NumericalClassifier (Control)', latencyMs: expect.any(Number), @@ -172,7 +204,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_FLASH_MODEL, // Routed to Flash because 60 < 80 + model: PREVIEW_GEMINI_FLASH_MODEL, // Routed to Flash because 60 < 80 metadata: { source: 'NumericalClassifier (Strict)', latencyMs: expect.any(Number), @@ -198,7 +230,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_MODEL, + model: PREVIEW_GEMINI_MODEL, metadata: { source: 'NumericalClassifier (Strict)', latencyMs: expect.any(Number), @@ -226,7 +258,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_FLASH_MODEL, // Score 60 < Threshold 70 + model: PREVIEW_GEMINI_FLASH_MODEL, // Score 60 < Threshold 70 metadata: { source: 'NumericalClassifier (Remote)', latencyMs: expect.any(Number), @@ -252,7 +284,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_FLASH_MODEL, // Score 40 < Threshold 45.5 + model: PREVIEW_GEMINI_FLASH_MODEL, // Score 40 < Threshold 45.5 metadata: { source: 'NumericalClassifier (Remote)', latencyMs: expect.any(Number), @@ -278,7 +310,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_MODEL, // Score 35 >= Threshold 30 + model: PREVIEW_GEMINI_MODEL, // Score 35 >= Threshold 30 metadata: { source: 'NumericalClassifier (Remote)', latencyMs: expect.any(Number), @@ -306,7 +338,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_FLASH_MODEL, // Score 40 < Default A/B Threshold 50 + model: PREVIEW_GEMINI_FLASH_MODEL, // Score 40 < Default A/B Threshold 50 metadata: { source: 'NumericalClassifier (Control)', latencyMs: expect.any(Number), @@ -333,7 +365,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_FLASH_MODEL, + model: PREVIEW_GEMINI_FLASH_MODEL, metadata: { source: 'NumericalClassifier (Control)', latencyMs: expect.any(Number), @@ -360,7 +392,7 @@ describe('NumericalClassifierStrategy', () => { ); expect(decision).toEqual({ - model: DEFAULT_GEMINI_MODEL, + model: PREVIEW_GEMINI_MODEL, metadata: { source: 'NumericalClassifier (Control)', latencyMs: expect.any(Number), diff --git a/packages/core/src/routing/strategies/numericalClassifierStrategy.ts b/packages/core/src/routing/strategies/numericalClassifierStrategy.ts index 9bcaebf4321..9964e06dea4 100644 --- a/packages/core/src/routing/strategies/numericalClassifierStrategy.ts +++ b/packages/core/src/routing/strategies/numericalClassifierStrategy.ts @@ -12,7 +12,7 @@ import type { RoutingDecision, RoutingStrategy, } from '../routingStrategy.js'; -import { resolveClassifierModel } from '../../config/models.js'; +import { resolveClassifierModel, isGemini3Model } from '../../config/models.js'; import { createUserContent, Type } from '@google/genai'; import type { Config } from '../../config/config.js'; import { debugLogger } from '../../utils/debugLogger.js'; @@ -134,10 +134,15 @@ export class NumericalClassifierStrategy implements RoutingStrategy { ): Promise { const startTime = Date.now(); try { + const model = context.requestedModel ?? config.getModel(); if (!(await config.getNumericalRoutingEnabled())) { return null; } + if (!isGemini3Model(model)) { + return null; + } + const promptId = getPromptIdWithFallback('classifier-router'); const finalHistory = context.history.slice(-HISTORY_TURNS_FOR_CONTEXT); @@ -176,11 +181,15 @@ export class NumericalClassifierStrategy implements RoutingStrategy { config.getSessionId() || 'unknown-session', ); +<<<<<<< HEAD const selectedModel = resolveClassifierModel( config.getModel(), modelAlias, config.getPreviewFeatures(), ); +======= + const selectedModel = resolveClassifierModel(model, modelAlias); +>>>>>>> 37f128a10 (feat(routing): restrict numerical routing to Gemini 3 family (#18478)) const latencyMs = Date.now() - startTime; From b80951bc7e9c1bcb79e73f38829c6e9090c9eb9b Mon Sep 17 00:00:00 2001 From: mkorwel Date: Tue, 10 Feb 2026 10:29:05 -0600 Subject: [PATCH 2/3] fixing merge conflicts --- packages/core/src/config/models.test.ts | 6 +++--- packages/core/src/config/models.ts | 7 +++++-- .../src/routing/strategies/classifierStrategy.test.ts | 4 ---- .../core/src/routing/strategies/classifierStrategy.ts | 2 +- .../strategies/numericalClassifierStrategy.test.ts | 5 ----- .../src/routing/strategies/numericalClassifierStrategy.ts | 8 ++------ 6 files changed, 11 insertions(+), 21 deletions(-) diff --git a/packages/core/src/config/models.test.ts b/packages/core/src/config/models.test.ts index 73865accd2e..fd47d2a1ff3 100644 --- a/packages/core/src/config/models.test.ts +++ b/packages/core/src/config/models.test.ts @@ -32,9 +32,9 @@ describe('isGemini3Model', () => { expect(isGemini3Model('gemini-3-flash-preview')).toBe(true); }); - it('should return true for aliases that resolve to Gemini 3', () => { - expect(isGemini3Model(GEMINI_MODEL_ALIAS_AUTO)).toBe(true); - expect(isGemini3Model(GEMINI_MODEL_ALIAS_PRO)).toBe(true); + it('should return true for aliases that resolve to Gemini 3 when preview is enabled', () => { + expect(isGemini3Model(GEMINI_MODEL_ALIAS_AUTO, true)).toBe(true); + expect(isGemini3Model(GEMINI_MODEL_ALIAS_PRO, true)).toBe(true); expect(isGemini3Model(PREVIEW_GEMINI_MODEL_AUTO)).toBe(true); }); diff --git a/packages/core/src/config/models.ts b/packages/core/src/config/models.ts index 24d747b9696..9406fc41310 100644 --- a/packages/core/src/config/models.ts +++ b/packages/core/src/config/models.ts @@ -143,8 +143,11 @@ export function isPreviewModel(model: string): boolean { * @param model The model name to check. * @returns True if the model is a Gemini 3 model. */ -export function isGemini3Model(model: string): boolean { - const resolved = resolveModel(model); +export function isGemini3Model( + model: string, + previewFeaturesEnabled = false, +): boolean { + const resolved = resolveModel(model, previewFeaturesEnabled); return /^gemini-3(\.|-|$)/.test(resolved); } diff --git a/packages/core/src/routing/strategies/classifierStrategy.test.ts b/packages/core/src/routing/strategies/classifierStrategy.test.ts index 9b6c3e35d01..2efe953153f 100644 --- a/packages/core/src/routing/strategies/classifierStrategy.test.ts +++ b/packages/core/src/routing/strategies/classifierStrategy.test.ts @@ -51,12 +51,8 @@ describe('ClassifierStrategy', () => { modelConfigService: { getResolvedConfig: vi.fn().mockReturnValue(mockResolvedConfig), }, -<<<<<<< HEAD getModel: () => DEFAULT_GEMINI_MODEL_AUTO, getPreviewFeatures: () => false, -======= - getModel: vi.fn().mockReturnValue(DEFAULT_GEMINI_MODEL_AUTO), ->>>>>>> 37f128a10 (feat(routing): restrict numerical routing to Gemini 3 family (#18478)) getNumericalRoutingEnabled: vi.fn().mockResolvedValue(false), } as unknown as Config; mockBaseLlmClient = { diff --git a/packages/core/src/routing/strategies/classifierStrategy.ts b/packages/core/src/routing/strategies/classifierStrategy.ts index 8396f4aceb1..73a1d841651 100644 --- a/packages/core/src/routing/strategies/classifierStrategy.ts +++ b/packages/core/src/routing/strategies/classifierStrategy.ts @@ -136,7 +136,7 @@ export class ClassifierStrategy implements RoutingStrategy { const model = context.requestedModel ?? config.getModel(); if ( (await config.getNumericalRoutingEnabled()) && - isGemini3Model(model) + isGemini3Model(model, config.getPreviewFeatures()) ) { return null; } diff --git a/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts b/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts index facae8a1863..661afafa41f 100644 --- a/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts +++ b/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts @@ -12,7 +12,6 @@ import type { BaseLlmClient } from '../../core/baseLlmClient.js'; import { PREVIEW_GEMINI_FLASH_MODEL, PREVIEW_GEMINI_MODEL, - PREVIEW_GEMINI_MODEL_AUTO, DEFAULT_GEMINI_MODEL_AUTO, DEFAULT_GEMINI_MODEL, } from '../../config/models.js'; @@ -48,12 +47,8 @@ describe('NumericalClassifierStrategy', () => { modelConfigService: { getResolvedConfig: vi.fn().mockReturnValue(mockResolvedConfig), }, -<<<<<<< HEAD getModel: () => DEFAULT_GEMINI_MODEL_AUTO, getPreviewFeatures: () => false, -======= - getModel: vi.fn().mockReturnValue(PREVIEW_GEMINI_MODEL_AUTO), ->>>>>>> 37f128a10 (feat(routing): restrict numerical routing to Gemini 3 family (#18478)) getSessionId: vi.fn().mockReturnValue('control-group-id'), // Default to Control Group (Hash 71 >= 50) getNumericalRoutingEnabled: vi.fn().mockResolvedValue(true), getClassifierThreshold: vi.fn().mockResolvedValue(undefined), diff --git a/packages/core/src/routing/strategies/numericalClassifierStrategy.ts b/packages/core/src/routing/strategies/numericalClassifierStrategy.ts index 9964e06dea4..13428d02d9d 100644 --- a/packages/core/src/routing/strategies/numericalClassifierStrategy.ts +++ b/packages/core/src/routing/strategies/numericalClassifierStrategy.ts @@ -139,7 +139,7 @@ export class NumericalClassifierStrategy implements RoutingStrategy { return null; } - if (!isGemini3Model(model)) { + if (!isGemini3Model(model, config.getPreviewFeatures())) { return null; } @@ -181,15 +181,11 @@ export class NumericalClassifierStrategy implements RoutingStrategy { config.getSessionId() || 'unknown-session', ); -<<<<<<< HEAD const selectedModel = resolveClassifierModel( - config.getModel(), + model, modelAlias, config.getPreviewFeatures(), ); -======= - const selectedModel = resolveClassifierModel(model, modelAlias); ->>>>>>> 37f128a10 (feat(routing): restrict numerical routing to Gemini 3 family (#18478)) const latencyMs = Date.now() - startTime; From c20dc222cc19749ef191a6ee6bf946770abfb5df Mon Sep 17 00:00:00 2001 From: mkorwel Date: Tue, 10 Feb 2026 10:42:38 -0600 Subject: [PATCH 3/3] fix(core): Correctly mock Config methods in classifier strategy tests and fix model resolution. --- .../core/src/routing/strategies/classifierStrategy.test.ts | 4 ++-- .../routing/strategies/numericalClassifierStrategy.test.ts | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/core/src/routing/strategies/classifierStrategy.test.ts b/packages/core/src/routing/strategies/classifierStrategy.test.ts index 2efe953153f..77bd3c40b82 100644 --- a/packages/core/src/routing/strategies/classifierStrategy.test.ts +++ b/packages/core/src/routing/strategies/classifierStrategy.test.ts @@ -51,8 +51,8 @@ describe('ClassifierStrategy', () => { modelConfigService: { getResolvedConfig: vi.fn().mockReturnValue(mockResolvedConfig), }, - getModel: () => DEFAULT_GEMINI_MODEL_AUTO, - getPreviewFeatures: () => false, + getModel: vi.fn().mockReturnValue(DEFAULT_GEMINI_MODEL_AUTO), + getPreviewFeatures: vi.fn().mockReturnValue(false), getNumericalRoutingEnabled: vi.fn().mockResolvedValue(false), } as unknown as Config; mockBaseLlmClient = { diff --git a/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts b/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts index 661afafa41f..a5a7a2bc352 100644 --- a/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts +++ b/packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts @@ -14,6 +14,7 @@ import { PREVIEW_GEMINI_MODEL, DEFAULT_GEMINI_MODEL_AUTO, DEFAULT_GEMINI_MODEL, + PREVIEW_GEMINI_MODEL_AUTO, } from '../../config/models.js'; import { promptIdContext } from '../../utils/promptIdContext.js'; import type { Content } from '@google/genai'; @@ -47,8 +48,8 @@ describe('NumericalClassifierStrategy', () => { modelConfigService: { getResolvedConfig: vi.fn().mockReturnValue(mockResolvedConfig), }, - getModel: () => DEFAULT_GEMINI_MODEL_AUTO, - getPreviewFeatures: () => false, + getModel: vi.fn().mockReturnValue(PREVIEW_GEMINI_MODEL_AUTO), + getPreviewFeatures: vi.fn().mockReturnValue(false), getSessionId: vi.fn().mockReturnValue('control-group-id'), // Default to Control Group (Hash 71 >= 50) getNumericalRoutingEnabled: vi.fn().mockResolvedValue(true), getClassifierThreshold: vi.fn().mockResolvedValue(undefined),