From 3ff2992e4d35734045834ca7275cdae2d3d52440 Mon Sep 17 00:00:00 2001 From: Taylor Mullen Date: Thu, 12 Feb 2026 23:46:55 -0800 Subject: [PATCH] fix(core): ensure --yolo does not force headless mode - Fix regression introduced in #18855 where YOLO mode flags were incorrectly identified as headless mode indicators. - Update headless mode tests to verify that --yolo remains interactive in a TTY environment. --- packages/core/src/utils/headless.test.ts | 6 +++--- packages/core/src/utils/headless.ts | 7 ++----- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/core/src/utils/headless.test.ts b/packages/core/src/utils/headless.test.ts index 4708c79969d..3350b75a304 100644 --- a/packages/core/src/utils/headless.test.ts +++ b/packages/core/src/utils/headless.test.ts @@ -120,18 +120,18 @@ describe('isHeadlessMode', () => { } }); - it('should return true if -y or --yolo is in process.argv as a fallback', () => { + it('should return false if -y or --yolo is in process.argv as a fallback', () => { const originalArgv = process.argv; process.argv = ['node', 'index.js', '-y']; try { - expect(isHeadlessMode()).toBe(true); + expect(isHeadlessMode()).toBe(false); } finally { process.argv = originalArgv; } process.argv = ['node', 'index.js', '--yolo']; try { - expect(isHeadlessMode()).toBe(true); + expect(isHeadlessMode()).toBe(false); } finally { process.argv = originalArgv; } diff --git a/packages/core/src/utils/headless.ts b/packages/core/src/utils/headless.ts index 5a46b90d6d4..eca7ce68141 100644 --- a/packages/core/src/utils/headless.ts +++ b/packages/core/src/utils/headless.ts @@ -44,9 +44,6 @@ export function isHeadlessMode(options?: HeadlessModeOptions): boolean { return true; } - // Fallback: check process.argv for flags that imply headless or auto-approve mode. - return process.argv.some( - (arg) => - arg === '-p' || arg === '--prompt' || arg === '-y' || arg === '--yolo', - ); + // Fallback: check process.argv for flags that imply headless mode. + return process.argv.some((arg) => arg === '-p' || arg === '--prompt'); }