From 936f638128bfe43d15c66ac0023d466dbd2dcae5 Mon Sep 17 00:00:00 2001 From: Matthew Mathias Date: Thu, 2 Nov 2023 16:38:30 -0700 Subject: [PATCH] Increase the max animation delay for App Check While we ask that developers pre-warm their apps to use App Check (i.e., generate the key and attestation object), we will still need to generate the assertion and execute a round trip with the backend to get the token sent with the sign in request. Testing on a real device shows that this averages somewhere within the range of approximate 0.6s to 1.0s. --- GoogleSignIn/Sources/GIDTimedLoader/GIDTimedLoader.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GoogleSignIn/Sources/GIDTimedLoader/GIDTimedLoader.m b/GoogleSignIn/Sources/GIDTimedLoader/GIDTimedLoader.m index 02bad80d..28bab351 100644 --- a/GoogleSignIn/Sources/GIDTimedLoader/GIDTimedLoader.m +++ b/GoogleSignIn/Sources/GIDTimedLoader/GIDTimedLoader.m @@ -24,7 +24,7 @@ #import "GoogleSignIn/Sources/GIDAppCheck/UI/GIDActivityIndicatorViewController.h" CFTimeInterval const kGIDTimedLoaderMinAnimationDuration = 1.0; -CFTimeInterval const kGIDTimedLoaderMaxDelayBeforeAnimating = 0.5; +CFTimeInterval const kGIDTimedLoaderMaxDelayBeforeAnimating = 0.8; @interface GIDTimedLoader ()