From 50c447238ad6dc4e786ed9c10517054b8387d94a Mon Sep 17 00:00:00 2001 From: Matthew Mathias Date: Tue, 14 Nov 2023 12:51:23 -0800 Subject: [PATCH 1/4] Update AppCheckCore dependency to 10.18 --- GoogleSignIn.podspec | 2 +- Package.swift | 2 +- Samples/Swift/AppAttestExample/Podfile | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/GoogleSignIn.podspec b/GoogleSignIn.podspec index 3f1c9488..94e5b7eb 100644 --- a/GoogleSignIn.podspec +++ b/GoogleSignIn.podspec @@ -33,7 +33,7 @@ The Google Sign-In SDK allows users to sign in with their Google account from th ] s.ios.framework = 'UIKit' s.osx.framework = 'AppKit' - s.dependency 'AppCheckCore', '~> 0.1.0-alpha.9' + s.dependency 'AppCheckCore', '~> 10.18' s.dependency 'AppAuth', '~> 1.6' s.dependency 'GTMAppAuth', '~> 4.0' s.dependency 'GTMSessionFetcher/Core', '>= 1.1', '< 4.0' diff --git a/Package.swift b/Package.swift index 827ffde3..43b0a588 100644 --- a/Package.swift +++ b/Package.swift @@ -48,7 +48,7 @@ let package = Package( .package( name: "AppCheck", url: "https://github.com/google/app-check.git", - .branch("CocoaPods-0.1.0-alpha.9")), + "10.18 ..< "11.0.0"), .package( name: "GTMAppAuth", url: "https://github.com/google/GTMAppAuth.git", diff --git a/Samples/Swift/AppAttestExample/Podfile b/Samples/Swift/AppAttestExample/Podfile index 2805b5c8..ebd1d406 100644 --- a/Samples/Swift/AppAttestExample/Podfile +++ b/Samples/Swift/AppAttestExample/Podfile @@ -1,5 +1,4 @@ source 'https://github.com/CocoaPods/Specs.git' -source 'https://github.com/firebase/SpecsDev.git' pod 'GoogleSignIn', :path => '../../../', :testspecs => ['unit'] pod 'GoogleSignInSwiftSupport', :path => '../../../', :testspecs => ['unit'] From b56e03459f57ade441016e98eef9459ebc6562a0 Mon Sep 17 00:00:00 2001 From: Matthew Mathias Date: Tue, 14 Nov 2023 13:03:53 -0800 Subject: [PATCH 2/4] Add missing quotation mark --- Package.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Package.swift b/Package.swift index 43b0a588..9a2fe2e5 100644 --- a/Package.swift +++ b/Package.swift @@ -48,7 +48,7 @@ let package = Package( .package( name: "AppCheck", url: "https://github.com/google/app-check.git", - "10.18 ..< "11.0.0"), + "10.18" ..< "11.0.0"), .package( name: "GTMAppAuth", url: "https://github.com/google/GTMAppAuth.git", From 486462da189f39b9106363d6b4b7522555258e56 Mon Sep 17 00:00:00 2001 From: Matthew Mathias Date: Tue, 14 Nov 2023 13:06:31 -0800 Subject: [PATCH 3/4] Add patch version number to AppCheckCore dep --- Package.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Package.swift b/Package.swift index 9a2fe2e5..192c21d4 100644 --- a/Package.swift +++ b/Package.swift @@ -48,7 +48,7 @@ let package = Package( .package( name: "AppCheck", url: "https://github.com/google/app-check.git", - "10.18" ..< "11.0.0"), + "10.18.0" ..< "11.0.0"), .package( name: "GTMAppAuth", url: "https://github.com/google/GTMAppAuth.git", From eaa9f17721e9aa86ccac5c8e5c5ad163fde7b31b Mon Sep 17 00:00:00 2001 From: Matthew Mathias Date: Tue, 14 Nov 2023 15:36:00 -0800 Subject: [PATCH 4/4] Remove Firebase spec repo from pod lib lint sources --- .github/workflows/unit_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index f7cddc21..ddeaf844 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -32,7 +32,7 @@ jobs: - name: Lint podspec using local source run: | pod lib lint ${{ matrix.podspec }} --verbose \ - --sources=https://github.com/firebase/SpecsDev.git,https://cdn.cocoapods.org/ \ + --sources=https://cdn.cocoapods.org/ \ ${{ matrix.includePodspecFlag }} ${{ matrix.flag }} spm-build-test: