From 3cb790a2564d5e3b12dffe6382a40b19261450ec Mon Sep 17 00:00:00 2001 From: Avi Schwab Date: Mon, 2 Oct 2023 15:50:17 -0500 Subject: [PATCH 1/3] Make links underlined by default As per the change upstream in Bootstrap 5 https://github.com/twbs/bootstrap/pull/30389 --- assets/scss/_variables.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/scss/_variables.scss b/assets/scss/_variables.scss index 5fdd86c76e..496b31cc44 100644 --- a/assets/scss/_variables.scss +++ b/assets/scss/_variables.scss @@ -35,7 +35,7 @@ $td-box-colors: $dark, $primary, $secondary, $info, $white, $gray-600, $success, $warning, $dark, $danger, $primary, $secondary, $info !default; $link-color: $blue-500 !default; -$link-decoration: none !default; +$link-decoration: underline !default; $link-shade-percentage: 30% !default; // Fonts From 9c0a5fb80b771365da3c1b9269df303cdbebff33 Mon Sep 17 00:00:00 2001 From: Avi Schwab Date: Mon, 2 Oct 2023 16:16:11 -0500 Subject: [PATCH 2/3] Keep the menus clean and ensure there is a non-color designator on focus --- assets/scss/_sidebar-toc.scss | 14 +++++++++++++- assets/scss/_sidebar-tree.scss | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/assets/scss/_sidebar-toc.scss b/assets/scss/_sidebar-toc.scss index 249ec25f39..693bfb6d8f 100644 --- a/assets/scss/_sidebar-toc.scss +++ b/assets/scss/_sidebar-toc.scss @@ -50,7 +50,6 @@ &:hover { color: $blue; - text-decoration: none; } } } @@ -59,3 +58,16 @@ padding-left: 0; } } + +.td-page-meta, +.td-sidebar-toc, +.td-toc { + a { + text-decoration: none; + + &:hover, + &:focus { + text-decoration: underline; + } + } +} \ No newline at end of file diff --git a/assets/scss/_sidebar-tree.scss b/assets/scss/_sidebar-tree.scss index 50beb4e119..3cb6bc16d1 100644 --- a/assets/scss/_sidebar-tree.scss +++ b/assets/scss/_sidebar-tree.scss @@ -63,6 +63,7 @@ a { color: $gray-900; + text-decoration: none; } } @@ -79,7 +80,7 @@ a { &:hover { color: $blue; - text-decoration: none; + text-decoration: underline; } &.active { From 2b3b067561d6dcf251835897c0c673f06a5da83b Mon Sep 17 00:00:00 2001 From: Avi Schwab Date: Mon, 2 Oct 2023 16:23:32 -0500 Subject: [PATCH 3/3] Ensure hover and focus work the same in both sidebars --- assets/scss/_sidebar-tree.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/assets/scss/_sidebar-tree.scss b/assets/scss/_sidebar-tree.scss index 3cb6bc16d1..1cdde0d493 100644 --- a/assets/scss/_sidebar-tree.scss +++ b/assets/scss/_sidebar-tree.scss @@ -78,7 +78,8 @@ } a { - &:hover { + &:hover, + &:focus { color: $blue; text-decoration: underline; }