From fa30a07caf75a5a8354e93221f82d5701f991d4a Mon Sep 17 00:00:00 2001 From: k1rnt Date: Wed, 12 Oct 2022 22:24:59 +0900 Subject: [PATCH 01/11] Fix use GITHUB_OUTPUT from deprecated set-output --- .github/workflows/tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f392c707082..f17b1af130c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -48,8 +48,8 @@ jobs: # Get values for cache paths to be used in later steps - id: cache-paths run: | - echo "::set-output name=go-cache::$(go env GOCACHE)" - echo "::set-output name=go-mod-cache::$(go env GOMODCACHE)" + echo "go-cache=$(go env GOCACHE) >> $GITHUB_OUTPUT" + echo "go-mod-cache=$(go env GOMODCACHE) >> $GITHUB_OUTPUT" - name: Cache go modules uses: actions/cache@v3 From 74104a6f1b44c14301bfcfd863c6dcb7e84db683 Mon Sep 17 00:00:00 2001 From: k1rnt Date: Wed, 12 Oct 2022 23:00:37 +0900 Subject: [PATCH 02/11] Update .github/workflows/tests.yml Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com> --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f17b1af130c..847b46652b9 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -48,7 +48,7 @@ jobs: # Get values for cache paths to be used in later steps - id: cache-paths run: | - echo "go-cache=$(go env GOCACHE) >> $GITHUB_OUTPUT" + echo "go-cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT echo "go-mod-cache=$(go env GOMODCACHE) >> $GITHUB_OUTPUT" - name: Cache go modules From 1bd0b4be48e28d53840617dde38f22d8e306f9da Mon Sep 17 00:00:00 2001 From: k1rnt Date: Wed, 12 Oct 2022 23:00:43 +0900 Subject: [PATCH 03/11] Update .github/workflows/tests.yml Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com> --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 847b46652b9..7fdd2d9473c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -49,7 +49,7 @@ jobs: - id: cache-paths run: | echo "go-cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT - echo "go-mod-cache=$(go env GOMODCACHE) >> $GITHUB_OUTPUT" + echo "go-mod-cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT - name: Cache go modules uses: actions/cache@v3 From 4ae3f584d99aad6549e62884d206111b886a0e9a Mon Sep 17 00:00:00 2001 From: k1rnt Date: Thu, 13 Oct 2022 00:12:20 +0900 Subject: [PATCH 04/11] upgrade actions/cache --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 7fdd2d9473c..f82d87f4d27 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -52,7 +52,7 @@ jobs: echo "go-mod-cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT - name: Cache go modules - uses: actions/cache@v3 + uses: actions/cache@v3.0.10 with: path: | ${{ steps.cache-paths.outputs.go-cache }} From a14f33a62f97f6ffbd8f15a52cba29c19209279c Mon Sep 17 00:00:00 2001 From: k1rnt Date: Thu, 13 Oct 2022 00:28:58 +0900 Subject: [PATCH 05/11] revert actions/cache version --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f82d87f4d27..7fdd2d9473c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -52,7 +52,7 @@ jobs: echo "go-mod-cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT - name: Cache go modules - uses: actions/cache@v3.0.10 + uses: actions/cache@v3 with: path: | ${{ steps.cache-paths.outputs.go-cache }} From 7cd8d3c4fa73fe4421d9c1b5c8ea04f651bd790b Mon Sep 17 00:00:00 2001 From: k1rnt Date: Thu, 13 Oct 2022 00:29:47 +0900 Subject: [PATCH 06/11] fix $Env:GITHUB_OUTPUT --- .github/workflows/tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 7fdd2d9473c..3bca58fc10b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -48,8 +48,8 @@ jobs: # Get values for cache paths to be used in later steps - id: cache-paths run: | - echo "go-cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT - echo "go-mod-cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT + echo "go-cache=$(go env GOCACHE)" >> $Env:GITHUB_OUTPUT + echo "go-mod-cache=$(go env GOMODCACHE)" >> $Env:GITHUB_OUTPUT - name: Cache go modules uses: actions/cache@v3 From 01811b306f63ce933da71f97d79ddb80eaa3bf95 Mon Sep 17 00:00:00 2001 From: k1rnt Date: Thu, 13 Oct 2022 00:52:20 +0900 Subject: [PATCH 07/11] Another approach --- .github/workflows/tests.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 3bca58fc10b..d0517185978 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -48,15 +48,15 @@ jobs: # Get values for cache paths to be used in later steps - id: cache-paths run: | - echo "go-cache=$(go env GOCACHE)" >> $Env:GITHUB_OUTPUT - echo "go-mod-cache=$(go env GOMODCACHE)" >> $Env:GITHUB_OUTPUT + echo "GOCACHE=$(go env GOCACHE)" >> $GITHUB_ENV + echo "GOMODCACHE=$(go env GOMODCACHE)" >> $GITHUB_ENV - name: Cache go modules uses: actions/cache@v3 with: path: | - ${{ steps.cache-paths.outputs.go-cache }} - ${{ steps.cache-paths.outputs.go-mod-cache }} + ${{ env.GOCACHE }} + ${{ env.GOMODCACHE }} key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} restore-keys: ${{ runner.os }}-go- From 0967d5e815859e14f6518e32720a0244305dd8ee Mon Sep 17 00:00:00 2001 From: k1rnt Date: Thu, 13 Oct 2022 01:19:13 +0900 Subject: [PATCH 08/11] ref community/discussions/26380 --- .github/workflows/tests.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d0517185978..3fae3982618 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -48,15 +48,15 @@ jobs: # Get values for cache paths to be used in later steps - id: cache-paths run: | - echo "GOCACHE=$(go env GOCACHE)" >> $GITHUB_ENV - echo "GOMODCACHE=$(go env GOMODCACHE)" >> $GITHUB_ENV + echo "go-cache=$(go env GOCACHE)" | Out-File -FilePath $GITHUB_OUTPUT -Encoding utf8 -Append + echo "go-mod-cache=$(go env GOMODCACHE)" | Out-File -FilePath $GITHUB_OUTPUT -Encoding utf8 -Append - name: Cache go modules uses: actions/cache@v3 with: path: | - ${{ env.GOCACHE }} - ${{ env.GOMODCACHE }} + ${{ steps.cache-paths.outputs.go-cache }} + ${{ steps.cache-paths.outputs.go-mod-cache }} key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} restore-keys: ${{ runner.os }}-go- From 00159de6f1e226c91596e1fd741c7b5bc6879821 Mon Sep 17 00:00:00 2001 From: k1rnt Date: Thu, 13 Oct 2022 01:30:06 +0900 Subject: [PATCH 09/11] check RUNNER_OS --- .github/workflows/tests.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 3fae3982618..47b14df08f1 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -48,8 +48,13 @@ jobs: # Get values for cache paths to be used in later steps - id: cache-paths run: | - echo "go-cache=$(go env GOCACHE)" | Out-File -FilePath $GITHUB_OUTPUT -Encoding utf8 -Append - echo "go-mod-cache=$(go env GOMODCACHE)" | Out-File -FilePath $GITHUB_OUTPUT -Encoding utf8 -Append + if [ "$RUNNER_OS" == "Windows" ]; then + echo "go-cache=$(go env GOCACHE)" | Out-File -FilePath $GITHUB_OUTPUT -Encoding utf8 -Append + echo "go-mod-cache=$(go env GOMODCACHE)" | Out-File -FilePath $GITHUB_OUTPUT -Encoding utf8 -Append + else + echo "go-cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT + echo "go-mod-cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT + fi - name: Cache go modules uses: actions/cache@v3 From d23bb2e205474e8734dd10e954f2e325f25bf7a7 Mon Sep 17 00:00:00 2001 From: k1rnt Date: Thu, 13 Oct 2022 01:41:49 +0900 Subject: [PATCH 10/11] set shell --- .github/workflows/tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 47b14df08f1..4396272357d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -55,6 +55,7 @@ jobs: echo "go-cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT echo "go-mod-cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT fi + shell: bash - name: Cache go modules uses: actions/cache@v3 From 7c3ba78694948553f1672928348fb50f5b6bf67a Mon Sep 17 00:00:00 2001 From: k1rnt Date: Thu, 13 Oct 2022 01:46:05 +0900 Subject: [PATCH 11/11] chore: set shell only --- .github/workflows/tests.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 4396272357d..f08c217a43b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -48,13 +48,8 @@ jobs: # Get values for cache paths to be used in later steps - id: cache-paths run: | - if [ "$RUNNER_OS" == "Windows" ]; then - echo "go-cache=$(go env GOCACHE)" | Out-File -FilePath $GITHUB_OUTPUT -Encoding utf8 -Append - echo "go-mod-cache=$(go env GOMODCACHE)" | Out-File -FilePath $GITHUB_OUTPUT -Encoding utf8 -Append - else - echo "go-cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT - echo "go-mod-cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT - fi + echo "go-cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT + echo "go-mod-cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT shell: bash - name: Cache go modules