Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Turn on monitor integration tests#1423

Merged
gdbelvin merged 11 commits intogoogle:masterfrom
gdbelvin:monitor
Jan 3, 2020
Merged

Turn on monitor integration tests#1423
gdbelvin merged 11 commits intogoogle:masterfrom
gdbelvin:monitor

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Jan 3, 2020

Assert that the monitor container comes up successfully in the integration tests.

Previously the monitor would fail on startup if a gRPC request to the server failed. Now the monitor will retry the command for up to 1 minute.

@gdbelvin gdbelvin requested a review from a team as a code owner January 3, 2020 16:26
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7d7c9cc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1423   +/-   ##
=========================================
  Coverage          ?   66.39%           
=========================================
  Files             ?       54           
  Lines             ?     4026           
  Branches          ?        0           
=========================================
  Hits              ?     2673           
  Misses            ?      960           
  Partials          ?      393

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d7c9cc...02574f2. Read the comment docs.

@gdbelvin gdbelvin requested a review from NatalieDoduc January 3, 2020 17:52
@gdbelvin gdbelvin merged commit 5c733f7 into google:master Jan 3, 2020
@gdbelvin gdbelvin deleted the monitor branch January 3, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments