Copy backoff module from Trillian#1424
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
- Coverage 66.33% 66.31% -0.02%
==========================================
Files 53 54 +1
Lines 3986 4026 +40
==========================================
+ Hits 2644 2670 +26
- Misses 952 962 +10
- Partials 390 394 +4
Continue to review full report at Codecov.
|
pav-kv
left a comment
There was a problem hiding this comment.
LGTM % file location and spelling warning.
* master: Copy backoff module from Trillian (google#1424)
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Package backoff allows retrying an operation with backoff. |
There was a problem hiding this comment.
Is there any way of denoting that this is a copy of code that is shared in Trillian (and vice versa)? I notelic lid your copy vs dependency proverb, but the potential to divergence in both flavours is worrisome.
While here - was there not a public backoff or retry library that was suitable?
There was a problem hiding this comment.
Divergence is less of a risk here because we can fully test it in this project without worrying about breaking other projects. Perhaps I'm missing something though.
grpc-go has a backoff library but it is also inside an internal directory.
A little copying is better than a little dependency