Conversation
Codecov Report
@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
+ Coverage 66.31% 66.41% +0.09%
==========================================
Files 54 54
Lines 4026 4026
==========================================
+ Hits 2670 2674 +4
+ Misses 962 960 -2
+ Partials 394 392 -2
Continue to review full report at Codecov.
|
NatalieDoduc
left a comment
NatalieDoduc
left a comment
There was a problem hiding this comment.
Cleanup is always good. Please see some questions I have about the nature of the changes, though. Thanks!
| apiVersion: v1 | ||
| kind: Pod | ||
| metadata: | ||
| creationTimestamp: null |
There was a problem hiding this comment.
what did this do? can you also add a mention about creationTimestamp in the PR description?
There was a problem hiding this comment.
I don't know what this does, but from what I read in the k8 documentation, empty and default fields in the configs do no need be be specified.
There was a problem hiding this comment.
Could you amend the PR description to mention this change as well?
| kind: Deployment | ||
| metadata: | ||
| annotations: | ||
| kompose.cmd: kompose convert --file ../../docker-compose.yml |
There was a problem hiding this comment.
I'm guessing this was added as a hint to how the .yaml file was created? If that's the case, it seems mildly useful to keep (if possibly outdated, from the looks of the path) Maybe add this information as part of ./deploy/kubernetes/README.md if maintaining these annotations proves too cumbersome,
Just curious what the log bloating you refer to is.
There was a problem hiding this comment.
This was the original command that generated these files, but the two configs have now significantly diverged to the point that it is no longer useful to document this.
There was a problem hiding this comment.
Ah ha - so these files have now been manually changed, since their original kompose convert creation. Makes sense to not document in that case. One question, though, what is the relationship if any between the docker-compose file and the kube files, then? Why do we use one over the other?
NatalieDoduc
left a comment
NatalieDoduc
left a comment
There was a problem hiding this comment.
lgtm, but can you please add information on how/when to update the docker-compose+kube files and vice versa. thanks!
4 participants
The Kubernetes configs were originally created with
kompose convertbut the k8 configs have since significantly diverged due to sidecars, local and gke specific configs.This PR removes kompose metadata that is no longer correct.
The k8 configs and the docker-compose configs are currently maintained by hand because there is not an exact 1:1 feature mapping between them.