Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Use new prometheus sidecar deployment#1483

Merged
gdbelvin merged 4 commits intogoogle:masterfrom
gdbelvin:stackdriver
Mar 3, 2020
Merged

Use new prometheus sidecar deployment#1483
gdbelvin merged 4 commits intogoogle:masterfrom
gdbelvin:stackdriver

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Mar 3, 2020

The old prometheus-to-stackdriver sidecar model has been deprecated.
The new model only has one sidecar that reads from the prometheus server's data directory.
This model is much more efficient. The number of containers drops by 5.

@gdbelvin gdbelvin requested a review from a team as a code owner March 3, 2020 11:52
@gdbelvin gdbelvin requested a review from Martin2112 March 3, 2020 11:52
@gdbelvin gdbelvin changed the title Update prometheus deployment Use new prometheus sidecar deployment Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #1483 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
+ Coverage   67.83%   68.08%   +0.24%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
+ Hits         2731     2741      +10     
+ Misses        893      887       -6     
+ Partials      402      398       -4
Impacted Files Coverage Δ
core/integration/client_tests.go 85.24% <0%> (+0.46%) ⬆️
impl/sql/mutationstorage/mutation_logs.go 73.79% <0%> (+1.37%) ⬆️
core/sequencer/server.go 74.91% <0%> (+1.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260f9dc...61cc4ec. Read the comment docs.

@gdbelvin gdbelvin merged commit 227f113 into google:master Mar 3, 2020
@gdbelvin gdbelvin deleted the stackdriver branch March 3, 2020 12:54
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Mar 25, 2020
* master: (109 commits)
  Upgrade Prometheus (google#1500)
  Run `go build ./...` with github action (google#1446)
  Replace tinkio.ProtoFile with keyset.BinaryReader (google#1492)
  Bump github.com/golang/mock from 1.4.1 to 1.4.2
  Bump github.com/prometheus/client_golang from 1.5.0 to 1.5.1
  Bump github.com/golang/protobuf from 1.3.3 to 1.3.5
  Bump github.com/google/tink from 1.3.0-rc4 to 1.3.0
  New Design Doc (google#1469)
  Acknowledgements (google#1490)
  Use cases (google#1489)
  Bump github.com/prometheus/client_golang from 1.4.1 to 1.5.0 (google#1486)
  README.md # Related (google#1485)
  Explain authorized keys (google#1484)
  Use new prometheus sidecar deployment (google#1483)
  don't overwrite the ReplicaSet service label (google#1482)
  Update encrypted creds (google#1481)
  Pickup DB_HOST env variable (google#1480)
  Fix credential encryption (google#1479)
  Use Cloud MySQL in GKE (google#1473)
  Update client_secrets.json.enc (google#1478)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments