From 34e8c5dcfe5bd4a90db9bb7e2dcb8814a56a18a8 Mon Sep 17 00:00:00 2001 From: kurilova Date: Fri, 2 Feb 2024 12:41:22 +0000 Subject: [PATCH] Disables settings save button if there is no interfaces --- .../ui/src/app/pages/settings/general-settings.component.html | 2 +- .../src/app/pages/settings/general-settings.component.spec.ts | 4 ++-- .../ui/src/app/pages/settings/general-settings.component.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/modules/ui/src/app/pages/settings/general-settings.component.html b/modules/ui/src/app/pages/settings/general-settings.component.html index 2ef5b6725..1ed1aff22 100644 --- a/modules/ui/src/app/pages/settings/general-settings.component.html +++ b/modules/ui/src/app/pages/settings/general-settings.component.html @@ -149,7 +149,7 @@

Connection settings

class="save-button" color="primary" (click)="saveSetting()" - [disabled]="!isFormValues || isLessThanTwoInterfaces"> + [disabled]="!isFormValues || isLessThanOneInterfaces"> Save diff --git a/modules/ui/src/app/pages/settings/general-settings.component.spec.ts b/modules/ui/src/app/pages/settings/general-settings.component.spec.ts index 7d882383f..1cb80f8cf 100644 --- a/modules/ui/src/app/pages/settings/general-settings.component.spec.ts +++ b/modules/ui/src/app/pages/settings/general-settings.component.spec.ts @@ -235,9 +235,9 @@ describe('GeneralSettingsComponent', () => { }); }); - describe('with interfaces length less than two', () => { + describe('with interfaces length less than one', () => { beforeEach(() => { - component.interfaces = { mockDeviceValue: 'mockDeviceValue' }; + component.interfaces = {}; fixture.detectChanges(); }); diff --git a/modules/ui/src/app/pages/settings/general-settings.component.ts b/modules/ui/src/app/pages/settings/general-settings.component.ts index 1626126d5..7b5e90a84 100644 --- a/modules/ui/src/app/pages/settings/general-settings.component.ts +++ b/modules/ui/src/app/pages/settings/general-settings.component.ts @@ -72,8 +72,8 @@ export class GeneralSettingsComponent implements OnInit, OnDestroy { return this.settingForm.hasError('hasSameValues'); } - get isLessThanTwoInterfaces(): boolean { - return Object.keys(this.interfaces).length < 2; + get isLessThanOneInterfaces(): boolean { + return Object.keys(this.interfaces).length < 1; } constructor(