From e5397d8fd9b68244dc9fa380d5b47ca895c0d384 Mon Sep 17 00:00:00 2001 From: kurilova Date: Fri, 15 Mar 2024 13:05:13 +0000 Subject: [PATCH] Remove cancel on download click --- .../version/consent-dialog/consent-dialog.component.html | 3 +-- .../version/consent-dialog/consent-dialog.component.spec.ts | 6 ++---- .../version/consent-dialog/consent-dialog.component.ts | 4 ---- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.html b/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.html index bc8252909..ef488873f 100644 --- a/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.html +++ b/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.html @@ -73,8 +73,7 @@

Welcome to Testrun!

color="primary" mat-button type="button" - aria-label="Download new version" - (click)="cancelOnDownload()"> + aria-label="Download new version"> Download

diff --git a/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.spec.ts b/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.spec.ts index 62a809e03..a7d628c1a 100644 --- a/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.spec.ts +++ b/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.spec.ts @@ -81,7 +81,7 @@ describe('ConsentDialogComponent', () => { closeSpy.calls.reset(); }); - it('should close dialog on download link click', () => { + it('should not close dialog on download link click', () => { const closeSpy = spyOn(component.dialogRef, 'close'); const confirmButton = compiled.querySelector( '.download-link' @@ -89,9 +89,7 @@ describe('ConsentDialogComponent', () => { confirmButton?.click(); - expect(closeSpy).toHaveBeenCalledWith(); - - closeSpy.calls.reset(); + expect(closeSpy).toHaveBeenCalledTimes(0); }); describe('with new version available', () => { diff --git a/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.ts b/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.ts index 61b2a119d..78d1b536a 100644 --- a/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.ts +++ b/modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.ts @@ -48,8 +48,4 @@ export class ConsentDialogComponent { cancel() { this.dialogRef.close(false); } - - cancelOnDownload() { - this.dialogRef.close(); - } }