From c359d1706e1b0c80b0913110018aeb6ed3460373 Mon Sep 17 00:00:00 2001 From: Volha Mardvilka Date: Thu, 21 Mar 2024 11:18:31 +0000 Subject: [PATCH 1/2] 329834205: (fix) apply Angular tooltip to fix the long text issue on hover --- .../download-report-pdf/download-report-pdf.component.spec.ts | 3 --- .../download-report-zip/download-report-zip.component.spec.ts | 3 --- .../components/download-report/download-report.component.html | 2 +- .../download-report/download-report.component.spec.ts | 3 --- .../components/download-report/download-report.component.ts | 3 ++- .../components/delete-report/delete-report.component.html | 2 +- .../components/delete-report/delete-report.component.ts | 3 ++- modules/ui/src/app/pages/testrun/progress.component.spec.ts | 3 --- 8 files changed, 6 insertions(+), 16 deletions(-) diff --git a/modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.spec.ts b/modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.spec.ts index 671f7144f..914c130ac 100644 --- a/modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.spec.ts +++ b/modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.spec.ts @@ -82,9 +82,6 @@ describe('DownloadReportComponent', () => { expect(downloadReportLink.download).toEqual( 'delta_03-din-cpu_1.2.2_compliant_22_jun_2023_9:20' ); - expect(downloadReportLink.title).toEqual( - 'Download pdf for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20' - ); }); }); }); diff --git a/modules/ui/src/app/components/download-report-zip/download-report-zip.component.spec.ts b/modules/ui/src/app/components/download-report-zip/download-report-zip.component.spec.ts index efa8b07c8..b9d492513 100644 --- a/modules/ui/src/app/components/download-report-zip/download-report-zip.component.spec.ts +++ b/modules/ui/src/app/components/download-report-zip/download-report-zip.component.spec.ts @@ -81,9 +81,6 @@ describe('DownloadReportComponent', () => { expect(downloadReportLink.download).toEqual( 'delta_03-din-cpu_1.2.2_compliant_22_jun_2023_9:20' ); - expect(downloadReportLink.title).toEqual( - 'Download zip file for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20' - ); }); }); }); diff --git a/modules/ui/src/app/components/download-report/download-report.component.html b/modules/ui/src/app/components/download-report/download-report.component.html index 14f2a0bf3..e862fc8f5 100644 --- a/modules/ui/src/app/components/download-report/download-report.component.html +++ b/modules/ui/src/app/components/download-report/download-report.component.html @@ -19,7 +19,7 @@ [download]="getReportTitle(data)" [href]="href" target="_blank" - [title]="title"> + [matTooltip]="title"> diff --git a/modules/ui/src/app/components/download-report/download-report.component.spec.ts b/modules/ui/src/app/components/download-report/download-report.component.spec.ts index d167c638f..8bfcbcc9b 100644 --- a/modules/ui/src/app/components/download-report/download-report.component.spec.ts +++ b/modules/ui/src/app/components/download-report/download-report.component.spec.ts @@ -94,9 +94,6 @@ describe('DownloadReportComponent', () => { expect(downloadReportLink.download).toEqual( 'delta_03-din-cpu_1.2.2_compliant_22_jun_2023_9:20' ); - expect(downloadReportLink.title).toEqual( - 'Download pdf for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20' - ); }); }); }); diff --git a/modules/ui/src/app/components/download-report/download-report.component.ts b/modules/ui/src/app/components/download-report/download-report.component.ts index 90c47ed4a..3871bacdb 100644 --- a/modules/ui/src/app/components/download-report/download-report.component.ts +++ b/modules/ui/src/app/components/download-report/download-report.component.ts @@ -16,6 +16,7 @@ import { ChangeDetectionStrategy, Component, Input } from '@angular/core'; import { TestrunStatus } from '../../model/testrun-status'; import { CommonModule, DatePipe } from '@angular/common'; +import { MatTooltipModule } from '@angular/material/tooltip'; import { ReportActionComponent } from '../report-action/report-action.component'; @Component({ @@ -23,7 +24,7 @@ import { ReportActionComponent } from '../report-action/report-action.component' templateUrl: './download-report.component.html', styleUrls: ['./download-report.component.scss'], standalone: true, - imports: [CommonModule], + imports: [CommonModule, MatTooltipModule], providers: [DatePipe], changeDetection: ChangeDetectionStrategy.OnPush, }) diff --git a/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html b/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html index 51458b23b..a90728290 100644 --- a/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html +++ b/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html @@ -17,7 +17,7 @@ diff --git a/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.ts b/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.ts index a0d76fdbd..d96bfaecd 100644 --- a/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.ts +++ b/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.ts @@ -27,11 +27,12 @@ import { MatDialog } from '@angular/material/dialog'; import { DeleteFormComponent } from '../../../../components/delete-form/delete-form.component'; import { takeUntil } from 'rxjs/internal/operators/takeUntil'; import { Subject } from 'rxjs'; +import { MatTooltipModule } from '@angular/material/tooltip'; @Component({ selector: 'app-delete-report', standalone: true, - imports: [CommonModule, MatButtonModule], + imports: [CommonModule, MatButtonModule, MatTooltipModule], templateUrl: './delete-report.component.html', styleUrls: ['./delete-report.component.scss'], providers: [DatePipe], diff --git a/modules/ui/src/app/pages/testrun/progress.component.spec.ts b/modules/ui/src/app/pages/testrun/progress.component.spec.ts index ca6fd3fa3..ee1362fa1 100644 --- a/modules/ui/src/app/pages/testrun/progress.component.spec.ts +++ b/modules/ui/src/app/pages/testrun/progress.component.spec.ts @@ -539,9 +539,6 @@ describe('ProgressComponent', () => { expect(link.download).toEqual( 'delta_03-din-cpu_1.2.2_compliant_22_jun_2023_9:20' ); - expect(link.title).toEqual( - 'Download pdf for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20' - ); }); }); From 53b3dc151a2a47e7f9449ab786dd0dffd69abf6b Mon Sep 17 00:00:00 2001 From: Volha Mardvilka Date: Thu, 21 Mar 2024 12:01:13 +0000 Subject: [PATCH 2/2] 329834205: (fix) change words Test Run to Testrun --- .../download-report-pdf/download-report-pdf.component.html | 2 +- .../download-report-zip/download-report-zip.component.html | 2 +- .../download-report/download-report.component.spec.ts | 2 +- .../components/delete-report/delete-report.component.html | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.html b/modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.html index 5017f5f16..001808452 100644 --- a/modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.html +++ b/modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.html @@ -17,6 +17,6 @@ *ngIf="data" [data]="data" [href]="data.report" - title="Download pdf for Test Run # {{ getTestRunId(data) }}"> + title="Download pdf for Testrun # {{ getTestRunId(data) }}"> diff --git a/modules/ui/src/app/components/download-report-zip/download-report-zip.component.html b/modules/ui/src/app/components/download-report-zip/download-report-zip.component.html index ea11b45ee..7a0278132 100644 --- a/modules/ui/src/app/components/download-report-zip/download-report-zip.component.html +++ b/modules/ui/src/app/components/download-report-zip/download-report-zip.component.html @@ -17,7 +17,7 @@ *ngIf="data" [data]="data" [href]="getZipLink(data)" - title="Download zip file for Test Run # {{ getTestRunId(data) }}"> + title="Download zip file for Testrun # {{ getTestRunId(data) }}"> archive diff --git a/modules/ui/src/app/components/download-report/download-report.component.spec.ts b/modules/ui/src/app/components/download-report/download-report.component.spec.ts index 8bfcbcc9b..5a59f2192 100644 --- a/modules/ui/src/app/components/download-report/download-report.component.spec.ts +++ b/modules/ui/src/app/components/download-report/download-report.component.spec.ts @@ -76,7 +76,7 @@ describe('DownloadReportComponent', () => { beforeEach(() => { component.data = MOCK_PROGRESS_DATA_COMPLIANT; component.title = - 'Download pdf for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20'; + 'Download pdf for Testrun # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20'; component.href = MOCK_PROGRESS_DATA_COMPLIANT.report; fixture.detectChanges(); diff --git a/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html b/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html index a90728290..7b074ec54 100644 --- a/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html +++ b/modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html @@ -17,7 +17,7 @@