From 3a97554a0424029f01c40b929a43c34fda916461 Mon Sep 17 00:00:00 2001 From: jhughesbiot Date: Mon, 8 Jul 2024 15:20:25 -0600 Subject: [PATCH] Fix modbus results --- .../test/protocol/python/src/protocol_module.py | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/modules/test/protocol/python/src/protocol_module.py b/modules/test/protocol/python/src/protocol_module.py index 407a46777..4f7c1a7e7 100644 --- a/modules/test/protocol/python/src/protocol_module.py +++ b/modules/test/protocol/python/src/protocol_module.py @@ -86,16 +86,21 @@ def _protocol_valid_modbus(self, config): # Extract basic device connection information modbus = Modbus(log=LOGGER, device_ip=self._device_ipv4_addr, config=config) results = modbus.validate_device() + result_status = None + result_description = '' + result_details = results[1] # Determine results and return proper messaging and details if results[0] is None: - result = ('Feature Not Detected', - 'Device did not respond to Modbus connection') + result_status = 'Feature Not Detected' + result_description = 'Device did not respond to Modbus connection' elif results[0]: - result = True, 'Valid modbus communication detected' + result_status = True + result_description = 'Valid modbus communication detected' else: - result = False, 'Failed to confirm valid modbus communication' - return result, results[1] + result_status = False + result_description = 'Failed to confirm valid modbus communication' + return result_status, result_description, result_details def get_local_ip(self, interface_name): try: