From 9e714883a4dd44674de926be2cc745138998447f Mon Sep 17 00:00:00 2001 From: Rob Percival Date: Wed, 12 Jul 2017 17:54:33 +0100 Subject: [PATCH] Upgrade logging of ExecutePass() failure from warning to error This is particularly helpful for the integration tests, as they will show error logging but not warning logging. Since the err is swallowed, the integration tests will never end (until they timeout), and this is surprising if no errors are logged. --- server/log_operation_manager.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/log_operation_manager.go b/server/log_operation_manager.go index c6f3b7352c..961406e30a 100644 --- a/server/log_operation_manager.go +++ b/server/log_operation_manager.go @@ -341,7 +341,7 @@ func (l *LogOperationManager) getLogsAndExecutePass(ctx context.Context) error { start := time.Now() count, err := l.logOperation.ExecutePass(ctx, logID, &l.info) if err != nil { - glog.Warningf("ExecutePass(%v) failed: %v", logID, err) + glog.Errorf("ExecutePass(%v) failed: %v", logID, err) continue }